New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update project links #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is like commit 7ce1113 from the v1.x branch but for the v0.10 branch. The project home has moved, update the links in the README.
LGTM |
Crunkle
pushed a commit
to Crunkle/libuv
that referenced
this pull request
Aug 8, 2019
trevnorris
added a commit
to trevnorris/libuv
that referenced
this pull request
Mar 31, 2023
Proof-of-concept to demonstrate the API of being able to queue work from any thread, without needing to be attached to a specific event loop. There's a problem when running the test threadpool_task. It shows uv_library_shutdown() running even though it's never called. Which is causing it to abort. Here's the stack: * thread #1, name = 'uv_run_tests_a', stop reason = signal SIGABRT frame libuv#6: 0x00000000004ce768 uv_run_tests_a`uv__threadpool_cleanup at threadpool.c:192:3 frame libuv#7: 0x00000000004d5d56 uv_run_tests_a`uv_library_shutdown at uv-common.c:956:3 frame libuv#8: 0x00007ffff7fc924e frame libuv#9: 0x00007ffff7c45495 libc.so.6`__run_exit_handlers(status=0, listp=<unavailable>, run_list_atexit=true, run_dtors=true) at exit.c:113:8 Can't figure out why this is happening. Another problem is when you remove the uv_sleep() from task_cb() it'll cause another abort when trying to lock the mutex. Here's the stack: frame libuv#8: 0x00000000004ed375 uv_run_tests_a`uv_mutex_lock(mutex=0x0000000001460c50) at thread.c:344:7 frame libuv#9: 0x00000000004cebdf uv_run_tests_a`uv__queue_work(w=0x0000000001462378) at threadpool.c:342:5 (lldb) f 9 frame libuv#9: 0x00000000004cebdf uv_run_tests_a`uv__queue_work(w=0x0000000001462378) at threadpool.c:342:5 341 if (w->done == NULL) { -> 342 uv_mutex_lock(&mutex); 343 w->work = NULL; Still not sure if this is a race condition.
trevnorris
added a commit
to trevnorris/libuv
that referenced
this pull request
Mar 31, 2023
Proof-of-concept to demonstrate the API of being able to queue work from any thread, without needing to be attached to a specific event loop. There's a problem when running the test threadpool_task. It shows uv_library_shutdown() running even though it's never called. Which is causing it to abort. Here's the stack: * thread #1, name = 'uv_run_tests_a', stop reason = signal SIGABRT frame libuv#6: 0x00000000004ce768 uv_run_tests_a`uv__threadpool_cleanup at threadpool.c:192:3 frame libuv#7: 0x00000000004d5d56 uv_run_tests_a`uv_library_shutdown at uv-common.c:956:3 frame libuv#8: 0x00007ffff7fc924e frame libuv#9: 0x00007ffff7c45495 libc.so.6`__run_exit_handlers(status=0, listp=<unavailable>, run_list_atexit=true, run_dtors=true) at exit.c:113:8 Can't figure out why this is happening. Another problem is when you remove the uv_sleep() from task_cb() it'll cause another abort when trying to lock the mutex. Here's the stack: frame libuv#8: 0x00000000004ed375 uv_run_tests_a`uv_mutex_lock(mutex=0x0000000001460c50) at thread.c:344:7 frame libuv#9: 0x00000000004cebdf uv_run_tests_a`uv__queue_work(w=0x0000000001462378) at threadpool.c:342:5 (lldb) f 9 frame libuv#9: 0x00000000004cebdf uv_run_tests_a`uv__queue_work(w=0x0000000001462378) at threadpool.c:342:5 341 if (w->done == NULL) { -> 342 uv_mutex_lock(&mutex); 343 w->work = NULL; Still not sure if this is a race condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is like commit 7ce1113 from the v1.x branch but for the v0.10
branch. The project home has moved, update the links in the README.
R=@saghul