You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm opening this as an issue instead of directly PRing a fix because it may be worthwhile to consider using the libvips API directly so that issues like this can be avoided in the future.
The text was updated successfully, but these errors were encountered:
I think the best solutions would be to either make vips_addalpha a true operation (and so skip the wrapping), or to fix the python implementation of this utility function. Calling into the C wrapper from the python wrapper would be fiddly and error-prone.
The following Python code:
produces
whereas the (hopefully) equivalent C code:
Click to open
(this is my first time calling libvips from C — if I'm doing something wrong, please let me know!)
produces
This happens because pyvips re-implements the
addalpha
function, and this (re-)implementation wasn't updated when the upstream changed.I'm opening this as an issue instead of directly PRing a fix because it may be worthwhile to consider using the libvips API directly so that issues like this can be avoided in the future.
The text was updated successfully, but these errors were encountered: