Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SP3] Fixed displaying patch categories (bsc#1174390) #48

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Aug 24, 2021

The Bug

missing_category

  • https://bugzilla.suse.com/show_bug.cgi?id=1174390
  • In some special cases the patch category was not displayed. It works fine in a VirtualBox VM or at bare metal, I could only reproduce it inside a KVM VM running YaST in KDE desktop.
  • But because of the nature of the bug it could randomly happen basically anywhere (see below)

The Fix

  • It turned out that the code used a wrong index column which is not used anymore and which was not even initialized.
  • It basically used any random value found in that part of the memory
  • Besides using the correct column index I added an initialization so the variable does not have undefined (random) value anymore to avoid similar problems

TODO

  • In the future we should remove all that unused code and variables, they can only make troubles like this... There is also quite a lot of commented out code.

Copy link
Contributor

@shundhammer shundhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit 0c51ed7 into SLE-15-SP3 Aug 24, 2021
@lslezak lslezak deleted the patch_categories_sp3 branch August 24, 2021 14:39
@lslezak
Copy link
Member Author

lslezak commented Aug 24, 2021

Sumitted manually in https://build.suse.de/request/show/248766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants