Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetConnection.m_sentPingTime #60

Closed
forestrf opened this issue Dec 19, 2015 · 1 comment
Closed

NetConnection.m_sentPingTime #60

forestrf opened this issue Dec 19, 2015 · 1 comment

Comments

@forestrf
Copy link
Contributor

In the class NetConnection, the variable m_sentPingTime receives a value at InitializePing() that SendPing() overwritten a little after without being readed.

What was the intention of this lines?

// randomize ping sent time (0.25 - 1.0 x ping interval)
m_sentPingTime = now;
m_sentPingTime -= (m_peerConfiguration.PingInterval * 0.25f); // delay ping for a little while
m_sentPingTime -= (MWCRandom.Instance.NextSingle() * (m_peerConfiguration.PingInterval * 0.75f));

Thank you

@lidgren
Copy link
Owner

lidgren commented Feb 5, 2016

You are correct. Removed in latest commit.

@lidgren lidgren closed this as completed Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants