Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lido V2: initial doc rework #217

Open
25 of 33 tasks
TheDZhon opened this issue Jun 20, 2023 · 3 comments
Open
25 of 33 tasks

Lido V2: initial doc rework #217

TheDZhon opened this issue Jun 20, 2023 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@TheDZhon
Copy link
Contributor

TheDZhon commented Jun 20, 2023

@TheDZhon TheDZhon added the documentation Improvements or additions to documentation label Jun 21, 2023
@arwer13
Copy link
Contributor

arwer13 commented Jun 27, 2023

One discrepancy nice to unify is "Callable only by owner" and "Reverts if msg.sender is not owner", wdyt?

@folkyatina
Copy link
Member

One discrepancy nice to unify is "Callable only by owner" and "Reverts if msg.sender is not owner", wdyt?

TBH, not really get the context.

@arwer13
Copy link
Contributor

arwer13 commented Jun 29, 2023

There are places with
(1): Only callable by the owner. and
(2):

:::note
Reverts if any of the following is true:
* `msg.sender` is not the owner;

I would prefer to leave only the line in reverts section.

UPD: ok, there were only Burner and DSM with "only callable...". Its replaced to option (1) in Burner already, so I would prefer even more to use (2) in DSM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

6 participants
@TheDZhon @folkyatina @loga4 @arwer13 @mymphe and others