Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest: [intl refactoring support] #342

Open
1 of 7 tasks
lifeart opened this issue Dec 8, 2021 · 3 comments
Open
1 of 7 tasks

Quest: [intl refactoring support] #342

lifeart opened this issue Dec 8, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lifeart
Copy link
Owner

lifeart commented Dec 8, 2021

@lifeart lifeart changed the title Quest [intl refactoring] Quest [intl refactoring support] Dec 8, 2021
@lifeart
Copy link
Owner Author

lifeart commented Dec 8, 2021

@odric3 let me know if we need to add something here

@godric3
Copy link

godric3 commented Dec 8, 2021

Thanks for organizing it a bit, I already started to look into translation store, with some achievements, but didn't had much time to really work on that. For searching through scripts and templates I base my approach on existing template token collection, but I'm not sure how to include translation files in that logic. Should I do something similar as findTestsForProject from layout-helpers but for translations?

@lifeart
Copy link
Owner Author

lifeart commented Dec 8, 2021

I think we should rely on config/intl.js configuration for translations lookup, and likely 'intl' service should be responsible for it, every Project instance should have it's own Intl service to work with, and during project initialization (or delayed) we could call something like project.intl.findTranslations() and intl service could work with our global defined tokens collectors

@lifeart lifeart changed the title Quest [intl refactoring support] Quest: [intl refactoring support] Feb 6, 2022
@lifeart lifeart added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants