Fix Greenkeeper's initial PR #10
Conversation
spiffytech
force-pushed
the
greenkeeper/initial
branch
from
61fa857
to
6160bdc
Compare
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@lifeomic/bitrise", | |||
| "version": "0.4.0", | |||
| "version": "0.5.0", | |||
There was a problem hiding this comment.
Can you revert this version bump? If you want to signify that the next vesion should be a patch bump, you can change the version to 0.5.0-alpha
There was a problem hiding this comment.
I went with a pre-release major version bump because Greenkeeper's AVA bump drops support for node 9, which seemed like a breaking change. Is that incorrect?
There was a problem hiding this comment.
Just saw your other versioning comment, yes, I'll mark this as alpha.
There was a problem hiding this comment.
You had the right goal. Something about the version should be bumped due to the change. We use npm version to release changes and it likes to make the version update itself. By using the tagging I suggested, it signals what type of version bump the next increment should be
spiffytech
force-pushed
the
greenkeeper/initial
branch
from
6160bdc
to
4ad6393
Compare
Greenkeeper submitted a PR and won't watch the repo until that PR is merged. This PR into Greenkeeper's PR fixes the unit tests that were broken by upgrading AVA.
It also removes the Travis build for node v9, since AVA doesn't support that anymore.