Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Greenkeeper's initial PR #10

Merged
merged 2 commits into from
Aug 27, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
language: node_js
node_js:
- '8'
- '9'
- '10'
- '11'
- '12'
before_install: yarn global add greenkeeper-lockfile@1
before_script: greenkeeper-lockfile-update
script: yarn test
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lifeomic/bitrise",
"version": "0.4.0",
"version": "0.5.0-alpha",
"description": "Bitrise API client",
"main": "src/client.js",
"repository": {
Expand Down
4 changes: 2 additions & 2 deletions test/build.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ test.serial('following a failed build that has not finished prints the log outpu
const write = sinon.stub(process.stdout, 'write');

try {
await test.throws(build.follow());
await test.throwsAsync(() => build.follow());

for (const chunk of logChunks) {
sinon.assert.calledWithExactly(write, chunk);
Expand Down Expand Up @@ -134,7 +134,7 @@ test('following a failed build that has already finished prints the log output a
const write = sinon.stub(process.stdout, 'write');

try {
await test.throws(build.follow());
await test.throwsAsync(() => build.follow());
sinon.assert.calledWithExactly(write, logText);
} finally {
write.restore();
Expand Down
2 changes: 1 addition & 1 deletion test/client.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ test.serial('a client gives up after too many retries', async (test) => {

sinon.assert.calledOnce(create);
const httpClient = create.firstCall.returnValue;
const { response } = await test.throws(httpClient.get('http://localhost/error'));
const { response } = await test.throwsAsync(() => httpClient.get('http://localhost/error'));
test.is(response.status, 500);
} finally {
create.restore();
Expand Down