feat: Update chromicons and icon typings

[hewayman]

The icon typings here need to be updated so the latest version of chromicons can be used in PHC-UI.

[swain]

Is this a breaking change to the types?

[hewayman]

Is this a breaking change to the types?

@swain I was trying to avoid breaking anything. This change reflects the correct types in the newest version of chromicons. I can't update chromicons in PHC-UI without breaking anything (because of the mismatched types), so I was updating the types here first. I thought the changes here would be released as a new version, so then I could use the newer versions of chromicons and chroma-react at the same time in PHC-UI. Is there a better way to handle this?

[swain]

@hewayman Your logic all makes sense to me. Only reason I asked: if this is a breaking change, we should mark it as such with a major version bump.

You can do that by adding a new commit (or amending your existing one) to match this message syntax:

feat!: blah blah blah

The ! marks the commit as a breaking change, and will cause semantic-release to release this change as a major version bump.

[sternetj]

Swain means a breaking change as in the API is changing which means when consumers of this library upgrade their version of chroma-react, they will need to make some change.

I think we should consider this breaking. I think we should update the peer dependencies to reference the lowest version of chromicons that had the API change, v3.0.0.

A "breaking change" really just means we need to bump the major version of the library. This can be done by commenting with an exclamation mark in the commit after the semmantic tag. i.e. feat!: Update the peer dependency for chromicons

[hewayman]

@swain @sternetj That makes sense. I missed the note about ! in the docs. I'll do that and update the peer dependencies to 3.0.0. Thanks

[lifeomic-probot]

⚠️ Detected a breaking change in commit 8f2ce90

Merging this PR will result in a major version bump.

Created by lifeomic-probot (Enforce Semantic Commits)

[github-actions]

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀