Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message preview #397

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Add message preview #397

merged 3 commits into from
Oct 5, 2023

Conversation

bruce-glazier
Copy link
Contributor

Changes

Load the latest message between two users on the My Messages screen.
image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6410724994

  • 6 of 15 (40.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 82.517%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hooks/Circles/usePrivatePosts.ts 1 10 10.0%
Totals Coverage Status
Change from base Build 6396969672: -0.2%
Covered Lines: 3002
Relevant Lines: 3546

💛 - Coveralls

@@ -62,6 +75,7 @@ export const useMyMessages = (tileId: string) => {
displayName: data.user.profile.displayName,
picture: data.user.profile.picture,
isUnread: unreadIds?.includes(data.user.userId) ?? false,
message: data.privatePosts.edges?.[0]?.node.message,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we call this latestMessage for clarity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll address this feedback in follow up PR

@bruce-glazier bruce-glazier merged commit 724bfb3 into master Oct 5, 2023
4 checks passed
@bruce-glazier bruce-glazier deleted the FLME-184-Add-message-preview branch October 5, 2023 15:28
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

🎉 This PR is included in version 3.13.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants