Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve the compose new message screen #446

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix: Improve the compose new message screen #446

merged 2 commits into from
Nov 9, 2023

Conversation

bruce-glazier
Copy link
Contributor

@bruce-glazier bruce-glazier commented Nov 8, 2023 •
edited

Changes

  • Improve the compose new message screen by sorting providers and patients into two separate fields.
  • Only providers will be given the patient field which has a limit of one patient.

Screenshots

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-11-09.at.09.51.32.mp4

@coveralls
Copy link

coveralls commented Nov 8, 2023 •
edited

Pull Request Test Coverage Report for Build 6813481522

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 55 of 56 (98.21%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 83.791%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/screens/ComposeMessageScreen.tsx 33 34 97.06%
Totals Coverage Status
Change from base Build 6803187057: 0.06%
Covered Lines: 3188
Relevant Lines: 3699
💛 - Coveralls

@bruce-glazier bruce-glazier changed the title fix: Improve selection screen fix: Improve the compose new message screen Nov 9, 2023
sternetj
sternetj approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@sternetj sternetj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

markdlv
markdlv reviewed Nov 9, 2023
View reviewed changes
src/hooks/useAppConfig.tsx
@@ -27,7 +27,7 @@ export interface CircleTile {

export interface MessageTile {
id: string;
providerUserIds: string;
providerUserIds: string[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this just wrong before? Or breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just wrong before 😬

@bruce-glazier bruce-glazier merged commit 8a863bf into master Nov 9, 2023
3 checks passed
@bruce-glazier bruce-glazier deleted the improve-provider-patient-selection branch November 9, 2023 16:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

🎉 This PR is included in version 5.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdlv markdlv markdlv approved these changes

@sternetj sternetj sternetj approved these changes

Assignees
No one assigned
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
Milestone
No milestone
4 participants
@bruce-glazier @coveralls @markdlv @sternetj