Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-129397 #322

Closed
wants to merge 6 commits into from
Closed

LPS-129397 #322

wants to merge 6 commits into from

Conversation

martamedio
Copy link

liferay-appsec
liferay-appsec reviewed Mar 25, 2021
View reviewed changes
Copy link
Owner

@liferay-appsec liferay-appsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an automatic review suggestion

modules/apps/oauth2-provider/oauth2-provider-web/src/main/resources/content/Language.properties
@@ -19,6 +19,9 @@ are-you-sure-you-want-to-delete-the-application-this-action-revokes-one-authoriz
are-you-sure-you-want-to-delete-the-application-this-action-revokes-x-authorizations-and-associated-tokens=Are you sure you want to delete the application? This actions revokes {0} authorizations and associated tokens.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that added properties are either titles or sentences

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@martamedio
Copy link
Author

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 20206ada64511caf36d53e6bf5781dfe948f2f30

Sender Branch:

Branch Name: LPS-129397
Branch GIT ID: 6c54283d5df626bec88bef7c6d4ae0712f2039bf

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@csierra
Copy link

csierra commented Mar 25, 2021

LGTM @martamedio

@martamedio
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 02c62c690a8056ad107ac4f79b69cadca07d027c

Sender Branch:

Branch Name: LPS-129397
Branch GIT ID: cb4ad087a886155f9552945d1dbcca82964bd964

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 21 out of 22 jobs passed in 1 hour 16 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 02c62c690a8056ad107ac4f79b69cadca07d027c

Upstream Comparison:

Branch GIT ID: 02c62c690a8056ad107ac4f79b69cadca07d027c
Jenkins Build URL: Acceptance Upstream DXP (master) #1676

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 20 out of 22 jobs PASSED
20 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 02c62c6:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    416 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #429808
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
Unsecure HTTP, HTTPS is recommended
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#100300
Console

@martamedio martamedio deleted the LPS-129397 branch April 29, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liferay-appsec liferay-appsec liferay-appsec left review comments

Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martamedio @liferay-continuous-integration @csierra @liferay-appsec