Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMERCE-7280 Fix order checkout when clicking reorder or checkout from order content portlet #1788

Closed
wants to merge 1 commit into from

Conversation

dsitu
Copy link
Collaborator

@dsitu dsitu commented Sep 24, 2021

@liferay-continuous-integration
Copy link
Collaborator

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@dsitu
Copy link
Collaborator Author

dsitu commented Sep 24, 2021

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2469ba05649e60d661f2e1e639365a5813861555

Sender Branch:

Branch Name: COMMERCE-7280
Branch GIT ID: 9a8610ac80dad666e988593515efe9f0d6cfba77

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@dsitu
Copy link
Collaborator Author

dsitu commented Sep 24, 2021

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 21 out of 24 jobs passed in 2 hours 31 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1337401_200

Base Branch:

Branch Name: master
Branch GIT ID: 2469ba05649e60d661f2e1e639365a5813861555

Upstream Comparison:

Branch GIT ID: aac22c8dae77285380cd1a2332a6915b990c14d6
Jenkins Build URL: Acceptance Upstream DXP (master) #2348

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 21 out of 24 jobs PASSED
21 Successful Jobs:
For more details click here.

Failures unique to this pull:


Failures in common with acceptance upstream results at aac22c8:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    3015 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=1 #7543
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=69640, name=com.liferay.portal.kernel.model.Layout, primKey=51, scope=4}
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=69640, name=com.liferay.portal.kernel.model.Layout, primKey=51, scope=4}
        	at com.liferay.portal.events.ServicePreAction.run(ServicePreAction.java:153)
        	at com.liferay.portal.kernel.events.Action.processLifecycleEvent(Action.java:34)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:80)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:52)
        	at com.liferay.portal.internal.servlet.MainServlet._processServicePre(MainServlet.java:1069)
        	at com.liferay.portal.internal.servlet.MainServlet.service(MainServlet.java:556)
        	at javax.servlet.http.HttpServlet.service(HttpServlet.java:733)
        	at com.liferay.shielded.container.internal.proxy.ServletWrapper.service(ServletWrapper.java:113)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
        	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
        	at org.apache.catalina.core.ApplicationFilterChain.in...
    2. AXIS_VARIABLE=4 #7543
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=42801, name=com.liferay.portal.kernel.model.Layout, primKey=17, scope=4}
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=42801, name=com.liferay.portal.kernel.model.Layout, primKey=17, scope=4}
        	at com.liferay.portal.events.ServicePreAction.run(ServicePreAction.java:153)
        	at com.liferay.portal.kernel.events.Action.processLifecycleEvent(Action.java:34)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:80)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:52)
        	at com.liferay.portal.internal.servlet.MainServlet._processServicePre(MainServlet.java:1069)
        	at com.liferay.portal.internal.servlet.MainServlet.service(MainServlet.java:556)
        	at javax.servlet.http.HttpServlet.service(HttpServlet.java:733)
        	at com.liferay.shielded.container.internal.proxy.ServletWrapper.service(ServletWrapper.java:113)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
        	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
        	at org.apache.catalina.core.ApplicationFilterChain.in...

@liferay-continuous-integration
Copy link
Collaborator

@dsitu
Copy link
Collaborator Author

dsitu commented Sep 24, 2021

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 22 out of 24 jobs passed in 1 hour 38 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1257401_328

Base Branch:

Branch Name: master
Branch GIT ID: 5b9ceec5ccb7023f388afc6c606cff7064d0d65d

Upstream Comparison:

Branch GIT ID: 2469ba05649e60d661f2e1e639365a5813861555
Jenkins Build URL: Acceptance Upstream DXP (master) #2349

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 22 out of 24 jobs PASSED
22 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    3014 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=4 #7584
      1. com.liferay.commerce.service.test.CommerceOrderItemLocalServiceTest.testAddProductBundleDynamicOptionLinkedToSKUAlreadyInOrder
        java.lang.AssertionError: 
        [
        SCENARIO Add a product bundle that is linked to a cpInstance already present in the order
        GIVEN An order with an orderItem containing a cpInstance
        WHEN I add a bundle with an option value linked to the same cpInstance
        THEN The order is updated adding 2 orderItems. 1 for the bundle and 1 for the option. Price and quantities of orderItems shall be updated accordingly.
        ]
        [
        Message: expected:<10> but was:<2>
        ]
        	at org.junit.Assert.fail(Assert.java:89)
        	at org.junit.Assert.failNotEquals(Assert.java:835)
        	at org.junit.Assert.assertEquals(Assert.java:647)
        	at org.junit.Assert.assertEquals(Assert.java:633)
        	at com.liferay.commerce.service.test.CommerceOrderItemLocalServiceTest._assertAddProductBundleLinkedToSKUAlreadyInOrder(CommerceOrderItemLocalServiceTest.java:1371)
        	at com.liferay.commerce.service.test.CommerceOrderItemLocalServiceTest.testAddProductBundleDynamicOptionLinkedToSKUAlreadyInOrder(CommerceOrderItemLocalServiceTest.java:357)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
        	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        	at org.junit.internal.runners...

Failures in common with acceptance upstream results at 2469ba0:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    3014 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=1 #7584
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=78617, name=com.liferay.portal.kernel.model.Layout, primKey=51, scope=4}
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=78617, name=com.liferay.portal.kernel.model.Layout, primKey=51, scope=4}
        	at com.liferay.portal.events.ServicePreAction.run(ServicePreAction.java:153)
        	at com.liferay.portal.kernel.events.Action.processLifecycleEvent(Action.java:34)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:80)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:52)
        	at com.liferay.portal.internal.servlet.MainServlet._processServicePre(MainServlet.java:1069)
        	at com.liferay.portal.internal.servlet.MainServlet.service(MainServlet.java:556)
        	at javax.servlet.http.HttpServlet.service(HttpServlet.java:764)
        	at com.liferay.shielded.container.internal.proxy.ServletWrapper.service(ServletWrapper.java:113)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
        	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
        	at org.apache.catalina.core.ApplicationFilterChain.in...
    2. AXIS_VARIABLE=4 #7584
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Duplicate entry '20100-com.liferay.commerce.product-4-com.liferay.commerce.produc' for key 'IX_A9FF4B2C'
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        	at java.nio.file.Files.walkFileTree(Files.java:2670)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
        

@liferay-continuous-integration
Copy link
Collaborator

@dsitu
Copy link
Collaborator Author

dsitu commented Sep 24, 2021

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9a4c572d2026ea6378d782a6a19f963ece143810

Sender Branch:

Branch Name: COMMERCE-7280
Branch GIT ID: a959b9bc493956abf3e9bce164b476884ba7764f

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@ivicac
Copy link

ivicac commented Sep 27, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 23 out of 24 jobs passed in 1 hour 46 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9a4c572d2026ea6378d782a6a19f963ece143810

Upstream Comparison:

Branch GIT ID: c7b6198fdeced9882703db93bbbb31a5d6891df4
Jenkins Build URL: Acceptance Upstream DXP (master) #2356

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 22 out of 24 jobs PASSED
22 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at c7b6198:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    3014 Tests Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0 #8202
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.verify.VerifyException: com.liferay.commerce.currency.exception.NoSuchCurrencyException: No CommerceCurrency exists with the key {companyId=20100, code=USD}
        com.liferay.portal.verify.VerifyException: com.liferay.commerce.currency.exception.NoSuchCurrencyException: No CommerceCurrency exists with the key {companyId=20100, code=USD}
        	at com.liferay.portal.verify.VerifyProcess.verify(VerifyProcess.java:84)
        	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands.executeVerifyProcesses(VerifyProcessTrackerOSGiCommands.java:293)
        	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands$1.run(VerifyProcessTrackerOSGiCommands.java:345)
        	at com.liferay.portal.output.stream.container.internal.OutputStreamContainerFactoryTrackerImpl.runWithSwappedLog(OutputStreamContainerFactoryTrackerImpl.java:134)
        	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands.executeVerifyProcesses(VerifyProcessTrackerOSGiCommands.java:340)
        	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands._execute(VerifyProcessTrackerOSGiCommands.java:394)
        	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands.access$200(VerifyProcessTrackerOSGiCommands.java:79)
        	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands$VerifyServic...
    2. AXIS_VARIABLE=1 #8202
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=82727, name=com.liferay.portal.kernel.model.Layout, primKey=58, scope=4}
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=82727, name=com.liferay.portal.kernel.model.Layout, primKey=58, scope=4}
        	at com.liferay.portal.events.ServicePreAction.run(ServicePreAction.java:153)
        	at com.liferay.portal.kernel.events.Action.processLifecycleEvent(Action.java:34)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:80)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:52)
        	at com.liferay.portal.internal.servlet.MainServlet._processServicePre(MainServlet.java:1069)
        	at com.liferay.portal.internal.servlet.MainServlet.service(MainServlet.java:556)
        	at javax.servlet.http.HttpServlet.service(HttpServlet.java:764)
        	at com.liferay.shielded.container.internal.proxy.ServletWrapper.service(ServletWrapper.java:113)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
        	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
        	at org.apache.catalina.core.ApplicationFilterChain.in...
    3. AXIS_VARIABLE=4 #8202
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=104080, name=com.liferay.portal.kernel.model.Layout, primKey=71, scope=4}
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=104080, name=com.liferay.portal.kernel.model.Layout, primKey=71, scope=4}
        	at com.liferay.portal.events.ServicePreAction.run(ServicePreAction.java:153)
        	at com.liferay.portal.kernel.events.Action.processLifecycleEvent(Action.java:34)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:80)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:52)
        	at com.liferay.portal.internal.servlet.MainServlet._processServicePre(MainServlet.java:1069)
        	at com.liferay.portal.internal.servlet.MainServlet.service(MainServlet.java:556)
        	at javax.servlet.http.HttpServlet.service(HttpServlet.java:764)
        	at com.liferay.shielded.container.internal.proxy.ServletWrapper.service(ServletWrapper.java:113)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
        	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
        	at org.apache.catalina.core.ApplicationFilterChain....

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#107835
Console

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 23 out of 24 jobs passed in 1 hour 56 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9a4c572d2026ea6378d782a6a19f963ece143810

Upstream Comparison:

Branch GIT ID: c7b6198fdeced9882703db93bbbb31a5d6891df4
Jenkins Build URL: Acceptance Upstream DXP (master) #2356

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 22 out of 24 jobs PASSED
22 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at c7b6198:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    3015 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=4 #6504
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=70567, name=com.liferay.portal.kernel.model.Layout, primKey=75, scope=4}
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=70567, name=com.liferay.portal.kernel.model.Layout, primKey=75, scope=4}
        	at com.liferay.portal.events.ServicePreAction.run(ServicePreAction.java:153)
        	at com.liferay.portal.kernel.events.Action.processLifecycleEvent(Action.java:34)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:80)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:52)
        	at com.liferay.portal.internal.servlet.MainServlet._processServicePre(MainServlet.java:1069)
        	at com.liferay.portal.internal.servlet.MainServlet.service(MainServlet.java:556)
        	at javax.servlet.http.HttpServlet.service(HttpServlet.java:764)
        	at com.liferay.shielded.container.internal.proxy.ServletWrapper.service(ServletWrapper.java:113)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
        	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
        	at org.apache.catalina.core.ApplicationFilterChain.in...

@liferay-continuous-integration
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants