COMMERCE-8305 #2191

brianikim · 2022-02-01T23:53:40Z

https://issues.liferay.com/browse/COMMERCE-8305

@ivicac , this one is another edge case similar to COMMERCE-7998.

…nces

…e job reports

…ob properties

…of the page is export-for-translation

…name of the zip file it's the name of the classname

…unt as different models so extract the method to know if are multiple or not this must change when exporting several models and several experiences.

…the fragmentEntryLink is updated. Updating the current fragmentEntryLink module will keep the url of the resource, meaning that if it was already cached, the new version won't be show. Registering a new module taking into account the modifiedDate of the fragment will generate a new url, bypassing the possible caches

The default log level reports *a lot* of noise on a vanilla system that's not connected to AC - e.g. one message "DEBUG [BaseAnalyticsClientImpl:49] Analytics configuration tracker not active" _per http request_.

…iptions

…nodes do not need to define ids)

…lements

…n be shown

…repeated code

liferay-continuous-integration · 2022-02-01T23:53:46Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

brianikim · 2022-02-01T23:53:55Z

ci:test:sf

brianikim · 2022-02-01T23:54:02Z

ci:test:relevant

liferay-continuous-integration · 2022-02-01T23:56:54Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b9b0dee253287fb23e10736f989d56872ef29f14

Sender Branch:

Branch Name: COMMERCE-8305
Branch GIT ID: 1f598fbc1e6cacdbf765dd5e9b75459f6baf138e

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2022-02-02T00:00:36Z

Jenkins Build:test-portal-source-format#1472

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-commerce#2191

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - brianikim > liferay-commerce - PR#2191 - 2022-02-01[15:54:10]

Testray Importer:publish-testray-report#5143

liferay-continuous-integration · 2022-02-02T02:04:19Z

✔️ ci:test:stable - 21 out of 26 jobs passed

✔️ ci:test:relevant - 22 out of 27 jobs passed in 2 hours 9 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b9b0dee253287fb23e10736f989d56872ef29f14

Upstream Comparison:

Branch GIT ID: b9b0dee253287fb23e10736f989d56872ef29f14
Jenkins Build URL: Acceptance Upstream DXP (master) #2877

ci:test:stable - 21 out of 26 jobs PASSED

5 Failed Jobs:

21 Successful Jobs:

ci:test:relevant - 21 out of 27 jobs PASSED

6 Failed Jobs:

21 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at b9b0dee:

test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8/0

Job Results:

15 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=14 #27763

     [exec] > Task :third-party:org-springframework-orm:compileJava FAILED
     [exec] 
     [exec] > Task :third-party:org-springframework-orm:copyLibs SKIPPED
     [exec] > Task :third-party:org-springframework-orm:copyPatchOriginalLibClasses
     [exec] > Task :third-party:org-springframework-orm:copyCSS NO-SOURCE
     [exec] > Task :third-party:org-springframework-orm:buildCSS NO-SOURCE
     [exec] > Task :third-party:org-springframework-orm:processResources
     [exec] > Task :third-party:org-springframework-orm:jarPatched
     [exec] > Task :third-party:org-springframework-orm:zipZippableResources UP-TO-DATE
     [exec] > Task :third-party:org-springframework-orm:jarSources
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] 
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:buildWSDLCompileCheckVatService
     [exec] 
     [exec] > Task :third-party:org-springframework-orm:jarSourcesCommercial
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:buildWSDLCheckVatService
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:buildWSDL
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:compileJava NO-SOURCE
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:copyLibs SKIPPED
     [exec] > Task :util:deployment-helper:compileJava
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:copyCSS NO-SOURCE
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:buildCSS NO-SOURCE
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:processResources
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:classes
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:zipZippableResources UP-TO-DATE
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:jar
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:autoUpdateXml SKIPPED
     [exec] > Task :third-party:vies-taxud-eu-europa-ec:assemble
     [exec] > Task :util:deployment-helper:copyLibs SKIPPED
     [exec] > Task :util:deployment-helper:copyCSS NO-SOURCE
     [exec] > Task :util:deployment-helper:buildCSS NO-SOURCE
     [exec] > Task :util:deployment-helper:processResources
     [exec] > Task :util:deployment-helper:classes
     [exec] > Task :util:deployment-helper:zipZippableResources UP-TO-DATE
     [exec] 
     [exec] > Task :util:deployment-helper:jar
     [exec] warning: Export com.liferay.deployment.helper,  has 1,  private references [org.zeroturnaround.zip]
     [exec]

test-portal-acceptance-pullrequest-batch(master)/rest-builder-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #349705

Please fix semantic versioning on brianikim/COMMERCE-8305

     [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
     [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.portal.util                            MAJOR      17.0.0     17.0.0     18.0.0     VERSION INCREASE REQUIRED
     [exec]   >   class      com.liferay.portal.util.PropsValues
     [exec]     -   field      PORTLET_URL_GENERATE_BY_PATH_ENABLED
     [exec]       -   access     final
     [exec]       -   access     static
     [exec]       -   return     boolean
     [exec] [Baseline Warning] Bundle Version Change Recommended: 22.0.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-impl/portal-impl.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.impl/21.0.1/738b94219ff9ecbdac36ec1a817066bfb7086e42/com.liferay.portal.impl-21.0.1.jar

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #339596

Please fix semantic versioning on brianikim/COMMERCE-8305

     [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
     [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.portal.kernel.util                     MAJOR      23.0.0     23.0.0     24.0.0     VERSION INCREASE REQUIRED
     [exec]   >   interface  com.liferay.portal.kernel.util.PropsKeys
     [exec]     -   field      PORTLET_URL_GENERATE_BY_PATH_ENABLED
     [exec]       -   access     final
     [exec]       -   access     static
     [exec]       -   constant   portlet.url.generate.by.path.enabled
     [exec]       -   return     java.lang.String
     [exec] [Baseline Warning] Bundle Version Change Recommended: 34.0.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/33.0.0/a67dd6264c43c6276987fcefdfc7290fe126de7a/com.liferay.portal.kernel-33.0.0.jar

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
Job Results:
2 Tests Passed.
3 Tests Failed.
1. AXIS_VARIABLE=0 #448142

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

3295 Tests Passed.
5 Tests Failed.

AXIS_VARIABLE=5 #29565

com.liferay.headless.commerce.admin.channel.resource.v1_0.test.ChannelResourceTest.testDeleteChannelByExternalReferenceCode

java.lang.UnsupportedOperationException: This method needs to be implemented
  at com.liferay.headless.commerce.admin.channel.resource.v1_0.test.BaseChannelResourceTestCase.testDeleteChannelByExternalReferenceCode_addChannel(BaseChannelResourceTestCase.java:519)
  at com.liferay.headless.commerce.admin.channel.resource.v1_0.test.BaseChannelResourceTestCase.testDeleteChannelByExternalReferenceCode(BaseChannelResourceTestCase.java:498)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:498)
  at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
  at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
  at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.port...

com.liferay.headless.commerce.admin.channel.resource.v1_0.test.ChannelResourceTest.testGetChannelByExternalReferenceCode

java.lang.UnsupportedOperationException: This method needs to be implemented
  at com.liferay.headless.commerce.admin.channel.resource.v1_0.test.BaseChannelResourceTestCase.testGetChannelByExternalReferenceCode_addChannel(BaseChannelResourceTestCase.java:538)
  at com.liferay.headless.commerce.admin.channel.resource.v1_0.test.BaseChannelResourceTestCase.testGetChannelByExternalReferenceCode(BaseChannelResourceTestCase.java:526)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:498)
  at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
  at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
  at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.ker...

com.liferay.headless.commerce.admin.channel.resource.v1_0.test.ChannelResourceTest.testGraphQLGetChannelByExternalReferenceCode

java.lang.IllegalArgumentException: Expected starts with '{', but found 'n' in 'null'
  at com.liferay.headless.commerce.admin.channel.client.json.BaseJSONParser._assertStartsWithAndEndsWith(BaseJSONParser.java:259)
  at com.liferay.headless.commerce.admin.channel.client.json.BaseJSONParser.parseToDTO(BaseJSONParser.java:50)
  at com.liferay.headless.commerce.admin.channel.client.serdes.v1_0.ChannelSerDes.toDTO(ChannelSerDes.java:38)
  at com.liferay.headless.commerce.admin.channel.resource.v1_0.test.BaseChannelResourceTestCase.testGraphQLGetChannelByExternalReferenceCode(BaseChannelResourceTestCase.java:551)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:498)
  at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
  at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
  at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.t...

...

liferay-continuous-integration · 2022-02-02T02:08:18Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#1724

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-commerce#2191

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - brianikim > liferay-commerce - PR#2191 - 2022-02-01[15:54:15]

Testray Importer:publish-testray-report#5145

ivicac · 2022-02-02T12:51:30Z

ci:forward

liferay-continuous-integration · 2022-02-02T12:51:37Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2022-02-02T12:51:38Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2022-02-02T12:52:35Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2022-02-02T12:52:48Z

Pull request has been successfully forwarded to brianchandotcom#112962
Console

Luizcarlosqueiroz and others added 30 commits January 31, 2022 22:59

LPS-145815 Refactor three content performance tests

93e3af4

COMMERCE-7829 commerce-product-api autogenerated code (gw buildService)

c60d0fb

LPS-144028 Test Autom. Content page metrics

0d1ce33

LPS-144029 Test Autom: Widget page metrics

6d09515

LPS-145815 Refactor three content performance tests

1453045

LRCI-2605 Update com.liferay.jenkins.results.parser to 1.0.985

23ece3b

LRCI-2605 Update com.liferay.jenkins.results.parser to 1.0.985 refere…

d9b63e2

…nces

LRCI-2605 Use the local git working directory if available to generat…

4fcc68a

…e job reports

LRCI-2605 #sfme

883f8c7

LRCI-2766 Do not read the portal master properties when determining j…

1c1428c

…ob properties

LRCI-2766 prep next

a33e646

LPS-145436 If there is more than one model to be exported, the title …

8356dce

…of the page is export-for-translation

LPS-145436 If there is more than one different class pks (model) the …

f618937

…name of the zip file it's the name of the classname

LPS-145436 we only need one time of each class to generate the files

6320fbd

LPS-145436 change file name of the multiple import export on Poshi Test

81d8601

LPS-145436 in the case of multiple segments experience ids, do not co…

8919704

…unt as different models so extract the method to know if are multiple or not this must change when exporting several models and several experiences.

LPS-137413 Remove tests duplicated in two testcase files

e04ef86

LPS-131936 Modify CheckForMoreCategories test after UI changes

fa0434c

LPS-146261 Ignore files generated by poshi test execution

bbb921d

COMMERCE-8104 - batch-planner-service - introduce new exception

b118b3e

COMMERCE-8104 - batch-planner-service - buildService

3e10630

COMMERCE-8104 - batch-planner - update with changes

8b77ae0

LPS-146354 Add missing step on testcase

1ebe52b

LPS-144395

be62db4

The default log level reports *a lot* of noise on a vanilla system that's not connected to AC - e.g. one message "DEBUG [BaseAnalyticsClientImpl:49] Analytics configuration tracker not active" _per http request_.

LPS-146012 Fix subscriptions navbar to show only products with subscr…

34829f8

…iptions

LPS-146012 Fix subscriptions groups filter and subscriptions cards

5eae2df

LPS-142868 Fix warnings related to absence of node id (since sidebar …

5233d18

…nodes do not need to define ids)

LPS-142868 Avoid warnings related to attributes names passed to DOM e…

855e3f1

…lements

LPS-142868 Fix PropTypes

f06ba60

Catarine Aguiar and others added 7 commits February 1, 2022 14:08

LPS-145910 fix CreateTeamExtranetVirtualInstanceByAPI testcase

3133ecd

LPS-146379 only add to available actions the export translation if ca…

e78269a

…n be shown

LPS-146379 use the methods from layoutsAdminDisplayContext to delete …

da8967e

…repeated code

LPS-144161 Include search bar in main navbar fragment

9f2a5e5

LPS-144161 Configure search bar in master page

bd07fe0

LPS-144161 Create and configure search page

b9b0dee

COMMERCE-8305 Include commerceAccountGroups if they exist.

1f598fb

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - pending labels Feb 1, 2022

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 2, 2022

liferay-continuous-integration mentioned this pull request Feb 2, 2022

COMMERCE-8305 brianchandotcom/liferay-portal#112962

Closed

liferay-continuous-integration closed this Feb 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

COMMERCE-8305 #2191

COMMERCE-8305 #2191

brianikim commented Feb 1, 2022 •

edited

Loading

liferay-continuous-integration commented Feb 1, 2022

brianikim commented Feb 1, 2022

brianikim commented Feb 1, 2022

liferay-continuous-integration commented Feb 1, 2022

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 2, 2022

liferay-continuous-integration commented Feb 2, 2022

Base Branch:

Upstream Comparison:

5 Failed Jobs:

6 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/rest-builder-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Feb 2, 2022

ivicac commented Feb 2, 2022

liferay-continuous-integration commented Feb 2, 2022

liferay-continuous-integration commented Feb 2, 2022

liferay-continuous-integration commented Feb 2, 2022

liferay-continuous-integration commented Feb 2, 2022

COMMERCE-8305 #2191

COMMERCE-8305 #2191

Conversation

brianikim commented Feb 1, 2022 • edited Loading

liferay-continuous-integration commented Feb 1, 2022

brianikim commented Feb 1, 2022

brianikim commented Feb 1, 2022

liferay-continuous-integration commented Feb 1, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 2, 2022

liferay-continuous-integration commented Feb 2, 2022

✔️ ci:test:stable - 21 out of 26 jobs passed

✔️ ci:test:relevant - 22 out of 27 jobs passed in 2 hours 9 minutes

Base Branch:

Upstream Comparison:

5 Failed Jobs:

6 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/rest-builder-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Feb 2, 2022

ivicac commented Feb 2, 2022

liferay-continuous-integration commented Feb 2, 2022

liferay-continuous-integration commented Feb 2, 2022

liferay-continuous-integration commented Feb 2, 2022

liferay-continuous-integration commented Feb 2, 2022

brianikim commented Feb 1, 2022 •

edited

Loading