Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMMERCE-10151 New API to get a list of Available Low Stock Actions #3389

Closed
wants to merge 4 commits into from
Closed

COMMERCE-10151 New API to get a list of Available Low Stock Actions #3389

wants to merge 4 commits into from

Conversation

dsitu
Copy link
Collaborator

@dsitu dsitu commented Feb 8, 2023

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@dsitu
Copy link
Collaborator Author

dsitu commented Feb 8, 2023

ci:test:sf

@dsitu
Copy link
Collaborator Author

dsitu commented Feb 8, 2023

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0c4b8ffd1ce971d6402347f0aa5b8a1b217f31b8

Sender Branch:

Branch Name: COMMERCE-10151
Branch GIT ID: 49e2205a67c242ae6ac03f15e6b241c37c961755

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 27 out of 28 jobs passed

❌ ci:test:relevant - 109 out of 117 jobs passed in 2 hours 27 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1257401_6194

Base Branch:

Branch Name: master
Branch GIT ID: 0c4b8ffd1ce971d6402347f0aa5b8a1b217f31b8

Upstream Comparison:

Branch GIT ID: f2f8a315890e04d4cfee8c20da08788d37d169b9
Jenkins Build URL: EE Development Acceptance (master) - 4267 - 2023-02-08[12:36:24]

ci:test:stable - 27 out of 28 jobs PASSED

1 Failed Jobs:

27 Successful Jobs:
    ci:test:relevant - 109 out of 117 jobs PASSED

    8 Failed Jobs:

    109 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      1. rest-builder-jdk8/0/0

        Please fix semantic versioning on dsitu/COMMERCE-10151

             [exec]       +   access     final
     [exec]       +   access     static
     [exec]       +   constant   TERMS_OF_USE
     [exec]       +   return     java.lang.String
     [exec]     +   method     <init>()
     [exec]       +   return     void
     [exec]     +   method     clone()
     [exec]       +   access     protected
     [exec]       +   return     java.lang.Object
     [exec]     +   method     equals(java.lang.Object)
     [exec]       +   return     boolean
     [exec]     +   method     finalize()
     [exec]       +   access     protected
     [exec]       +   return     void
     [exec]     +   method     hashCode()
     [exec]       +   return     int
     [exec]     +   method     toString()
     [exec]       +   return     java.lang.String
     [exec]   -   class      com.liferay.layout.utility.page.kernel.constants.LayoutUtilityPageEntryTypesConstants
     [exec]     -   field      LAYOUT
     [exec]       -   access     final
     [exec]       -   access     static
     [exec]       -   constant   LAYOUT
     [exec]       -   return     java.lang.String
     [exec]     -   field      STATUS
     [exec]       -   access     final
     [exec]       -   access     static
     [exec]       -   constant   STATUS
     [exec]       -   return     java.lang.String
     [exec]     -   field      TERMS_OF_USE
     [exec]       -   access     final
     [exec]       -   access     static
     [exec]       -   constant   TERMS_OF_USE
     [exec]       -   return     java.lang.String
     [exec]     -   method     <init>()
     [exec]       -   return     void
     [exec]     -   method     clone()
     [exec]       -   access     protected
     [exec]       -   return     java.lang.Object
     [exec]     -   method     equals(java.lang.Object)
     [exec]       -   return     boolean
     [exec]     -   method     finalize()
     [exec]       -   access     protected
     [exec]       -   return     void
     [exec]     -   method     hashCode()
     [exec]       -   return     int
     [exec]     -   method     toString()
     [exec]       -   return     java.lang.String
     [exec]   -   version    1.0.0
     [exec]   +   version    1.1.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/96.0.1/87d20d3daea0984b5ad25b45023aaa1ee46c99ec/com.liferay.portal.kernel-96.0.1.jar

      2. semantic-versioning-jdk8/0/0

        Please fix semantic versioning on dsitu/COMMERCE-10151

             [exec]       +   access     final
     [exec]       +   access     static
     [exec]       +   constant   TERMS_OF_USE
     [exec]       +   return     java.lang.String
     [exec]     +   method     <init>()
     [exec]       +   return     void
     [exec]     +   method     clone()
     [exec]       +   access     protected
     [exec]       +   return     java.lang.Object
     [exec]     +   method     equals(java.lang.Object)
     [exec]       +   return     boolean
     [exec]     +   method     finalize()
     [exec]       +   access     protected
     [exec]       +   return     void
     [exec]     +   method     hashCode()
     [exec]       +   return     int
     [exec]     +   method     toString()
     [exec]       +   return     java.lang.String
     [exec]   -   class      com.liferay.layout.utility.page.kernel.constants.LayoutUtilityPageEntryTypesConstants
     [exec]     -   field      LAYOUT
     [exec]       -   access     final
     [exec]       -   access     static
     [exec]       -   constant   LAYOUT
     [exec]       -   return     java.lang.String
     [exec]     -   field      STATUS
     [exec]       -   access     final
     [exec]       -   access     static
     [exec]       -   constant   STATUS
     [exec]       -   return     java.lang.String
     [exec]     -   field      TERMS_OF_USE
     [exec]       -   access     final
     [exec]       -   access     static
     [exec]       -   constant   TERMS_OF_USE
     [exec]       -   return     java.lang.String
     [exec]     -   method     <init>()
     [exec]       -   return     void
     [exec]     -   method     clone()
     [exec]       -   access     protected
     [exec]       -   return     java.lang.Object
     [exec]     -   method     equals(java.lang.Object)
     [exec]       -   return     boolean
     [exec]     -   method     finalize()
     [exec]       -   access     protected
     [exec]       -   return     void
     [exec]     -   method     hashCode()
     [exec]       -   return     int
     [exec]     -   method     toString()
     [exec]       -   return     java.lang.String
     [exec]   -   version    1.0.0
     [exec]   +   version    1.1.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/96.0.1/87d20d3daea0984b5ad25b45023aaa1ee46c99ec/com.liferay.portal.kernel-96.0.1.jar

      Failures in common with acceptance upstream results at f2f8a31:
      4. ...

      @liferay-continuous-integration
      Copy link
      Collaborator

      @dsitu
      Copy link
      Collaborator Author

      dsitu commented Feb 9, 2023

      ci:test:relevant

      @liferay-continuous-integration
      Copy link
      Collaborator

      ❌ ci:test:stable - 27 out of 28 jobs passed

      ❌ ci:test:relevant - 108 out of 117 jobs passed in 1 hour 33 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: 0c4b8ffd1ce971d6402347f0aa5b8a1b217f31b8

      Upstream Comparison:

      Branch GIT ID: 0c4b8ffd1ce971d6402347f0aa5b8a1b217f31b8
      Jenkins Build URL: EE Development Acceptance (master) - 4268 - 2023-02-08[15:10:03]

      ci:test:stable - 27 out of 28 jobs PASSED

      1 Failed Jobs:

      27 Successful Jobs:
        ci:test:relevant - 108 out of 117 jobs PASSED

        9 Failed Jobs:

        108 Successful Jobs:
          For more details click here.

          Failures unique to this pull:

          1. modules-integration-mysql57-jdk8/0/8
            [beanshell] Total duration: 233
[beanshell] Remote execution completed in 233ms.
[beanshell] Remote execution starting with 1 threads.
[beanshell] Executing commands: ssh -o NumberOfPasswordPrompts=0 root@test-1-34 'mkdir -p "/mnt/mfs-hdd1-10.0.10/jenkins/testray-results/production/logs/2023-02/test-1-26/test-portal-acceptance-pullrequest(master)/7547/modules-integration-mysql57-jdk8/0/8"'
[beanshell] Average thread duration: 233ms
[beanshell] Busy slaves:0
[beanshell] Finished slaves:1
[beanshell] Target slaves:1
[beanshell] Total duration: 234
[beanshell] Remote execution completed in 235ms.
[beanshell] Executing commands: rsync -aqz --chmod=go=rx "/opt/dev/projects/github/liferay-jenkins-ee/testray/prepared_rsync_logs"/* "test-1-34::testray-results/production/logs/"
[beanshell] Uploaded https://testray.liferay.com/reports/production/logs/2023-02/test-1-26/test-portal-acceptance-pullrequest(master)/7547/modules-integration-mysql57-jdk8/0/8/jenkins-console.txt.gz
[beanshell] INFO: Using GOOGLE_APPLICATION_CREDENTIALS=/root/.gcloud/ci-testray.json
[beanshell] Unable to delete because file does not exist /opt/dev/projects/github/liferay-jenkins-ee/testray/prepared_s3_logs
[beanshell] Created S3 Object https://storage.cloud.google.com/testray-results/2023-02/test-1-26/test-portal-acceptance-pullrequest(master)/7547/modules-integration-mysql57-jdk8/0/8/jenkins-console.txt.gz in 270 ms
[stopwatch] [run.current.job: 24.374 sec]
[beanshell] Created cache file in /tmp/jenkins-cached-files/1699618461.txt

            BUILD FAILED
            
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:14925: The following error occurred while executing this line:
            
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:15793: Sourced file: inline evaluation of:                import com.liferay.jenkins.results.parser.BuildDatabase;         import com . . . '' : TargetError : at Line: 168 : in file: inline evaluation of:                import com.liferay.jenkins.results.parser.BuildDatabase;         import com . . . '' : throw exception ;
            

            Target exception: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.lang.RuntimeException: Unable to checkout 7.0.x-temp-1675910714111
            
BUG: unpack-trees.c:777: pos 41566 doesn't point to the first entry of modules/dxp/apps/osb/osb-asah/osb-asah-backend/src/testIntegration/java/com/liferay/osb/asah/backend/servlet/ in index
            
/bin/sh: line 1: 3543037 Aborted                 git checkout -f 7.0.x-temp-1675910714111
            1. com.liferay.jenkins.Jenkins
            2. com.liferay.commerce.tax.service.persistence.test.CommerceTaxMethodPersistenceTest.testCreate - UNTESTED
            3. com.liferay.commerce.tax.service.persistence.test.CommerceTaxMethodPersistenceTest.testRemove - UNTESTED
            4. ...
          2. rest-builder-jdk8/0/0

            Please fix semantic versioning on dsitu/COMMERCE-10151

                 [exec]       +   access     final
            
[exec]       +   access     static
            
[exec]       +   constant   TERMS_OF_USE
            
[exec]       +   return     java.lang.String
            
[exec]     +   method     <init>()
            
[exec]       +   return     void
            
[exec]     +   method     clone()
            
[exec]       +   access     protected
            
[exec]       +   return     java.lang.Object
            
[exec]     +   method     equals(java.lang.Object)
            
[exec]       +   return     boolean
            
[exec]     +   method     finalize()
            
[exec]       +   access     protected
            
[exec]       +   return     void
            
[exec]     +   method     hashCode()
            
[exec]       +   return     int
            
[exec]     +   method     toString()
            
[exec]       +   return     java.lang.String
            
[exec]   -   class      com.liferay.layout.utility.page.kernel.constants.LayoutUtilityPageEntryTypesConstants
            
[exec]     -   field      LAYOUT
            
[exec]       -   access     final
            
[exec]       -   access     static
            
[exec]       -   constant   LAYOUT
            
[exec]       -   return     java.lang.String
            
[exec]     -   field      STATUS
            
[exec]       -   access     final
            
[exec]       -   access     static
            
[exec]       -   constant   STATUS
            
[exec]       -   return     java.lang.String
            
[exec]     -   field      TERMS_OF_USE
            
[exec]       -   access     final
            
[exec]       -   access     static
            
[exec]       -   constant   TERMS_OF_USE
            
[exec]       -   return     java.lang.String
            
[exec]     -   method     <init>()
            
[exec]       -   return     void
            
[exec]     -   method     clone()
            
[exec]       -   access     protected
            
[exec]       -   return     java.lang.Object
            
[exec]     -   method     equals(java.lang.Object)
            
[exec]       -   return     boolean
            
[exec]     -   method     finalize()
            
[exec]       -   access     protected
            
[exec]       -   return     void
            
[exec]     -   method     hashCode()
            
[exec]       -   return     int
            
[exec]     -   method     toString()
            
[exec]       -   return     java.lang.String
            
[exec]   -   version    1.0.0
            
[exec]   +   version    1.1.0
            
[exec] [Baseline Report] Mode: diff (persisted)
            
[exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/96.0.1/87d20d3daea0984b5ad25b45023aaa1ee46c99ec/com.liferay.portal.kernel-96.0.1.jar

          3. semantic-versioning-jdk8/0/0

            Please fix semantic versioning on dsitu/COMMERCE-10151

                 [exec]       +   access     final
            
[exec]       +   access     static
            
[exec]       +   constant   TERMS_OF_USE
            
[exec]       +   return     java.lang.String
            
[exec]     +   method     <init>()
            
[exec]       +   return     void
            
[exec]     +   method     clone()
            
[exec]       +   access     protected
            
[exec]       +   return     java.lang.Object
            
[exec]     +   method     equals(java.lang.Object)
            
[exec]       +   return     boolean
            
[exec]     +   method     finalize()
            
[exec]       +   access     protected
            
[exec]       +   return     void
            
[exec]     +   method     hashCode()
            
[exec]       +   return     int
            
[exec]     +   method     toString()
            
[exec]       +   return     java.lang.String
            
[exec]   -   class      com.liferay.layout.utility.page.kernel.constants.LayoutUtilityPageEntryTypesConstants
            
[exec]     -   field      LAYOUT
            
[exec]       -   access     final
            
[exec]       -   access     static
            
[exec]       -   constant   LAYOUT
            
[exec]       -   return     java.lang.String
            
[exec]     -   field      STATUS
            
[exec]       -   access     final
            
[exec]       -   access     static
            
[exec]       -   constant   STATUS
            
[exec]       -   return     java.lang.String
            
[exec]     -   field      TERMS_OF_USE
            
[exec]       -   access     final
            
[exec]       -   access     static
            
[exec]       -   constant   TERMS_OF_USE
            
[exec]       -   return     java.lang.String
            
[exec]     -   method     <init>()
            
[exec]       -   return     void
            
[exec]     -   method     clone()
            
[exec]       -   access     protected
            
[exec]       -   return     java.lang.Object
            
[exec]     -   method     equals(java.lang.Object)
            
[exec]       -   return     boolean
            
[exec]     -   method     finalize()
            
[exec]       -   access     protected
            
[exec]       -   return     void
            
[exec]     -   method     hashCode()
            
[exec]       -   return     int
            
[exec]     -   method     toString()
            
[exec]       -   return     java.lang.String
            
[exec]   -   version    1.0.0
            
[exec]   +   version    1.1.0
            
[exec] [Baseline Report] Mode: diff (persisted)
            
[exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/96.0.1/87d20d3daea0984b5ad25b45023aaa1ee46c99ec/com.liferay.portal.kernel-96.0.1.jar

          Failures in common with acceptance upstream results at 0c4b8ff:
          3. ...

          @liferay-continuous-integration
          Copy link
          Collaborator

          luca-pellizzon
          luca-pellizzon requested changes Feb 9, 2023
          View reviewed changes
          Copy link
          Collaborator

          @luca-pellizzon luca-pellizzon left a comment

          Choose a reason for hiding this comment

          The reason will be displayed to describe this comment to others. Learn more.

          Since we are in admin APIs I think we should send a map of
          <locale, value> for the label

          @dsitu
          Copy link
          Collaborator Author

          dsitu commented Feb 10, 2023

          ci:test:sf

          @dsitu
          Copy link
          Collaborator Author

          dsitu commented Feb 10, 2023

          ci:test:relevant

          @liferay-continuous-integration
          Copy link
          Collaborator

          ✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

          Click here for more details.

          Base Branch:

          Branch Name: master
          Branch GIT ID: d48b4c356269b67c7c07fc44abf49cc4377b51b4

          Sender Branch:

          Branch Name: COMMERCE-10151
          Branch GIT ID: a82551943fc61f9349a553d9b51f6be34fc2ec68

          1 out of 1jobs PASSED
          1 Successful Jobs:
          For more details click here.

          @liferay-continuous-integration
          Copy link
          Collaborator

          @liferay-continuous-integration
          Copy link
          Collaborator

          ✔️ ci:test:stable - 28 out of 28 jobs passed

          ✔️ ci:test:relevant - 64 out of 112 jobs passed in 2 hours 32 minutes

          Click here for more details.

          Base Branch:

          Branch Name: master
          Branch GIT ID: d48b4c356269b67c7c07fc44abf49cc4377b51b4

          Upstream Comparison:

          Branch GIT ID: d48b4c356269b67c7c07fc44abf49cc4377b51b4
          Jenkins Build URL: EE Development Acceptance (master) - 4272 - 2023-02-10[05:06:48]

          ci:test:stable - 28 out of 28 jobs PASSED
          28 Successful Jobs:
            ci:test:relevant - 63 out of 112 jobs PASSED

            49 Failed Jobs:

            63 Successful Jobs:
              For more details click here.

              This pull contains no unique failures.

              Failures in common with acceptance upstream results at d48b4c3:
              6. ...

              @liferay-continuous-integration
              Copy link
              Collaborator

              @dsitu
              Copy link
              Collaborator Author

              dsitu commented Feb 10, 2023

              ci:forward

              @liferay-continuous-integration
              Copy link
              Collaborator

              CI is automatically triggering the following test suites:

              •     ci:test:relevant
              •     ci:test:sf

              The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

              •     ci:test:relevant
              •     ci:test:sf
              •     ci:test:stable

              @liferay-continuous-integration
              Copy link
              Collaborator

              Skipping previously passed test suites:
              ci:test:relevant
              ci:test:sf

              @liferay-continuous-integration
              Copy link
              Collaborator

              All required test suite(s) passed.
              Forwarding pull request to brianchandotcom.
              Console

              Closed
              @liferay-continuous-integration
              Copy link
              Collaborator

              Pull request has been successfully forwarded to brianchandotcom#130115
              Console

              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Reviewers

              @luca-pellizzon luca-pellizzon luca-pellizzon approved these changes

              Assignees
              No one assigned
              Labels
              ci:test:relevant - success ci:test:sf - success ci:test:stable - success
              Projects
              None yet
              Milestone
              No milestone
              Development

              Successfully merging this pull request may close these issues.
              4 participants
              @dsitu @liferay-continuous-integration @luca-pellizzon @pietrobocale