Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-133741 "There was an error when loading the "rich_text" field." display after translating to both ES and JP #504

Conversation

boton
Copy link

@boton boton commented Jun 7, 2021

https://issues.liferay.com/browse/LPS-133741

Sometimes the CKEditor instance isn't ready and we try to call the resetUndo.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5bb2737a89000b413c1e0ee1e39ed203227728cf

Sender Branch:

Branch Name: LPS-133741-bug-translation-WC-rich-text-error
Branch GIT ID: b4c68903dcfcb6d26813e789f9319d6a2b43b06a

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

❌ ci:test:relevant - 22 out of 26 jobs passed in 1 hour 49 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1257401_869

Base Branch:

Branch Name: master
Branch GIT ID: 5bb2737a89000b413c1e0ee1e39ed203227728cf

Upstream Comparison:

Branch GIT ID: 0d09e3d35f1b72b7d38f8662c80e0630f815f513
Jenkins Build URL: Acceptance Upstream DXP (master) #1954

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 22 out of 26 jobs PASSED
22 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #436347

      Please fix semantic versioning on boton/LPS-133741-bug-translation-WC-rich-text-error

           [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
           [exec] = ================================================== ========== ========== ========== ========== ==========
           [exec] * com.liferay.document.library.kernel.util           MAJOR      2.3.0      2.4.0      3.0.0      VERSION INCREASE REQUIRED
           [exec] 	>   class      com.liferay.document.library.kernel.util.AudioProcessorUtil
           [exec] 		-   method     isEnabled()
           [exec] 			-   access     static
           [exec] 			-   return     boolean
           [exec] 	>   interface  com.liferay.document.library.kernel.util.AudioProcessor
           [exec] 		-   method     isEnabled()
           [exec] 			-   return     boolean
           [exec] 		-   annotated  org.osgi.annotation.versioning.ProviderType
           [exec] 	+   version    2.3.0
           [exec] 	-   version    2.4.0
           [exec] [Baseline Warning] Bundle Version Change Recommended: 12.0.0
           [exec] [Baseline Report] Mode: diff (persisted)
           [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/11.5.0/fe81c6cdb33027f8c1bf896cadfbf68706112496/com.liferay.portal.kernel-11.5.0.jar


Failures in common with acceptance upstream results at 0d09e3d:

@liferay-continuous-integration
Copy link
Collaborator

@marcelabc marcelabc added the Review Pending The PR needs to be reviewed before forwarding to Brian label Jun 7, 2021
@guilhermedcamacho
Copy link

Hey @boton ,

Could you fix semantic versioning problem reported in relevant test?

Thanks!

@guilhermedcamacho guilhermedcamacho added the Changes Required Changes to the original code are required before forwarding PR label Jun 8, 2021
@boton boton force-pushed the LPS-133741-bug-translation-WC-rich-text-error branch from b4c6890 to 3e5b874 Compare June 8, 2021 08:27
@boton
Copy link
Author

boton commented Jun 8, 2021

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 9 out of 10 jobs passed

❌ ci:test:relevant - 22 out of 26 jobs passed in 1 hour 46 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1257401_924

Base Branch:

Branch Name: master
Branch GIT ID: d0f6b0ff617f356c63894822b27b21f09a39fdb3

Upstream Comparison:

Branch GIT ID: 863d422c186d0b08eac88867c9b17fa060214dda
Jenkins Build URL: Acceptance Upstream DXP (master) #1959

ci:test:stable - 9 out of 10 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 22 out of 26 jobs PASSED
22 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #464154
           [exec] * Where:
           [exec] Build file '/opt/dev/projects/github/liferay-portal/modules/util/ruby-gems/build.gradle' line: 28
           [exec] 
           [exec] * What went wrong:
           [exec] Execution failed for task ':util:ruby-gems:downloadGems'.
           [exec] > Process 'command '/opt/java/jdk1.8.0_121-x64/bin/java'' finished with non-zero exit value 2
           [exec] 
           [exec] * Try:
           [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':util:ruby-gems:downloadGems'.
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)
           [exec] 	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)
           [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
           [exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
           [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
           [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
           [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
           [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
           [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:409)

Failures in common with acceptance upstream results at 863d422:

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 24 out of 26 jobs passed in 1 hour 50 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d0f6b0ff617f356c63894822b27b21f09a39fdb3

Upstream Comparison:

Branch GIT ID: d0f6b0ff617f356c63894822b27b21f09a39fdb3
Jenkins Build URL: Acceptance Upstream DXP (master) #1961

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 23 out of 26 jobs PASSED
23 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at d0f6b0f:

@liferay-continuous-integration
Copy link
Collaborator

@guilhermedcamacho guilhermedcamacho removed the Changes Required Changes to the original code are required before forwarding PR label Jun 8, 2021
@guilhermedcamacho
Copy link

Just started reviewing :)

@guilhermedcamacho guilhermedcamacho self-requested a review June 8, 2021 15:09
@guilhermedcamacho guilhermedcamacho added the In review The PR is being reviewed by someone from the team label Jun 8, 2021
@guilhermedcamacho guilhermedcamacho added Good to go This PR can be forwarded and removed Review Pending The PR needs to be reviewed before forwarding to Brian In review The PR is being reviewed by someone from the team labels Jun 8, 2021
@guilhermedcamacho
Copy link

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 77cfec9f049f6d97960f2d3e860bac937136634c

Sender Branch:

Branch Name: LPS-133741-bug-translation-WC-rich-text-error
Branch GIT ID: 3e5b874f260daa18eed74e642d9f8b8a4f62ee07

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#102922
Console

@liferay-continuous-integration
Copy link
Collaborator

@boton boton deleted the LPS-133741-bug-translation-WC-rich-text-error branch January 26, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants