Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-111531 Edit action must be available only for the content pages #116

Closed
wants to merge 8 commits into from
Closed

LPS-111531 Edit action must be available only for the content pages #116

wants to merge 8 commits into from

Conversation

sandrodw3
Copy link
Collaborator

No description provided.

victorg1991 and others added 8 commits April 6, 2020 10:13
@victorg1991
LPS-111523 Only add href is the action is a link if we have handler o…
0b93c51 
…r the action is delete use a button
@victorg1991
LPS-111523 For discarding a conversion the draft layout have to be re…
eb4679e 
…moved not the published layout
@victorg1991
LPS-111523 Use the namespace to build the id, otherwise the add butto…
72c3451 
…n doesn't close the modal and reload the page
@victorg1991 @sandrodw3
LPS-111050 Order dropdown options by importance not alphabetically
300a136
@sandrodw3
LPS-111416 Check if position is integer, otherwise position 0 is not …
189bced 
…considered
@victorg1991 @sandrodw3
LPS-111535 Use a button for delete too, and navigate to the action UR…
80b91ac 
…L after the confirm
@pavel-savinov @sandrodw3
LPS-111536 Use key to distinguish layout column items because private…
e9109b7 
… and public pages have them same parent layout ID
@pavel-savinov @sandrodw3
LPS-111531 Edit action must be available only for the content pages
3f904c2
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@sandrodw3
Copy link
Collaborator Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 13 seconds 406 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fd4417fd2f038581a04c16ea471a10d378d070eb

Sender Branch:

Branch Name: miller-columns-bugs
Branch GIT ID: 3f904c25fdd81b495ea3258c302e06439a734fc7

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 16 out of 16 jobs passed

✔️ ci:test:relevant - 37 out of 37 jobs passed in 1 hour 9 minutes 14 seconds 488 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: dedeb279e3dfed0f1d0074682df08b919ff4d5f9

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: f449d2b173145eac4a8dbaedde4c9ffc84086a5a

ci:test:stable - 16 out of 16 jobs PASSED
16 Successful Jobs:
ci:test:relevant - 37 out of 37 jobs PASSED
37 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration liferay-continuous-integration mentioned this pull request Apr 6, 2020
Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#87288

@sandrodw3 sandrodw3 deleted the miller-columns-bugs branch April 24, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandrodw3 @liferay-continuous-integration @victorg1991 @pavel-savinov