Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-113703 Clickable elements from variants are not marked as target for AB Testing by Click Goal #1749

Closed
wants to merge 3 commits into from

Conversation

darquesdev
Copy link

@darquesdev darquesdev commented Aug 3, 2020

Motivation

This regresion LPS-113703 Clickable elements from variants are not marked as target for AB Testing by Click Goal
was caused by LPS-110227 Category Navigation portlet is not shown for different experience segments since we decided to recreate the namespace every time a FragmentEntryLink is created. Due to this when creating a new experience the html id associated to a fragment entry link changes since It's the namespace is used to generate it.

Proposed solution

After a conversation with @pavel-savinov and @jkappler we decided to reuse the unused "originalFragmentEntryLinkId" column of the FragmentEntryLink table to keep track of the FragmentEntryLink associated with the experience of which a copy is being created. In this way, by retrieving the namespace to generate the html id of a fragment entry link we can retrieve the namespace of the original fragment entry link.

In order to validate the solution, we've executed an upgrade process from 7.1.3.ga4 to master and the behaviour was the expected: the originalFragmentEntryLinkId props were set to 0.

How to test it DXP

  • Requirement: AC-DXP synced.
  • Create a Content Page with a button
  • Create an AB test by Click goal and set the button as clickable element
  • The button is marked as "Target" only in Control version.

How to test it CE

  • Create a Content Page with a button
  • Create an experience from the default one
  • The html id of the button must be the same in both experiences

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@darquesdev
Copy link
Author

ci:test:sf

@darquesdev
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3294c1b9117f72b6f13a53ca1e1ff944be28397c

Sender Branch:

Branch Name: LPS-113703
Branch GIT ID: 3d9f30e26e63474d53f81723ff69720c5b92ca14

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 78 out of 78 jobs passed in 1 hour 51 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cebfb51d0092cda2ea4cd67dd54aa54a59e256f6

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: a2989be147835c295b16fd5637140c9d4cd9de61

ci:test:stable - 21 out of 21 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 78 out of 78 jobs PASSED
78 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@darquesdev
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 21 out of 21 jobs passed

❌ ci:test:relevant - 76 out of 78 jobs passed in 1 hour 50 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 80d7bbaa23c8ee6aecfab2953b64447e94103366

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: db98256ba2c028c92a356e7a9f0ba6e73335294f

ci:test:stable - 21 out of 21 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 76 out of 78 jobs PASSED
76 Successful Jobs:
For more details click here.

Failures unique to this pull:

For upstream results, click here.

… case it exists and it's related to the page
@darquesdev
Copy link
Author

ci:test:relevant

@darquesdev darquesdev marked this pull request as ready for review August 4, 2020 11:00
@darquesdev darquesdev changed the title LPS-113703 Clickable elements from variants are not marked as target for AB Testing by Click Goal [WIP] LPS-113703 Clickable elements from variants are not marked as target for AB Testing by Click Goal Aug 4, 2020
@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 78 out of 78 jobs passed in 2 hours 53 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 80d7bbaa23c8ee6aecfab2953b64447e94103366

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: db98256ba2c028c92a356e7a9f0ba6e73335294f

ci:test:stable - 21 out of 21 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 78 out of 78 jobs PASSED
78 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@pavel-savinov
Copy link

Just started reviewing :)

@pavel-savinov
Copy link

ci:close

@pavel-savinov
Copy link

Sent here #1903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants