-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-113703 Clickable elements from variants are not marked as target for AB Testing by Click Goal #1749
Conversation
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
ci:test:sf |
ci:test:relevant |
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-113703 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#4365 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#3373 |
…entEntryLink we made the copy
ci:test:relevant |
… case it exists and it's related to the page
ci:test:relevant |
Jenkins Build:test-portal-acceptance-pullrequest(master)#7996 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#6326 |
Just started reviewing :) |
ci:close |
Sent here #1903 |
Motivation
This regresion LPS-113703 Clickable elements from variants are not marked as target for AB Testing by Click Goal
was caused by LPS-110227 Category Navigation portlet is not shown for different experience segments since we decided to recreate the namespace every time a FragmentEntryLink is created. Due to this when creating a new experience the html id associated to a fragment entry link changes since It's the namespace is used to generate it.
Proposed solution
After a conversation with @pavel-savinov and @jkappler we decided to reuse the unused "originalFragmentEntryLinkId" column of the
FragmentEntryLink
table to keep track of theFragmentEntryLink
associated with the experience of which a copy is being created. In this way, by retrieving the namespace to generate the html id of a fragment entry link we can retrieve the namespace of the original fragment entry link.In order to validate the solution, we've executed an upgrade process from 7.1.3.ga4 to master and the behaviour was the expected: the
originalFragmentEntryLinkId
props were set to 0.How to test it DXP
How to test it CE