Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-120357 Ensure destroyedCallback is being called once when creating item selection modals #2178

Closed
wants to merge 2 commits into from
Closed

LPS-120357 Ensure destroyedCallback is being called once when creating item selection modals #2178

wants to merge 2 commits into from

Conversation

victorg1991
Copy link
Collaborator

No description provided.

@victorg1991 victorg1991 mentioned this pull request Sep 3, 2020
Closed
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@victorg1991
Copy link
Collaborator Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b91d5cb090f3a038fb907e77f5ab68c2ab4eebdf

Sender Branch:

Branch Name: pr-320
Branch GIT ID: 3816ef4d437bc8c7ce01f22de3ea4a03f2969dc9

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#4537
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#2178
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - victorg1991 > liferay-echo - PR#2178 - 2020-09-03[07:36:17]
Spira Jenkins Build:publish-spira-report#4016

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 81 out of 81 jobs passed in 1 hour 52 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b91d5cb090f3a038fb907e77f5ab68c2ab4eebdf

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: df1236053a2097d63e354600635a9bf8b08e5a99

ci:test:stable - 21 out of 21 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 81 out of 81 jobs PASSED
81 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration liferay-continuous-integration mentioned this pull request Sep 3, 2020
Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#93748

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#7128
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#2178
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - victorg1991 > liferay-echo - PR#2178 - 2020-09-03[07:38:42]
Spira Jenkins Build:publish-spira-report#4030

@victorg1991 victorg1991 deleted the pr-320 branch September 7, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorg1991 @liferay-continuous-integration @p2kmgcl