Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-120509 SF #2230

Closed
wants to merge 4 commits into from
Closed

LPS-120509 SF #2230

wants to merge 4 commits into from

Conversation

pavel-savinov
Copy link

No description provided.

jkappler and others added 3 commits September 8, 2020 08:42
@jkappler
LPS-120509 At some point in 7.3, the property was also called contain…
b4e7a01 
…erType, so adapt accordingly. The property has precedence over type
@jkappler
LPS-120509 We cannot reference the class in API module here since it …
38f13cb 
…changes over time and it might break future upgrade processes. So copy over the class with the right converter structure and preserve it
@pavel-savinov
LPS-120509 SF
b686050
@pavel-savinov pavel-savinov mentioned this pull request Sep 8, 2020
Closed
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@pavel-savinov
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0cef9ce5387d2f526fd258f294e93ffd924a1254

Sender Branch:

Branch Name: pr-629
Branch GIT ID: b68605018ccefe29c16b710ab63c8fdeb7c066a8

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#2398
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#2230
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - pavel-savinov > liferay-echo - PR#2230 - 2020-09-08[00:28:55]
Spira Jenkins Build:publish-spira-report#7387

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 21 out of 21 jobs passed

❌ ci:test:relevant - 78 out of 80 jobs passed in 1 hour 56 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c379f2a0f2204cf2ded7688e367ef69d72919485

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: df1236053a2097d63e354600635a9bf8b08e5a99

ci:test:stable - 21 out of 21 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 78 out of 80 jobs PASSED
78 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    1200 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #436499
      1. LayoutDataConverterTest.testConvertComplete
        java.lang.AssertionError: expected:<{"deletedItems":[],"rootItems":{"dropZone":"","main":"0e6b3a7c-4cd9-43c8-b6a5-d479096d0a63"},"items":{"82f9a9ee-8adb-4514-a759-e0d5579f9a23":{"itemId":"82f9a9ee-8adb-4514-a759-e0d5579f9a23","children":[],"type":"fragment","config":{"tablet":{"styles":{}},"landscapeMobile":{"styles":{}},"portraitMobile":{"styles":{}},"styles":{"shadow":"","textAlign":"","backgroundImage":{},"paddingRight":"","minWidth":"","marginLeft":"","marginRight":"","minHeight":"","paddingBottom":"","overflow":"","fontFamily":"","borderRadius":"","maxHeight":"","borderWidth":0,"width":"","marginBottom":"","fontSize":"","paddingTop":"","opacity":100,"paddingLeft":"","marginTop":"","fontWeight":"","height":"","maxWidth":""},"fragmentEntryLinkId":"1"},"parentId":"71ff1798-ebbc-46f9-af95-eb666c8a98ae"},"7e396267-d255-4f7c-9487-90b1d114e408":{"itemId":"7e396267-d255-4f7c-9487-90b1d114e408","children":[],"type":"column","config":{"tablet":{},"size":12,"landscapeMobile":{},"portraitMobile":{}},"parentId":"42891524-ea76-4d26-8694-ef8037bc2901"},"8a233f24-50b0-45ef-b4be-ae9e0709cb29":{"itemId":"8a233f24-50b0-45ef-b4be-ae9e0709cb29","children":["260443dd-b562-4892-bf6d-f40f05642ba4","b535a560-0862-4e60-bc2f-c7ede591b5b4"],"type":"column","config":{"tablet":{},"size":4,"landscapeMobile":{},"portraitMobile":{}},"parentId":"a77fec2a-e73b-4140-9098-783e0a1eac0a"},"973bed50-5a3b-49de-95f5-2304d9c7a8da":{"itemId":"973bed50-5a3b-49de-95f5-2304d9c7a8da","children":["5cbe9a6d-9047-49d0...

For upstream results, click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#7163
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#2230
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - pavel-savinov > liferay-echo - PR#2230 - 2020-09-08[00:31:54]
Spira Jenkins Build:publish-spira-report#4338

@pavel-savinov pavel-savinov deleted the pr-629 branch September 8, 2020 10:45
@pavel-savinov pavel-savinov restored the pr-629 branch September 8, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavel-savinov @liferay-continuous-integration @jkappler