Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-123518 Use customSelect event to avoid the modal setting up any listener #2908

Closed
wants to merge 1 commit into from
Closed

LPS-123518 Use customSelect event to avoid the modal setting up any listener #2908

wants to merge 1 commit into from

Conversation

victorg1991
Copy link
Collaborator

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@victorg1991
Copy link
Collaborator Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 44db1de072463c2b643ca9a4e7a08bd4c8ef5832

Sender Branch:

Branch Name: LPS-123518_asset_browser
Branch GIT ID: 85eb7687b748f2ee5aeaa99b642f424b29110640

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#4743
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#2908
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - victorg1991 > liferay-echo - PR#2908 - 2020-11-17[01:20:14]
Spira Jenkins Build:publish-spira-report#8441

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 25 jobs passed in 3 hours 44 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 157241864d789de0467b23ad63b8a2a8f40a2985

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 20 out of 25 jobs PASSED
20 Successful Jobs:
For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at 1453101:
  1. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
    Job Results:

    184 Tests Passed.
    5 Tests Failed.

  4. ...

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#7256
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#2908
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - victorg1991 > liferay-echo - PR#2908 - 2020-11-17[02:12:46]
Spira Jenkins Build:publish-spira-report#14035

@Tim-Cao
Copy link

Tim-Cao commented Nov 17, 2020

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 21 out of 25 jobs passed in 4 hours 15 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5a9b1d9482a136dcd8a3104376646eb082414b3d

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 25 jobs PASSED
21 Successful Jobs:
For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at 587c1ac:

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#4763
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#2908
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - victorg1991 > liferay-echo - PR#2908 - 2020-11-17[16:17:33]
Spira Jenkins Build:publish-spira-report#8539

@Tim-Cao
Copy link

Tim-Cao commented Nov 18, 2020

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@victorg1991 victorg1991 added the ✅ Ready to Merge Pull request is ready and can be forwarded. label Nov 18, 2020
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 21 out of 25 jobs passed in 6 hours 43 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a13ddd1546319ec52ea5228accd463f4c407694c

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 20 out of 25 jobs PASSED
20 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at a13ddd1:
  1. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
    Job Results:

    185 Tests Passed.
    5 Tests Failed.

  4. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    2493 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #428187
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
Duplicate entry '20099-com.liferay.commerce.price.list.model.CommercePriceList-4-' for key 'IX_A9FF4B2C'
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#96031

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#7393
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#2908
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - victorg1991 > liferay-echo - PR#2908 - 2020-11-17[23:28:42]
Spira Jenkins Build:publish-spira-report#14185

@victorg1991 victorg1991 deleted the LPS-123518_asset_browser branch December 18, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success ✅ Ready to Merge Pull request is ready and can be forwarded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorg1991 @liferay-continuous-integration @Tim-Cao