LPS-123847 - Support having multiple Collection selectors in a single page #2986

ruben-pulido · 2020-11-23T16:20:00Z

//cc @ealonso @jkappler @veroglez

Adds more functionality on top of brianchandotcom#96029

LPS-123388 - Render a select element
LPS-123847 - Support having multiple Collection selectors in a single page

…yIds in AssetListEntryAssetEntryRelLocalServiceImpl

…thods with assetCategoryIds in AssetListAssetEntryProvider

…setEntryProviderImpl

…verContext

…tegoryIds in AssetListEntryAssetEntryRelLocalServiceImpl

…istAssetEntryProviderImpl

…t in AssetEntryListLayoutListRetriever

LPS-123484 WIP - Display select element

… is empty

This will be replaced in follow-up pulls, but allows for initial manual testing until Vocabulary/Category item selector is in place.

…abulary defined in fragment configuration

…ererWebKeys

…eter name to avoid collisions between several Collection Filter Fragment instances

… id parameter name corresponding to the Collection Filter Fragment being dealt with

ruben-pulido · 2020-11-23T16:20:10Z

ci:test:relevant

liferay-continuous-integration · 2020-11-23T16:25:35Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5f0804dc889f85ea2116065011d903a63988937d

Sender Branch:

Branch Name: LPS-123847.3
Branch GIT ID: 23896e4ff5b0e413f44d1da406d65d88c4cbbac6

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-11-23T16:30:06Z

Jenkins Build:test-portal-source-format#4404
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#2986
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - ruben-pulido > liferay-echo - PR#2986 - 2020-11-23[08:20:52]
Spira Jenkins Build:publish-spira-report#7687

liferay-continuous-integration · 2020-11-23T19:16:52Z

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 19 out of 25 jobs passed in 3 hours 10 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5f0804dc889f85ea2116065011d903a63988937d

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 8 out of 9 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8/0~~

8 Successful Jobs:

ci:test:relevant - 19 out of 25 jobs PASSED

6 Failed Jobs:

19 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #456782

	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecvClosed(ProtocolStack.java:816)
	at org.jenkinsci.remoting.protocol.FilterLayer.onRecvClosed(FilterLayer.java:287)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.onRecvClosed(SSLEngineFilterLayer.java:181)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.switchToNoSecure(SSLEngineFilterLayer.java:283)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processWrite(SSLEngineFilterLayer.java:503)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processQueuedWrites(SSLEngineFilterLayer.java:248)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.doSend(SSLEngineFilterLayer.java:200)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.doCloseSend(SSLEngineFilterLayer.java:213)
	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.doCloseSend(ProtocolStack.java:784)
	at org.jenkinsci.remoting.protocol.ApplicationLayer.doCloseWrite(ApplicationLayer.java:173)
	at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer$ByteBufferCommandTransport.closeWrite(ChannelApplicationLayer.java:314)
	at hudson.remoting.Channel.close(Channel.java:1452)
	at hudson.remoting.Channel.close(Channel.java:1405)
	at hudson.slaves.SlaveComputer.closeChannel(SlaveComputer.java:832)
	at hudson.slaves.SlaveComputer.access$800(SlaveComputer.java:105)
	at hudson.slaves.SlaveComputer$3.run(SlaveComputer.java:741)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
ERROR: Step ???Publish JUnit test result report??? failed: no workspace for test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master #456782
ERROR: Step ???Cucumber reports??? failed: no workspace for test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master #456782
ERROR: Build step failed with exception
java.lang.NullPointerException
Build step 'Execute Scripts' marked build as failure
Finished: FAILURE

Failures in common with acceptance upstream results at f26d0ce:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
Job Results:
9 Tests Passed.
0 Tests Failed.
1. AXIS_VARIABLE=7,label_exp=!master #447464
  Build was aborted

test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #456783

	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecvClosed(ProtocolStack.java:816)
	at org.jenkinsci.remoting.protocol.FilterLayer.onRecvClosed(FilterLayer.java:287)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.onRecvClosed(SSLEngineFilterLayer.java:181)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.switchToNoSecure(SSLEngineFilterLayer.java:283)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processWrite(SSLEngineFilterLayer.java:503)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processQueuedWrites(SSLEngineFilterLayer.java:248)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.doSend(SSLEngineFilterLayer.java:200)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.doCloseSend(SSLEngineFilterLayer.java:213)
	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.doCloseSend(ProtocolStack.java:784)
	at org.jenkinsci.remoting.protocol.ApplicationLayer.doCloseWrite(ApplicationLayer.java:173)
	at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer$ByteBufferCommandTransport.closeWrite(ChannelApplicationLayer.java:314)
	at hudson.remoting.Channel.close(Channel.java:1452)
	at hudson.remoting.Channel.close(Channel.java:1405)
	at hudson.slaves.SlaveComputer.closeChannel(SlaveComputer.java:832)
	at hudson.slaves.SlaveComputer.access$800(SlaveComputer.java:105)
	at hudson.slaves.SlaveComputer$3.run(SlaveComputer.java:741)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
ERROR: Step ???Publish JUnit test result report??? failed: no workspace for test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master #456783
ERROR: Step ???Cucumber reports??? failed: no workspace for test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master #456783
ERROR: Build step failed with exception
java.lang.NullPointerException
Build step 'Execute Scripts' marked build as failure
Finished: FAILURE

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #456786

Please fix semantic versioning on ruben-pulido/LPS-123847.3

     [exec] 		+   method     findByUuid_C(java.lang.String,long,int,int,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     java.util.List
     [exec] 		+   method     findByUuid_C(java.lang.String,long,int,int,com.liferay.portal.kernel.util.OrderByComparator,boolean)
     [exec] 			+   access     abstract
     [exec] 			+   return     java.util.List
     [exec] 		+   method     findByUuid_C_First(java.lang.String,long,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     com.liferay.portal.kernel.model.Region
     [exec] 		+   method     findByUuid_C_Last(java.lang.String,long,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     com.liferay.portal.kernel.model.Region
     [exec] 		+   method     findByUuid_C_PrevAndNext(long,java.lang.String,long,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     com.liferay.portal.kernel.model.Region[]
     [exec] 		+   method     findByUuid_First(java.lang.String,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     com.liferay.portal.kernel.model.Region
     [exec] 		+   method     findByUuid_Last(java.lang.String,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     com.liferay.portal.kernel.model.Region
     [exec] 		+   method     findByUuid_PrevAndNext(long,java.lang.String,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     com.liferay.portal.kernel.model.Region[]
     [exec] 		+   method     removeByUuid(java.lang.String)
     [exec] 			+   access     abstract
     [exec] 			+   return     void
     [exec] 		+   method     removeByUuid_C(java.lang.String,long)
     [exec] 			+   access     abstract
     [exec] 			+   return     void
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/9.14.0/26ace10317f060c3623376124ed3fa0ae775cdd4/com.liferay.portal.kernel-9.14.0.jar

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
189 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=13,label_exp=!master #311933
  1. LocalFile.ContentPagesWithMapping#ViewMappableFieldsAreGroupedByFieldset - Poshi Report - Poshi Summary - Console Output

liferay-continuous-integration · 2020-11-23T19:28:04Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7549
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#2986
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - ruben-pulido > liferay-echo - PR#2986 - 2020-11-23[08:28:04]
Spira Jenkins Build:publish-spira-report#14613

ruben-pulido · 2020-11-23T22:26:30Z

ci:test:relevant

liferay-continuous-integration · 2020-11-24T01:20:55Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 25 jobs passed in 2 hours 52 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ca120467eba5a0eb42c5978986a7679affe43e42

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 21 out of 25 jobs PASSED

4 Failed Jobs:

21 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 211d833:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
Job Results:
10 Tests Passed.
0 Tests Failed.
1. AXIS_VARIABLE=7,label_exp=!master #455326
  Build was aborted

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #418870

Please fix semantic versioning on ruben-pulido/LPS-123847.3

     [exec] 		+   method     findByUuid_C(java.lang.String,long,int,int,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     java.util.List
     [exec] 		+   method     findByUuid_C(java.lang.String,long,int,int,com.liferay.portal.kernel.util.OrderByComparator,boolean)
     [exec] 			+   access     abstract
     [exec] 			+   return     java.util.List
     [exec] 		+   method     findByUuid_C_First(java.lang.String,long,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     com.liferay.portal.kernel.model.Region
     [exec] 		+   method     findByUuid_C_Last(java.lang.String,long,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     com.liferay.portal.kernel.model.Region
     [exec] 		+   method     findByUuid_C_PrevAndNext(long,java.lang.String,long,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     com.liferay.portal.kernel.model.Region[]
     [exec] 		+   method     findByUuid_First(java.lang.String,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     com.liferay.portal.kernel.model.Region
     [exec] 		+   method     findByUuid_Last(java.lang.String,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     com.liferay.portal.kernel.model.Region
     [exec] 		+   method     findByUuid_PrevAndNext(long,java.lang.String,com.liferay.portal.kernel.util.OrderByComparator)
     [exec] 			+   access     abstract
     [exec] 			+   return     com.liferay.portal.kernel.model.Region[]
     [exec] 		+   method     removeByUuid(java.lang.String)
     [exec] 			+   access     abstract
     [exec] 			+   return     void
     [exec] 		+   method     removeByUuid_C(java.lang.String,long)
     [exec] 			+   access     abstract
     [exec] 			+   return     void
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/9.14.0/26ace10317f060c3623376124ed3fa0ae775cdd4/com.liferay.portal.kernel-9.14.0.jar

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
189 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=13,label_exp=!master #371597
  1. LocalFile.ContentPagesWithMapping#ViewMappableFieldsAreGroupedByFieldset - Poshi Report - Poshi Summary - Console Output

liferay-continuous-integration · 2020-11-24T01:36:13Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4981
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#2986
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - ruben-pulido > liferay-echo - PR#2986 - 2020-11-23[14:26:51]
Spira Jenkins Build:publish-spira-report#14644

ruben-pulido · 2020-11-26T20:31:08Z

Rebased here: #3046

ruben-pulido added 30 commits November 17, 2020 10:07

LPS-123484 Add asset-entry-rel-api to asset-list-service build.gradle

5db0a0f

LPS-123484 Overload getAssetListEntryAssetEntryRels with assetCategor…

1ee9677

…yIds in AssetListEntryAssetEntryRelLocalServiceImpl

LPS-123484 Add assetCategoryIds parameter to _getManualAssetEntries

eee7f4b

LPS-123484 Add overloaded getAssetEntries and getAssetEntriesCount me…

a2352d3

…thods with assetCategoryIds in AssetListAssetEntryProvider

LPS-123484 Implement overloaded method getAssetEntries in AssetListAs…

110bff4

…setEntryProviderImpl

LPS-123484 Delegate call in overloaded method

f9ff425

LPS-123484 Add getAssetCategoryIdsOptional method to LayoutListRetrie…

29dc552

…verContext

LPS-123484 Adapt DefaultLayoutListRetrieverContext

ef35dd5

LPS-123484 Overload getAssetListEntryAssetEntryRelsCount with assetCa…

33fe57c

…tegoryIds in AssetListEntryAssetEntryRelLocalServiceImpl

LPS-123484 Implement overloaded method getAssetEntriesCount in AssetL…

0e03cf5

…istAssetEntryProviderImpl

LPS-123484 Delegate call in overloaded method

27d1a4d

LPS-123484 buildService

2c0bc83

LPS-123484 baseline

e69dcf7

LPS-123484 Take into account categories when retrieving list and coun…

341734c

…t in AssetEntryListLayoutListRetriever

LPS-123484 Set assetCategoryIds in DefaultLayoutListRetrieverContext

749b77f

LPS-123484 WIP - Display select element

LPS-123484 Use empty array as default value if "categoryId" parameter…

e07d261

… is empty

LPS-123484 Consistency. Use empty array instead of null

54b996d

LPS-123388 build.gradle

ba967da

LPS-123388 Add Web-ContextPath to bnd.bnd

b2aa190

LPS-123388 Define WebKeys

2111df4

LPS-123388 Temporarily use vocabularyId as configuration field.

a9a65b9

This will be replaced in follow-up pulls, but allows for initial manual testing until Vocabulary/Category item selector is in place.

LPS-123388 Read fragment configuration from JSON file

aa41bb6

LPS-123388 Create CollectionFilterFragmentRendererDisplayContext

afd5969

LPS-123388 JSPs to render drop down menu with child categories of voc…

fc2d47d

…abulary defined in fragment configuration

LPS-123388 Render drop down menu listing categories using JSP

320e59f

LPS-123847 Add FRAGMENT_ENTRY_LINK_ID to CollectionFilterFragmentRend…

0830840

…ererWebKeys

LPS-123847 Append fragment entry link id value to each category param…

48d144a

…eter name to avoid collisions between several Collection Filter Fragment instances

LPS-123847 Add FRAGMENT_ENTRY_LINK_ID attribute to request

6299c95

LPS-123847 Read all category id parameter values and union all of them

9c92f16

LPS-123847 Add helper method _getParameterName to obtain the category…

919caef

… id parameter name corresponding to the Collection Filter Fragment being dealt with

liferay-continuous-integration added the ci:test:sf - pending label Nov 23, 2020

ruben-pulido added the 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. label Nov 23, 2020

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - pending labels Nov 23, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending labels Nov 23, 2020

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Nov 23, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - failure ci:test:relevant - pending ci:test:stable - pending labels Nov 23, 2020

jkappler closed this Nov 25, 2020

jkappler reopened this Nov 25, 2020

ruben-pulido closed this Nov 26, 2020

LPS-123847 - Support having multiple Collection selectors in a single page #2986

LPS-123847 - Support having multiple Collection selectors in a single page #2986

Conversation

ruben-pulido commented Nov 23, 2020 • edited Loading

ruben-pulido commented Nov 23, 2020

liferay-continuous-integration commented Nov 23, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Nov 23, 2020

liferay-continuous-integration commented Nov 23, 2020

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 19 out of 25 jobs passed in 3 hours 10 minutes

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

6 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

liferay-continuous-integration commented Nov 23, 2020

ruben-pulido commented Nov 23, 2020

liferay-continuous-integration commented Nov 24, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 25 jobs passed in 2 hours 52 minutes

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

This pull contains no unique failures.

Job Results:

Job Results:

Job Results:

liferay-continuous-integration commented Nov 24, 2020

ruben-pulido commented Nov 26, 2020

ruben-pulido commented Nov 23, 2020 •

edited

Loading