Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-125853 [Bug] Widget section doesn't appear when an AB testing is running in other experience #3507

Closed
wants to merge 1 commit into from
Closed

LPS-125853 [Bug] Widget section doesn't appear when an AB testing is running in other experience #3507

wants to merge 1 commit into from

Conversation

dgarciasarai
Copy link

Description

When the user has several experiences but one of them has an A/B Test, some sidebars hide (Fragments and Widgets and Page Design Options) because the user cannot change the page during an active A/B Test. To do this, we check the permission LOCKED_SEGMENTS_EXPERIMENT.

Steps to reproduce it

  • Connect Liferay Portal DXP with Analytics Cloud (AC)
  • Create a Page (cp)
  • Create an Experience (exp1)
  • Create an A/B Test for Default experience
  • Click Edit to edit the page and change between Default and exp1 experience to see the bug

Solution

In the file sidebarReducer.js we specify that the default panel ID is fragments-widgets:

const DEFAULT_PANEL_ID = 'fragments-widgets';

In this case, the experience (the one with the A/B Test) doesn't have that panel available and it's not able to render the first one available (Page Structure).

The solution proposed is create a function that retrieves the panel and sidebarPanelId of the first available panel if the selected sidebar panel ID is not found.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@dgarciasarai
Copy link
Author

ci:test:sf

@victorg1991 victorg1991 added the 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. label Jan 26, 2021
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 37360aa819a399af55b83604302f74ad4b076d12

Sender Branch:

Branch Name: LPS-125853
Branch GIT ID: decd35cb0b2245da5544bfc075d72176601e8ca5

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@veroglez veroglez self-assigned this Jan 26, 2021
@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#5199
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#3507
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - dgarciasarai > liferay-echo - PR#3507 - 2021-01-26[02:34:18]
Spira Jenkins Build:publish-spira-report#14156

@dgarciasarai
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 25 out of 25 jobs passed in 2 hours 41 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6d3b717cd19a315c55e2c2ffdaf4b2e5d5766cae

Upstream Comparison:

Branch GIT ID: 6d3b717cd19a315c55e2c2ffdaf4b2e5d5766cae
Jenkins Build URL: Acceptance Upstream DXP (master) #1487

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 25 out of 25 jobs PASSED
25 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#7789
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#3507
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - dgarciasarai > liferay-echo - PR#3507 - 2021-01-26[06:49:26]
Spira Jenkins Build:publish-spira-report#12649

@veroglez veroglez added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. labels Jan 27, 2021
@veroglez
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#98135

@dgarciasarai dgarciasarai deleted the LPS-125853 branch February 5, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@veroglez veroglez

Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success ✅ Ready to Merge Pull request is ready and can be forwarded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgarciasarai @liferay-continuous-integration @veroglez @victorg1991