LPS-130936 Also trim when updating #4458

jkappler · 2021-05-06T07:33:48Z

No description provided.

liferay-continuous-integration · 2021-05-06T07:33:54Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

jkappler · 2021-05-06T07:34:42Z

ci:forward

liferay-continuous-integration · 2021-05-06T07:34:46Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

jkappler · 2021-05-06T07:34:56Z

@brianikim, @ealonso

liferay-continuous-integration · 2021-05-06T07:38:58Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 76da930fa5d546b4b782e85737378267eb31c480

Sender Branch:

Branch Name: pr-4398
Branch GIT ID: 6ad78042b197f10e0cbb98b32e3a324b8a4369a5

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-05-06T07:40:20Z

Jenkins Build:test-portal-source-format#6486

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-echo#4458

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - jkappler > liferay-echo - PR#4458 - 2021-05-06[00:35:27]

Testray Importer:publish-testray-report#537

liferay-continuous-integration · 2021-05-06T09:50:47Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 18 out of 21 jobs passed in 1 hour 55 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1227401_8118

Base Branch:

Branch Name: master
Branch GIT ID: 76da930fa5d546b4b782e85737378267eb31c480

Upstream Comparison:

Branch GIT ID: ddeada2e14c1bbf5631ea173b12455bca5d5561d
Jenkins Build URL: Acceptance Upstream DXP (master) #1836

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 18 out of 21 jobs PASSED

3 Failed Jobs:

18 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
53 Tests Passed.
3 Tests Failed.

Failures in common with acceptance upstream results at ddeada2:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

2 Tests Passed.
3 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #384542

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: 
Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1620293543302.log:
!SESSION 2021-05-06 09:32:40.960 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_121
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
!ENTRY com.liferay.portal.vulcan.impl 4 0 2021-05-06 09:32:40.960

!MESSAGE FrameworkEvent ERROR

!STACK 0

org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.vulcan.impl [90]

Unresolved requirement: Import-Package: com.liferay.object.model; version="[1.0.0,2.0.0)"
at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

!ENTRY com.liferay.click.to.ch...

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError:

FrameworkEvent ERROR

org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.vulcan.impl [90]

Unresolved requirement: Import-Package: com.liferay.object.model; version="[1.0.0,2.0.0)"
at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
at java.nio.file.Files.walkFileTree(Files.java:2670)
at java.nio.file.Files.walkFileTree(Files.java:2742)
at com.liferay.portal.log.assertor.Porta...</code></pre></div></li><li><div><a href="https://test-1-9.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/384542//testReport/com.liferay.poshi.runner/PoshiRunner/test_LocalFile_PortalSmoke_Smoke_">LocalFile.PortalSmoke#Smoke</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-22/test-portal-acceptance-pullrequest(master)/8118/lpkg-base-jdk8/0/0/LocalFile.PortalSmoke_Smoke/index.html.gz">Poshi Report</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-22/test-portal-acceptance-pullrequest(master)/8118/lpkg-base-jdk8/0/0/LocalFile.PortalSmoke_Smoke/summary.html.gz">Poshi Summary</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-22/test-portal-acceptance-pullrequest(master)/8118/lpkg-base-jdk8/0/0/jenkins-console.txt.gz">Console Output</a></div></li></ol></div></li></ol></div></li></ol></details></details></html>

liferay-continuous-integration · 2021-05-06T09:57:01Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#8118

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-echo#4458

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - jkappler > liferay-echo - PR#4458 - 2021-05-06[00:54:55]

Testray Importer:publish-testray-report#543

jkappler · 2021-05-06T10:11:36Z

ci:forward

liferay-continuous-integration · 2021-05-06T10:11:40Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-05-06T10:11:43Z

Skipping previously passed test suites:
ci:test:sf

…mes.

jkappler · 2021-05-07T09:00:55Z

thanks @Tim-Cao!

jkappler · 2021-05-07T09:01:04Z

ci:forward

liferay-continuous-integration · 2021-05-07T09:01:09Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-05-07T09:08:22Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 7 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bca9cde3cd55d7000ce61a7efffa9ada8decdb4b

Sender Branch:

Branch Name: pr-4398
Branch GIT ID: fad895a1c50fee3de82c4a42c14bdb4f00f21927

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-05-07T09:09:20Z

Jenkins Build:test-portal-source-format#4916

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-echo#4458

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - jkappler > liferay-echo - PR#4458 - 2021-05-07[02:01:21]

Testray Importer:publish-testray-report#601

liferay-continuous-integration · 2021-05-07T11:27:26Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 20 out of 21 jobs passed in 2 hours 25 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bca9cde3cd55d7000ce61a7efffa9ada8decdb4b

Upstream Comparison:

Branch GIT ID: d57c657bd5e4815bae43c722ab39cfee7b6caac0
Jenkins Build URL: Acceptance Upstream DXP (master) #1842

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 19 out of 21 jobs PASSED

2 Failed Jobs:

19 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at d57c657:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

2 Tests Passed.
3 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #386224

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: 
Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1620385806552.log:
!SESSION 2021-05-07 11:10:25.565 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_121
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
!ENTRY com.liferay.portal.vulcan.impl 4 0 2021-05-07 11:10:25.565

!MESSAGE FrameworkEvent ERROR

!STACK 0

org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.vulcan.impl [268]

Unresolved requirement: Import-Package: com.liferay.object.model; version="[1.0.0,2.0.0)"
at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

!ENTRY com.liferay.click.to.c...

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError:

FrameworkEvent ERROR

org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.vulcan.impl [268]

Unresolved requirement: Import-Package: com.liferay.object.model; version="[1.0.0,2.0.0)"
at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
at java.nio.file.Files.walkFileTree(Files.java:2670)
at java.nio.file.Files.walkFileTree(Files.java:2742)
at com.liferay.portal.log.assertor.Port...</code></pre></div></li><li><div><a href="https://test-1-10.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/386224//testReport/com.liferay.poshi.runner/PoshiRunner/test_LocalFile_PortalSmoke_Smoke_">LocalFile.PortalSmoke#Smoke</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-6/test-portal-acceptance-pullrequest(master)/8477/lpkg-base-jdk8/0/0/LocalFile.PortalSmoke_Smoke/index.html.gz">Poshi Report</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-6/test-portal-acceptance-pullrequest(master)/8477/lpkg-base-jdk8/0/0/LocalFile.PortalSmoke_Smoke/summary.html.gz">Poshi Summary</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-6/test-portal-acceptance-pullrequest(master)/8477/lpkg-base-jdk8/0/0/jenkins-console.txt.gz">Console Output</a></div></li></ol></div></li></ol></div></li></ol></details></details></html>

liferay-continuous-integration · 2021-05-07T11:27:58Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2021-05-07T11:28:16Z

Pull request has been successfully forwarded to brianchandotcom#101517
Console

liferay-continuous-integration · 2021-05-07T11:31:14Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#8477

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-echo#4458

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - jkappler > liferay-echo - PR#4458 - 2021-05-07[02:01:20]

Testray Importer:publish-testray-report#803

jkappler added the ✅ Ready to Merge Pull request is ready and can be forwarded. label May 6, 2021

liferay-continuous-integration added the ci:test:sf - pending label May 6, 2021

jkappler mentioned this pull request May 6, 2021

LPS-130936 #4398

Closed

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - pending labels May 6, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels May 6, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels May 6, 2021

brianikim and others added 3 commits May 7, 2021 09:37

LPS-130936 We don't need leading and trailing whitespaces in group na…

5618324

…mes.

LPS-130936 Also trim when updating

e2e2f25

LPS-127772 Create a new map, since some times we get an immutable map

fad895a

jkappler force-pushed the pr-4398 branch from 6ad7804 to fad895a Compare May 7, 2021 09:00

jkappler added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed 🛠 Changes Suggested Reviewer has reviewed the PR and suggested changes. labels May 7, 2021

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - success ci:test:relevant - failure ci:test:stable - success ci:test:sf - pending labels May 7, 2021

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels May 7, 2021

liferay-continuous-integration mentioned this pull request May 7, 2021

LPS-130936 Also trim when updating brianchandotcom/liferay-portal#101517

Closed

liferay-continuous-integration closed this May 7, 2021

jkappler deleted the pr-4398 branch July 15, 2021 11:55

LPS-130936 Also trim when updating #4458

LPS-130936 Also trim when updating #4458

Conversation

jkappler commented May 6, 2021

liferay-continuous-integration commented May 6, 2021

jkappler commented May 6, 2021

liferay-continuous-integration commented May 6, 2021

jkappler commented May 6, 2021

liferay-continuous-integration commented May 6, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented May 6, 2021

liferay-continuous-integration commented May 6, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 18 out of 21 jobs passed in 1 hour 55 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

liferay-continuous-integration commented May 6, 2021

jkappler commented May 6, 2021

liferay-continuous-integration commented May 6, 2021

liferay-continuous-integration commented May 6, 2021

jkappler commented May 7, 2021

jkappler commented May 7, 2021

liferay-continuous-integration commented May 7, 2021

liferay-continuous-integration commented May 7, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 7 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented May 7, 2021

liferay-continuous-integration commented May 7, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 20 out of 21 jobs passed in 2 hours 25 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

liferay-continuous-integration commented May 7, 2021

liferay-continuous-integration commented May 7, 2021

liferay-continuous-integration commented May 7, 2021