LPS-131934 Modify Asset Publisher configuration info message to specify the max number of items to be display #4537

robertoDiaz · 2021-05-13T09:01:30Z

No description provided.

…fy the max number of items to be displayed

…AX_DELTA

liferay-continuous-integration · 2021-05-13T09:01:34Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

jkappler · 2021-05-13T09:13:30Z

ci:test:relevant

jkappler · 2021-05-13T09:13:36Z

ci:test:sf

liferay-continuous-integration · 2021-05-13T09:19:23Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 679c6f859055569c3953db3ecf7e8e4a359eec2b

Sender Branch:

Branch Name: pr-869
Branch GIT ID: f2e642f921644e2cd2a6277f980bf3e2d24d3f62

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-05-13T09:21:08Z

Jenkins Build:test-portal-source-format#2884

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-echo#4537

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - robertoDiaz > liferay-echo - PR#4537 - 2021-05-13[02:15:35]

Testray Importer:publish-testray-report#598

ealonso · 2021-05-13T09:26:30Z

...asset-publisher-web/src/main/resources/META-INF/resources/configuration/display_settings.jsp

@@ -51,7 +51,7 @@ PortletURL configurationRenderURL = (PortletURL)request.getAttribute("configurat
 	<aui:option label="view-in-context" selected="<%= assetPublisherDisplayContext.isAssetLinkBehaviorViewInPortlet() %>" value="viewInPortlet" />
 </aui:select>

-<aui:input helpMessage='<%= LanguageUtil.get(request, "number-of-items-to-display-help") + ' ' + LanguageUtil.format(request, "maximum-allowed-value-is-x", SearchContainer.MAX_DELTA, false) %>' label="number-of-items-to-display" name="preferences--delta--" type="text" value="<%= assetPublisherDisplayContext.getDelta() %>">
+<aui:input helpMessage='<%= LanguageUtil.get(request, "number-of-items-to-display-help") + " " + LanguageUtil.format(request, "maximum-allowed-value-is-x", SearchContainer.MAX_DELTA, false) %>' label="number-of-items-to-display" name="preferences--delta--" type="text" value="<%= assetPublisherDisplayContext.getDelta() %>">


I think it should be StringPool.SPACE

cc: @jkappler

In other cases I see this pattern @ealonso

liferay-continuous-integration · 2021-05-13T12:40:54Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 22 out of 25 jobs passed in 2 hours 27 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 679c6f859055569c3953db3ecf7e8e4a359eec2b

Upstream Comparison:

Branch GIT ID: 679c6f859055569c3953db3ecf7e8e4a359eec2b
Jenkins Build URL: Acceptance Upstream DXP (master) #1861

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 22 out of 25 jobs PASSED

3 Failed Jobs:

22 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

23 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=3,label_exp=!master #421299

     [exec] Result: 1
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20210513045130658
     [exec] Killing Chrome.
     [exec] Killing Firefox.
     [exec] chrome: no process found
     [exec] firefox: no process found
     [exec] chrome: no process found
     [exec] firefox: no process found
     [exec] Result: 1
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20210513045130691
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20210513045130728
     [exec] HEAD is now at 679c6f859055 LPS-132139 Modify case to logout before login
     [exec] Already on 'master'
     [exec] Already on 'master'
     [exec] HEAD is now at 3bf0e655 Fix portlet test to match className
     [exec] Already on '2.x'
     [exec] Already on '2.x'
     [exec] HEAD is now at 434358cb4 FACES-3558 Upgrade to com.liferay.faces.test.selenium-0.5.5.jar
     [exec] Already on '4.x'
     [exec] Already on '4.x'
     [exec] HEAD is now at b9e92348 FACES-3558 Upgrade to com.liferay.faces.test.selenium-0.5.5.jar
     [exec] Already on '4.x'
     [exec] Already on '4.x'
[stopwatch] [stop.current.job: 14.317 sec]
BUILD SUCCESSFUL

Total time: 15 seconds

echo 'Exit shell.'

Exit shell.

[EnvInject] - Injecting environment variables from a build step.

[EnvInject] - Injecting as environment variables the properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties'

[EnvInject] - Variables injected successfully.

[description-setter] Description set: <strong>liferay-echo</strong> - <a href="https://github.com/liferay-echo/liferay-portal/pull/4537"&gt;PR#4537&lt;/a> - <a href="https://test-1-10.liferay.com//userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/4717/jenkins-report.html"&gt;Jenkins Report</a><ul><li><strong>LocalFile.BlogsAutoTagging#DisableAutoTaggingForSite</strong><ul><li><a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-10/test-portal-acceptance-pullrequest%28master%29/4717/functional-tomcat90-mysql57-jdk8/0/3/LocalFile.BlogsAutoTagging_DisableAutoTaggingForSite/index.html.gz"&gt;Poshi Report</a></li><li><a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-10/test-portal-acceptance-pullrequest%28master%29/4717/functional-tomcat90-mysql57-jdk8/0/3/LocalFile.BlogsAutoTagging_DisableAutoTaggingForSite/summary.html.gz"&gt;Poshi Summary</a></li></ul></li></ul><br />

Finished: FAILURE

Failures in common with acceptance upstream results at 679c6f8:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
23 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=1,label_exp=!master #421299
  1. LocalFile.AssetPublisherUseCase#DisableShowContentAddButton - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

6 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=6,label_exp=!master #496906

     [exec] * What went wrong:

[exec] Execution failed for task ':apps:fragment:fragment-entry-processor:fragment-entry-processor-test:compileTestIntegrationJava'.

[exec] > Compilation failed; see the compiler error output for details.

[exec]

[exec] * Try:

[exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.

[exec]

[exec] * Exception is:

[exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:fragment:fragment-entry-processor:fragment-entry-processor-test:compileTestIntegrationJava'.

[exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)

[exec] 	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)

[exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)

[exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)

[exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)

[exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)

[exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)

[exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)

[exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)

[exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)

[exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)

[exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)

[exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)

[exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:409)

liferay-continuous-integration · 2021-05-13T12:47:12Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4717

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-echo#4537

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - robertoDiaz > liferay-echo - PR#4537 - 2021-05-13[03:11:56]

Testray Importer:publish-testray-report#600

jkappler · 2021-05-17T10:43:30Z

Just started reviewing :)

jkappler · 2021-05-17T11:40:20Z

Just started reviewing :)

jkappler · 2021-05-17T11:51:23Z

#4583

## [3.44.2](liferay/clay@v3.44.1...v3.44.2) (2022-01-12) ### Bug Fixes - **@clayui/css:** Cadmin Nav adds `background-color` to `.active` pseudo element ([865b037](liferay/clay@865b037)), closes [#4562](liferay/clay#4562) - **@clayui/css:** Mixins `clay-button-variant` removes unnecessary `setter()`'s ([3709d7f](liferay/clay@3709d7f)), closes [#4550](liferay/clay#4550) ## [3.44.1](liferay/clay@v3.44.0...v3.44.1) (2022-01-11) ### Bug Fixes - **@clayui/core:** remove the context property from DndProvider ([4faf0ea](liferay/clay@4faf0ea)) - **@clayui/css:** Mixins `clay-card-variant` allow styling before and after psuedo elements ([69f1d38](liferay/clay@69f1d38)), closes [#4554](liferay/clay#4554) # [3.44.0](liferay/clay@v3.43.1...v3.44.0) (2022-01-10) ### Bug Fixes - **@clayui/css:** Cadmin Input Groups `input-group-sm` missing mixin declaration ([d7027be](liferay/clay@d7027be)), closes [#4537](liferay/clay#4537) - **@clayui/css:** Cards `form-check-card` remove duplicate hover state style ([17ea640](liferay/clay@17ea640)) - **@clayui/css:** Mixins Cards check if parameter is map to avoid must be a map error ([2174587](liferay/clay@2174587)) - **@clayui/css:** Mixins Custom Forms remove `setter()`, no longer needed ([4cb30ce](liferay/clay@4cb30ce)) ### Features - **@clayui/css:** Cadmin Nav adds `nav-divider` and `nav-divider-end` ([66ba6ce](liferay/clay@66ba6ce)) - **@clayui/css:** Cards `form-check-card` checkbox/radio input should be hidden unless position utilities are used ([3120797](liferay/clay@3120797)), closes [#4544](liferay/clay#4544) - **@clayui/css:** Cards `form-check-card` convert to Clay mixin pattern ([5b4424b](liferay/clay@5b4424b)) - **@clayui/css:** Mixin `clay-card-variant` make `form-check-card` and `form-check-input` customizable ([c6a3a6f](liferay/clay@c6a3a6f)) - **@clayui/css:** Mixins `clay-custom-control-input-variant` add option to customize card ([87682d2](liferay/clay@87682d2)) - **@clayui/css:** Mixins `clay-navbar-variant` adds option to customize `nav-divider` and `nav-divider-end` ([e58c23e](liferay/clay@e58c23e)) - **@clayui/css:** Mixins Card adds `clay-form-check-card-variant` ([a834502](liferay/clay@a834502)) - **@clayui/css:** Nav adds `nav-divider` and `nav-divider-end` ([600a379](liferay/clay@600a379)) - **@clayui/css:** SVG Icons adds date-time ([4bf8d4c](liferay/clay@4bf8d4c)) - **@clayui/popover:** add a closeOnClickOutside prop ([bd722a9](liferay/clay@bd722a9)), closes [#4536](liferay/clay#4536) ## [3.43.1](liferay/clay@v3.43.0...v3.43.1) (2022-01-04) - **@clayui/core:** avoid async/await in TreeViewItem ([78f8585](liferay/clay@78f8585)), closes [#4529](liferay/clay#4529) [#4531](liferay/clay#4531) - **@clayui/core:** don't export TreeView as UNSAFE_TreeView ([fc54a6e](liferay/clay@fc54a6e)), closes [#4528](liferay/clay#4528) [#4531](liferay/clay#4531) [#4532](liferay/clay#4532)

manuelRives and others added 4 commits May 12, 2021 23:18

LPS-131934 Modify Asset Publisher configuration info message to speci…

d4c2635

…fy the max number of items to be displayed

LPS-131934 Modified max items label from static 200 to the value of M…

f9c411d

…AX_DELTA

LPS-131934 buildLang

bad2aeb

LPS-131934 SF

f2e642f

robertoDiaz mentioned this pull request May 13, 2021

LPS-131934 robertoDiaz/liferay-portal#869

Closed

jkappler added the 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. label May 13, 2021

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels May 13, 2021

ealonso reviewed May 13, 2021

View reviewed changes

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels May 13, 2021

ealonso assigned jkappler May 17, 2021

jkappler closed this May 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-131934 Modify Asset Publisher configuration info message to specify the max number of items to be display #4537

LPS-131934 Modify Asset Publisher configuration info message to specify the max number of items to be display #4537

robertoDiaz commented May 13, 2021

liferay-continuous-integration commented May 13, 2021

jkappler commented May 13, 2021

jkappler commented May 13, 2021

liferay-continuous-integration commented May 13, 2021

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented May 13, 2021

ealonso May 13, 2021

ealonso May 13, 2021

robertoDiaz May 13, 2021

liferay-continuous-integration commented May 13, 2021

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented May 13, 2021

jkappler commented May 17, 2021

jkappler commented May 17, 2021

jkappler commented May 17, 2021 •

edited

Loading

LPS-131934 Modify Asset Publisher configuration info message to specify the max number of items to be display #4537

LPS-131934 Modify Asset Publisher configuration info message to specify the max number of items to be display #4537

Conversation

robertoDiaz commented May 13, 2021

liferay-continuous-integration commented May 13, 2021

jkappler commented May 13, 2021

jkappler commented May 13, 2021

liferay-continuous-integration commented May 13, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented May 13, 2021

ealonso May 13, 2021

Choose a reason for hiding this comment

ealonso May 13, 2021

Choose a reason for hiding this comment

robertoDiaz May 13, 2021

Choose a reason for hiding this comment

liferay-continuous-integration commented May 13, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 22 out of 25 jobs passed in 2 hours 27 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented May 13, 2021

jkappler commented May 17, 2021

jkappler commented May 17, 2021

jkappler commented May 17, 2021 • edited Loading

jkappler commented May 17, 2021 •

edited

Loading