-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS] LPS-134264 #4885
[TS] LPS-134264 #4885
Conversation
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
ci:test:sf |
ci:test:relevant |
✔️ ci:test:sf - 1 out of 1 jobs passed in 12 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-134264 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#5258 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-echo#4885 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#1098 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#7844 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-echo#4885 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - jonathanmccann > liferay-echo - PR#4885 - 2021-06-15[15:20:45] Testray Importer:publish-testray-report#1102 |
ci:test:relevant |
Just started reviewing :) |
Jenkins Build:test-portal-acceptance-pullrequest(master)#8476 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-echo#4885 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - jonathanmccann > liferay-echo - PR#4885 - 2021-06-16[06:16:38] Testray Importer:publish-testray-report#1315 |
7e02cff
to
648dba9
Compare
@ruben-pulido Thank you for letting me know. I've pushed up some changes to resolve that issue. I'll keep an eye on the test results to see if anything still doesn't pass. |
ci:test:sf |
ci:test:relevant |
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-134264 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#6032 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-echo#4885 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#1420 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#9776 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-echo#4885 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - jonathanmccann > liferay-echo - PR#4885 - 2021-06-16[14:55:32] Testray Importer:publish-testray-report#1425 |
Just started reviewing :) |
Thanks for the updated changes @jonathanmccann. For subsequent pulls I have two suggestions that would help us during the review:
Thanks!! :) |
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Skipping previously passed test suites: |
All required test suite(s) passed. |
Pull request has been successfully forwarded to brianchandotcom#103363 |
Prior to https://issues.liferay.com/browse/LPS-128817 groups were filtered using the following logic:
https://github.com/liferay/liferay-portal-ee/blob/fix-pack-dxp-12-7210/modules/apps/site/site-browser-web/src/main/java/com/liferay/site/browser/web/internal/display/context/SiteBrowserDisplayContext.java#L398-L404
After LPS-128817 filtering only took place if:
filterManageableGroups
is trueusersGroups
is supplied to the group searchThis change in behavior allowed all sites to be returned when a user was adding another user to a site (https://issues.liferay.com/browse/LPS-134264).
The changes in this pull attempt to bring back the previous behavior by checking for the "Assign Members" permission.
Please let me know if there are any questions or if there are any flaws in the logic. Thank you.