Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-140745 Use URI (safer this way) #6161

Closed
wants to merge 2 commits into from

Conversation

jkappler
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@jkappler
Copy link
Author

ci:test:relevant

@jkappler
Copy link
Author

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 75f55a7604226e10d99e23fcc4262f5c0209a31c

Sender Branch:

Branch Name: LPS-140745
Branch GIT ID: 79513695ffe496a2d6a680be53b9b68233d57770

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 25 out of 27 jobs passed in 1 hour 42 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1327401_760

Base Branch:

Branch Name: master
Branch GIT ID: 75f55a7604226e10d99e23fcc4262f5c0209a31c

Upstream Comparison:

Branch GIT ID: 2c460a267949243af11c9f279a49d014a1f8621c
Jenkins Build URL: Acceptance Upstream DXP (master) #2457

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 25 out of 27 jobs PASSED
25 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1220 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=2 #9114
      1. com.liferay.layout.page.template.internal.model.listener.test.GroupModelListenerTest.testDeletingGroupDeletesFragmentEntryLinks
        com.liferay.portal.kernel.exception.NoSuchGroupException: No Group exists with the primary key 42715
        	at com.liferay.portal.service.persistence.impl.GroupPersistenceImpl.findByPrimaryKey(GroupPersistenceImpl.java:13565)
        	at com.liferay.portal.service.persistence.impl.GroupPersistenceImpl.findByPrimaryKey(GroupPersistenceImpl.java:13581)
        	at com.liferay.portal.service.impl.LayoutSetLocalServiceImpl.deleteLayoutSet(LayoutSetLocalServiceImpl.java:104)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.portal.service.impl.LayoutSetLocalServiceStagingAdvice$LayoutSetLocalServiceStagingInvocationHandler.invoke(LayoutSetLocalServiceStagingAdvice.java:124)
        	at com.sun.proxy.$Proxy76.deleteLayoutSet(Unknown Source)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.A...

For upstream results, click here.

@liferay-continuous-integration
Copy link
Collaborator

@Tim-Cao
Copy link

Tim-Cao commented Oct 18, 2021

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 24 out of 27 jobs passed in 1 hour 36 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0530ed44c1eb186650ef60a006e0e5f571595a52

Upstream Comparison:

Branch GIT ID: 0530ed44c1eb186650ef60a006e0e5f571595a52
Jenkins Build URL: Acceptance Upstream DXP (master) #2461

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 24 out of 27 jobs PASSED
24 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8/0
    Job Results:

    1 Test Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=1 #5259
         [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/json.data
           [echo] Copying /tmp/jenkins/test-1-28/test-portal-acceptance-pullrequest(master)/664/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=1/modules-unit-project-templates-jdk8/0/stop.properties to /opt/dev/projects/github/liferay-jenkins-ee/stop.properties.
           [copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee
           [echo] Copying /tmp/jenkins/test-1-28/test-portal-acceptance-pullrequest(master)/664/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=1/modules-unit-project-templates-jdk8/0/stop.properties.sh to /opt/dev/projects/github/liferay-jenkins-ee/stop.properties.sh.
           [copy] Warning: Could not find file /tmp/jenkins/test-1-28/test-portal-acceptance-pullrequest(master)/664/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=1/modules-unit-project-templates-jdk8/0/stop.properties.sh to copy.
         [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20211018173241978
           [exec] Result: 1
         [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20211018173241993
         [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20211018173242021
         [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20211018173242031
           [exec] HEAD is now at 3bf0e655 Fix portlet test to match className
           [exec] Already on '2.x'
           [exec] Already on '2.x'
           [exec] HEAD is now at 32fbdda8b FACES-3488 Support CDI beans annotated with @BridgeRequestScoped (TCK Tests - cleanup)
           [exec] Already on '4.x'
           [exec] Already on '4.x'
           [exec] HEAD is now at 868dd5a1 FACES-3622 Upgrade to version 4.3.0 of the Liferay Faces Bridge API dependency
           [exec] Already on '4.x'
           [exec] Already on '4.x'
           [exec] HEAD is now at 03d724af489a  LPS-140352 delete for now
           [exec] Already on 'master'
           [exec] Already on 'master'
           [exec] HEAD is now at 354004832f LRAC-9270 Extract operation to repository
           [exec] Already on '7.0.x'
           [exec] Already on '7.0.x'
           [exec] HEAD is now at 6d8ca841e LRAC-0 Add UTF8 to database connection url
           [exec] Already on '7.1.x'
           [exec] Already on '7.1.x'
           [exec] HEAD is now at 0b4e7dbe Zendesk Trigger Updates
           [exec] Already on 'master'
           [exec] Already on 'master'
      [stopwatch] [stop.current.job: 22.053 sec]
      

      BUILD SUCCESSFUL
      Total time: 23 seconds

      • echo 'Exit shell.'
        Exit shell.
        Finished: FAILURE

Failures in common with acceptance upstream results at 0530ed4:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1220 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=2 #9080
      1. com.liferay.layout.page.template.internal.model.listener.test.GroupModelListenerTest.testDeletingGroupDeletesFragmentEntryLinks
        com.liferay.portal.kernel.exception.NoSuchGroupException: No Group exists with the primary key 42635
        at com.liferay.portal.service.persistence.impl.GroupPersistenceImpl.findByPrimaryKey(GroupPersistenceImpl.java:13565)
        at com.liferay.portal.service.persistence.impl.GroupPersistenceImpl.findByPrimaryKey(GroupPersistenceImpl.java:13581)
        at com.liferay.portal.service.impl.LayoutSetLocalServiceImpl.deleteLayoutSet(LayoutSetLocalServiceImpl.java:104)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at com.liferay.portal.service.impl.LayoutSetLocalServiceStagingAdvice$LayoutSetLocalServiceStagingInvocationHandler.invoke(LayoutSetLocalServiceStagingAdvice.java:124)
        at com.sun.proxy.$Proxy76.deleteLayoutSet(Unknown Source)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        at com.liferay.portal.spring.aop.A...

@liferay-continuous-integration
Copy link
Collaborator

@Tim-Cao
Copy link

Tim-Cao commented Oct 19, 2021

ci:test:relevant

@Tim-Cao
Copy link

Tim-Cao commented Oct 19, 2021

Hi @jkappler, I did the following index test.

  1. Add a new site
  2. Enable local live
  3. Add a web content
  4. Add a content page
  5. Add a WCD widget
  6. Select the web content in WCD
  7. Publish page
  8. Add a widget page called Search
  9. Add a Search Results widget to search page
  10. Publish to Live
  11. Search common content in live site
  12. View the WC and content page are shown in Search Results
  13. Execute Reindex search indexes
  14. Search common content in live site
  15. View the WC and content page are shown in Search Results

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 27 out of 28 jobs passed in 2 hours

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7fb1a6c4e7d4d3d57484be94cfca239dade0a202

Upstream Comparison:

Branch GIT ID: 0530ed44c1eb186650ef60a006e0e5f571595a52
Jenkins Build URL: Acceptance Upstream DXP (master) #2461

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 26 out of 28 jobs PASSED
26 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 0530ed4:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1220 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=2 #10006
      1. com.liferay.layout.page.template.internal.model.listener.test.GroupModelListenerTest.testDeletingGroupDeletesFragmentEntryLinks
        com.liferay.portal.kernel.exception.NoSuchGroupException: No Group exists with the primary key 55981
        	at com.liferay.portal.service.persistence.impl.GroupPersistenceImpl.findByPrimaryKey(GroupPersistenceImpl.java:13565)
        	at com.liferay.portal.service.persistence.impl.GroupPersistenceImpl.findByPrimaryKey(GroupPersistenceImpl.java:13581)
        	at com.liferay.portal.service.impl.LayoutSetLocalServiceImpl.deleteLayoutSet(LayoutSetLocalServiceImpl.java:104)
        	at sun.reflect.GeneratedMethodAccessor818.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.portal.service.impl.LayoutSetLocalServiceStagingAdvice$LayoutSetLocalServiceStagingInvocationHandler.invoke(LayoutSetLocalServiceStagingAdvice.java:124)
        	at com.sun.proxy.$Proxy76.deleteLayoutSet(Unknown Source)
        	at sun.reflect.GeneratedMethodAccessor818.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.portal.service.ServiceContextAdvice.invoke(ServiceContextAdvice.java:60)
        	at com...

@liferay-continuous-integration
Copy link
Collaborator

@jkappler jkappler removed 🛑 On Hold Pull request is blocked and should not be forwarded. 🔍 QA Review Needed labels Oct 19, 2021
@jkappler
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#108746
Console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants