Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-157075 SF - Extract common code to assert the faviconURL #8685

Closed
wants to merge 135 commits into from
Closed

LPS-157075 SF - Extract common code to assert the faviconURL #8685

wants to merge 135 commits into from

Conversation

ealonso
Copy link
Collaborator

@ealonso ealonso commented Jun 28, 2022

No description provided.

@ealonso
Copy link
Collaborator Author

ealonso commented Jun 28, 2022

ci:forward

:octocat: Sent from GH.

@liferay-echo
Copy link
Owner

Thank you for submitting this PR. 👏

Make sure it follows the Echo Pull Request Template if you haven't already done so.

Learn more about it here.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@ealonso ealonso added the ✅ Ready to Merge Pull request is ready and can be forwarded. label Jun 28, 2022
@ealonso
Copy link
Collaborator Author

ealonso commented Jun 28, 2022

cc: @victorg1991

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 11724df470f8b261c94043e706e8a8f438a8e4c6

Sender Branch:

Branch Name: LPS-157075
Branch GIT ID: 3e0feb4f616eea095c6908b572c59ff634c088a4

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 24 out of 27 jobs passed

❌ ci:test:relevant - 96 out of 180 jobs passed in 1 hour 59 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 11724df470f8b261c94043e706e8a8f438a8e4c6

Upstream Comparison:

Branch GIT ID: 11724df470f8b261c94043e706e8a8f438a8e4c6
Jenkins Build URL: Acceptance Upstream DXP (master) #3466

ci:test:stable - 24 out of 27 jobs PASSED
24 Successful Jobs:
ci:test:relevant - 96 out of 180 jobs PASSED

84 Failed Jobs:

96 Successful Jobs:
For more details click here.

Failures unique to this pull:

  6. ...

@liferay-continuous-integration
Copy link
Collaborator

@ealonso
Copy link
Collaborator Author

ealonso commented Jun 28, 2022

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

@Tim-Cao
Copy link

Tim-Cao commented Jun 29, 2022

Hi @ealonso, would you mind updating the integration tests?

@Tim-Cao Tim-Cao added the 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. label Jun 29, 2022
@ealonso ealonso removed the 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. label Jun 29, 2022
@ealonso
Copy link
Collaborator Author

ealonso commented Jun 29, 2022

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 433ef97964499cee80d1c5f5282464eac23ffb96

Sender Branch:

Branch Name: LPS-157075
Branch GIT ID: 539d3fa4ee73fd8a54a6bee60d9545ac712a10d5

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 27 out of 27 jobs passed

✔️ ci:test:relevant - 174 out of 180 jobs passed in 1 hour 54 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 433ef97964499cee80d1c5f5282464eac23ffb96

Upstream Comparison:

Branch GIT ID: f28425a9e5d5cc9a25ac2f02cb08dae94e751450
Jenkins Build URL: Acceptance Upstream DXP (master) #3471

ci:test:stable - 27 out of 27 jobs PASSED
27 Successful Jobs:
ci:test:relevant - 173 out of 180 jobs PASSED
173 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at f28425a:
  1. functional-smoke-wildfly180-mariadb104-jdk8/0/0
        [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.304 sec
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.304 sec
    [junit] 
[stopwatch] [test.cmd: 0.772 sec]
[stopwatch] [run.batch.test.action: 20:00.549 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1657: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1661: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-wildfly.xml:26: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-wildfly.xml:36: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:14686: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:6974: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:7111: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:6974: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:7111: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:6974: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:7111: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:6974: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:7094: Server is still available at ${app.server.waiting.url}.
      [get] Getting: ${dependencies.url}/archive/test-1-21/test-portal-acceptance-pullrequest-downstream(master)/32209consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20220629061543450.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20220629061543450.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1606702267.properties
  2. central-requirements-jdk8/0/0
    1. com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles
      junit.framework.AssertionFailedError: Redundant dependency detected in modules/apps/static/portal-k8s-agent/portal-k8s-agent-impl/build.gradle expected:<compileOnly group: "com.liferay.portal", name: "com.liferay.portal.impl", version: "default"> but was:<testCompile group: "com.liferay.portal", name: "com.liferay.portal.impl", version: "default">
  at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1509)
  at com.liferay.portal.modules.ModulesStructureTest.access$800(ModulesStructureTest.java:68)
  at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:402)
  at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:376)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:374)
  4. modules-integration-mysql57-jdk8/0/6
    1. com.liferay.layout.type.controller.collection.internal.portlet.action.test.AddCollectionItemMVCActionCommandTest.testProcessAction
      java.lang.NullPointerException
  at com.liferay.layout.type.controller.collection.internal.portlet.action.test.AddCollectionItemMVCActionCommandTest.testProcessAction(AddCollectionItemMVCActionCommandTest.java:151)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:498)
  at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
  at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$...
    2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
      junit.framework.AssertionFailedError: 
null
java.lang.NullPointerException
  at com.liferay.portal.util.PortalImpl.getGroupFriendlyURL(PortalImpl.java:2512)
  at com.liferay.portal.util.PortalImpl.getLayoutFriendlyURL(PortalImpl.java:2804)
  at com.liferay.portal.kernel.util.PortalUtil.getLayoutFriendlyURL(PortalUtil.java:1037)
  at com.liferay.portlet.internal.PortletURLImpl.generateToString(PortletURLImpl.java:965)
  at com.liferay.portlet.internal.PortletURLImpl.toString(PortletURLImpl.java:881)
  at com.liferay.portlet.internal.RenderURLImpl.toString(RenderURLImpl.java:59)
  at com.liferay.portlet.documentlibrary.util.DLImpl.getEntryURL(DLImpl.java:846)
  at com.liferay.portlet.documentlibrary.util.DLImpl.startWorkflowInstance(DLImpl.java:769)
  at com.liferay.document.library.kernel.util.DLUtil.startWorkflowInstance(DLUtil.java:239)
  at com.liferay.document.library.internal.repository.capabilities.LiferayWorkflowCapability.addFileEntry(LiferayWorkflowCapability.java:68)
  at com.liferay.portal.repository.liferayrepository.LiferayWorkflowLocalRepositoryWrapper.addFileEntry(LiferayWorkflowLocalRepositoryWrapper.java:64)
  at com.liferay.portal.repository.capabilities.CapabilityLocalRepository.addFileEntry(CapabilityLocalRepository.java:63)
  at com.liferay.portlet.documentlibrary.service.impl.DLAppLocalServiceImpl.addFileEntry(DLAppLocalServiceImpl.java:274)
  at com.liferay.portlet.documentlibrary.service.impl.DLAppLocalServiceImpl.addFileEntry(DLAppLocalServiceImpl.java:207)
  at c...
  5. modules-integration-mysql57-jdk8/0/8
    1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
      junit.framework.AssertionFailedError: 
null
com.liferay.portal.kernel.exception.PortalException: Unable to search with filter ((customField/_43592_z7kX9UDI eq 'ZdeYC8Hm')) and (classPK eq '20127')
  at com.liferay.segments.internal.odata.search.ODataSearchAdapterImpl.searchCount(ODataSearchAdapterImpl.java:109)
  at com.liferay.segments.internal.odata.retriever.UserODataRetriever.getResultsCount(UserODataRetriever.java:69)
  at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.isMember(BaseSegmentsEntryProvider.java:293)
  at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.lambda$getSegmentsEntryIds$2(BaseSegmentsEntryProvider.java:160)
  at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174)
  at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175)
  at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
  at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
  at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
  at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:545)
  at java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
  at java.util.stream.LongPipeline.toArray(LongPipeline.java:484)
  at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.getSegmentsEntryIds(BaseSegmentsEntryProvider.java:164)
  at com.liferay.segments.internal.provider.SegmentsEntryProviderRegistryImpl.getS...
  6. ...

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#119597
Console

@liferay-continuous-integration
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success ✅ Ready to Merge Pull request is ready and can be forwarded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.