LPS-128444 #141

cleydyr · 2021-03-01T19:13:42Z

This is a revert for LPS-114936. LPS-114936 was supposed to fix a double request, but I couldn't reproduce the double request after all after reverting LPS-114936 by putting a breakpoint in com.liferay.dynamic.data.mapping.data.provider.internal.DDMDataProviderInvokerImpl#156

Also, limiting the maximum number of threads to 1 will cause any concurrent additional requests to be rejected, which is undesirable.

…k settings with jvm options extracted from archive

…are ERC

…ns, by default if the current language doesn't have a translation the default language is used

…ommand" This reverts commit c5b558f.

liferay-continuous-integration · 2021-03-01T19:13:47Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2021-03-01T19:17:26Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6d0946d8d69fb40dccd618decdee33da3be90490

Sender Branch:

Branch Name: LPS-128444
Branch GIT ID: 176614e54ce1e62236123acb56820ca1609fa5c5

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-03-01T20:55:07Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 25 out of 26 jobs passed in 1 hour 31 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6d0946d8d69fb40dccd618decdee33da3be90490

Upstream Comparison:

Branch GIT ID: 44a69fda45de6434bd9c01e993f84cf8ed3fb772
Jenkins Build URL: Acceptance Upstream DXP (master) #1590

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 24 out of 26 jobs PASSED

2 Failed Jobs:

24 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 44a69fd:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

1168 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=2,label_exp=!master #406079

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
com.liferay.portal.verify.VerifyException: com.liferay.commerce.currency.exception.NoSuchCurrencyException: No CommerceCurrency exists with the key {companyId=20101, code=USD}
com.liferay.portal.verify.VerifyException: com.liferay.commerce.currency.exception.NoSuchCurrencyException: No CommerceCurrency exists with the key {companyId=20101, code=USD}
	at com.liferay.portal.verify.VerifyProcess.verify(VerifyProcess.java:74)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands.executeVerifyProcesses(VerifyProcessTrackerOSGiCommands.java:294)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands$1.run(VerifyProcessTrackerOSGiCommands.java:346)
	at com.liferay.portal.output.stream.container.internal.OutputStreamContainerFactoryTrackerImpl.runWithSwappedLog(OutputStreamContainerFactoryTrackerImpl.java:134)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands.executeVerifyProcesses(VerifyProcessTrackerOSGiCommands.java:341)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands._execute(VerifyProcessTrackerOSGiCommands.java:395)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands.access$200(VerifyProcessTrackerOSGiCommands.java:80)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands$VerifyServic...

liferay-continuous-integration · 2021-03-01T21:48:44Z

Jenkins Build:test-portal-source-format#2711
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-forms#141
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - cleydyr > liferay-forms - PR#141 - 2021-03-01[11:14:17]
Spira Jenkins Build:publish-spira-report#20689

liferay-continuous-integration · 2021-03-02T00:20:49Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#3993
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-forms#141
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - cleydyr > liferay-forms - PR#141 - 2021-03-01[11:23:24]
Spira Jenkins Build:publish-spira-report#20699

natocesarrego · 2021-03-02T17:54:53Z

Hi @cleydyr,

Your fix makes sense to me, although I'm afraid that this pull can reintroduce the issue reported on LPS-114936. 😬 Do you mind to talk to Lino in order to find out the steps he has performed to reproduce the LPS-114936?

Thanks in advance.

cleydyr · 2021-03-02T18:04:10Z

Sure, Renatonho. I'd already talked to @linolaoj via Slack. He said it was no problem to revert his commit.

cleydyr · 2021-03-02T21:15:27Z

@natocesarrego, I couldn't reproduce it at all, as I stated in the initial comment for this issue. So maybe it was just a delay in the logs that presented two messages within a short period of time, but not due to two different requests. Or something changed on the frontend logic that made the source of double requests to disappear.

natocesarrego · 2021-03-03T19:30:05Z

Ok, @cleydyr. Thanks for reaching out Lino. I'll forward your pull right now. 😉

natocesarrego · 2021-03-03T19:30:32Z

ci:forward

liferay-continuous-integration · 2021-03-03T19:30:36Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-03-03T19:30:37Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2021-03-03T19:31:28Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2021-03-03T19:31:46Z

Pull request has been successfully forwarded to brianchandotcom#99472

Igor Beslic and others added 30 commits February 28, 2021 22:07

COMMERCE-5303 dispatch-talend-web - TEST - test JVM options

da626a2

COMMERCE-5303 dispatch-talend-web - support to detect JVM OPTIONS

bc57070

COMMERCE-5303 dispatch-talend-web - expose as constant

dc394db

COMMERCE-5303 dispatch-talend-web - automatically update dispatch tas…

1906f0c

…k settings with jvm options extracted from archive

COMMERCE-5303 rename

a082ced

COMMERCE-5303 rename

7bfaab1

COMMERCE-5303 SF

21732d4

COMMERCE-5303 Sort

4183e04

COMMERCE-5303 treat it like a request parameter

89ac7c6

COMMERCE-5303 rename

36a421f

COMMERCE-5303 sort

48e072d

COMMERCE-5303 reuse

711ce7d

COMMERCE-5303 sort

bb7ac09

COMMERCE-5303 these are not java.nio.file.Path

555e19c

COMMERCE-5303 rename

779a840

COMMERCE-5303 rename

73752af

COMMERCE-5303 these are not java.nio.file.Path

0793735

COMMERCE-5303 SF

5176002

COMMERCE-5788 Update externalReferenceCode for commerce-price-list

ce03f19

COMMERCE-5788 Update exteralReferenceCode for commerce-pricing

86c6f5a

COMMERCE-5788 Update externalReferenceCode for commerce-product-service

97ba6a1

COMMERCE-5788 Update externalReferencCode for commerce-service

366f421

COMMERCE-5788 Document breaking changes

328bb99

COMMERCE-5788 Regen

7285aaf

COMMERCE-5788 Baseline

a7e5e5d

COMMERCE-5767 headless-commerce-admin-account use right method to upd…

b708f4b

…are ERC

COMMERCE-5767 headless-commerce-admin-account fixed nested fields

3566a6d

LPS-127985 No need to copy the default language to all the translatio…

bfb5631

…ns, by default if the current language doesn't have a translation the default language is used

COMMERCE-5721 Fix minium login page's web content

f55c339

LPS-128040 Add javax.annotations-api for jdk11 support

119918c

victorg1991 and others added 3 commits March 1, 2021 12:32

LPS-127639 Remove not needed

912400c

LPS-127639 Remove usage of normalizeFriendlyURL in event names

44a69fd

LPS-128444 Revert "LPS-114936 limiting number of threads for hystix c…

176614e

…ommand" This reverts commit c5b558f.

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Mar 1, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Mar 1, 2021

natocesarrego added the pending-sender label Mar 2, 2021

natocesarrego removed the pending-sender label Mar 3, 2021

liferay-continuous-integration mentioned this pull request Mar 3, 2021

LPS-128444 brianchandotcom/liferay-portal#99472

Closed

liferay-continuous-integration closed this Mar 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-128444 #141

LPS-128444 #141

cleydyr commented Mar 1, 2021

liferay-continuous-integration commented Mar 1, 2021

liferay-continuous-integration commented Mar 1, 2021

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Mar 1, 2021

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Mar 1, 2021

liferay-continuous-integration commented Mar 2, 2021

natocesarrego commented Mar 2, 2021

cleydyr commented Mar 2, 2021

cleydyr commented Mar 2, 2021

natocesarrego commented Mar 3, 2021

natocesarrego commented Mar 3, 2021

liferay-continuous-integration commented Mar 3, 2021

liferay-continuous-integration commented Mar 3, 2021

liferay-continuous-integration commented Mar 3, 2021

liferay-continuous-integration commented Mar 3, 2021

LPS-128444 #141

LPS-128444 #141

Conversation

cleydyr commented Mar 1, 2021

liferay-continuous-integration commented Mar 1, 2021

liferay-continuous-integration commented Mar 1, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Mar 1, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 25 out of 26 jobs passed in 1 hour 31 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Mar 1, 2021

liferay-continuous-integration commented Mar 2, 2021

natocesarrego commented Mar 2, 2021

cleydyr commented Mar 2, 2021

cleydyr commented Mar 2, 2021

natocesarrego commented Mar 3, 2021

natocesarrego commented Mar 3, 2021

liferay-continuous-integration commented Mar 3, 2021

liferay-continuous-integration commented Mar 3, 2021

liferay-continuous-integration commented Mar 3, 2021

liferay-continuous-integration commented Mar 3, 2021