[TS] LPS-148820 | Can't select a page from the staging environment in link to page selector DDMForms #1534

bakayattila · 2022-03-16T15:53:11Z

Related Issue: https://issues.liferay.com/browse/LPS-148820

Hi Team,
Could you please review this pull request?

https://issues.liferay.com/browse/LPS-148820
Thank you!

I tried to fix it without breaking LPS-135851 or LPS-88009.

liferay-forms · 2022-03-16T16:12:51Z

Hi, you don’t need to run the CI commands anymore, I’ll do it for you and let you know if any issue happens.

liferay-forms · 2022-03-16T16:12:51Z

ci:test:sf

liferay-continuous-integration · 2022-03-16T16:12:53Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

liferay-continuous-integration · 2022-03-16T16:35:51Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ef6342842425dd2ae9e74e9afdfdbd3dfe9b2b5f

Sender Branch:

Branch Name: LPS-148820
Branch GIT ID: 9105ce82344d3347b70e7c91bc2a6a955fcfcafe

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2022-03-16T16:38:58Z

Jenkins Build:test-portal-source-format#2075

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-forms#1534

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - bakayattila > liferay-forms - PR#1534 - 2022-03-16[09:32:55]

Testray Importer:publish-testray-report#7733

liferay-forms · 2022-03-16T16:48:50Z

ci:test:relevant

liferay-continuous-integration · 2022-03-16T19:46:06Z

✔️ ci:test:stable - 30 out of 32 jobs passed

✔️ ci:test:relevant - 31 out of 33 jobs passed in 2 hours 38 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ef6342842425dd2ae9e74e9afdfdbd3dfe9b2b5f

Upstream Comparison:

Branch GIT ID: ef6342842425dd2ae9e74e9afdfdbd3dfe9b2b5f
Jenkins Build URL: Acceptance Upstream DXP (master) #3038

ci:test:stable - 30 out of 32 jobs PASSED

2 Failed Jobs:

30 Successful Jobs:

ci:test:relevant - 30 out of 33 jobs PASSED

3 Failed Jobs:

30 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at ef63428:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #28368

Startup error: Unresolved Requirement(s)

  [waitfor]   at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) [catalina.jar:9.0.56]
  [waitfor]   at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) [catalina.jar:9.0.56]
  [waitfor]   at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78) [catalina.jar:9.0.56]
  [waitfor]   at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357) [catalina.jar:9.0.56]
  [waitfor]   at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:382) [tomcat-coyote.jar:9.0.56]
  [waitfor]   at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65) [tomcat-coyote.jar:9.0.56]
  [waitfor]   at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895) [tomcat-coyote.jar:9.0.56]
  [waitfor]   at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1732) [tomcat-coyote.jar:9.0.56]
  [waitfor]   at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat-coyote.jar:9.0.56]
  [waitfor]   at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191) [tomcat-util.jar:9.0.56]
  [waitfor]   at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659) [tomcat-util.jar:9.0.56]
  [waitfor]   at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-util.jar:9.0.56]
  [waitfor]   at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121]
  [waitfor] Caused by: java.lang.NullPointerException
  [waitfor]   at com.liferay.portal.events.ServicePreAction._initThemeDisplay(ServicePreAction.java:1342) ~[portal-impl.jar:?]
  [waitfor]   at com.liferay.portal.events.ServicePreAction.servicePre(ServicePreAction.java:173) ~[portal-impl.jar:?]
  [waitfor]   at com.liferay.portal.events.ServicePreAction.run(ServicePreAction.java:154) ~[portal-impl.jar:?]
  [waitfor]   ... 150 more
  [waitfor] 2022-03-16 19:14:38.794 ERROR [http-nio-8080-exec-2][error_jsp:563] User ID null
  [waitfor] 2022-03-16 19:14:38.795 ERROR [http-nio-8080-exec-2][error_jsp:564] Current URL /web/guest
  [waitfor] 2022-03-16 19:14:38.795 ERROR [http-nio-8080-exec-2][error_jsp:565] Referer null
  [waitfor] 2022-03-16 19:14:38.795 ERROR [http-nio-8080-exec-2][error_jsp:566] Remote address 127.0.0.1
  [waitfor] 2022-03-16 19:14:38.795 ERROR [http-nio-8080-exec-2][error_jsp:574] Exception is null

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

2972 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=6 #34839

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
JSON storage adapter is deprecated, using default storage adapter
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

liferay-continuous-integration · 2022-03-16T19:57:39Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#687

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-forms#1534

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - bakayattila > liferay-forms - PR#1534 - 2022-03-16[10:06:51]

Testray Importer:publish-testray-report#1694

rodrigopaulino

Hey, @bakayattila.

Thanks for your PR. Could you please explain this logic?
Looking at the bug, it seems to me that just assigning the scopeGroupId to groupId would fix the problem. Would it work for you and the other cases?

Regards.

bakayattila · 2022-03-17T07:59:30Z

Hi @rodrigopaulino,
If I only use the scopegroupId I would cause a regression on LPS-88009, and if I would revert the changes to the state LPS-88009 left it I would cause a regression on LPS-135851. So I tried to force the solution on LPS-88009 to only work when staging is turned on. To detect that I compare the groupId with the getGroupOrLiveGroupId as the second will always return the live site if staging is turned on.

rodrigopaulino

Thanks for clarifying, @bakayattila. I understand your logic now, although I believe the fix for LPS-88009 wasn't working all along:
It attempted to solve the bug at publication by inferring another groupId at selection. If the problem was that links to pages weren't pointing to the correct site after publication, the record values should have been updated to the correct site during publication.
For LPS-135851, I don't understand why they used the getScopeGroupIdOrLiveGroupId. I assume they were trying to fix their problem of not having the scope groupId while not breaking the expected behavior on LPS-88009 which involved the links pointing to the live site at the final step.
Nevertheless, the correct behavior is to have the scope groupId to list its respective pages in this type of field. If you intend to fix LPS-88009 in this PR, I encourage you to seek for solution during publication in order to swap the staging site for the live site at the stored records.
Does this make sense?
Let me know anything. 😃

bakayattila · 2022-03-17T21:37:16Z

Hi @rodrigopaulino,
I think you misunderstud LPS-88009. The use case on the LPS was the following turn on staging without enabling it on web contents and try to select a layout from the staging environment. In this use case, you can select the staging pages and the link to page will point to the staging version. As we did not stage the web contents there is no publication or export-import involved in this use case. Any changes made to the web content will be visible on the live site immediately because the web contents only exist in the scope of the live site but you can access them in the staging environment.

rodrigopaulino · 2022-03-18T16:35:49Z

Hey, @bakayattila.

Once again, thanks for reminding me about the Web Content stage condition in LPS-88009.
What do you think of checking if the portlet is staged, then deciding which groupId to use?
I mean, if portlet (Web Content, DDL etc) is staged, then get the scope groupId. Else, get always the live groupId.
Does that make sense now?

To check if a portlet is staged or not, I believe you could introduce to frontend's Liferay.ThemeDisplay at top_js.jsps a function called isStagedPortlet(plid), for example, which could be something like this:

isStagedPortlet: function(plid) {
    UnicodeProperties groupTypeSettings = group.getTypeSettingsProperties();
    
    return '<%= GetterUtil.getBoolean(groupTypeSettings.getProperty(StagingConstants.STAGED_PORTLET + plid)) %>';
}

And for the logic inside ddm_form, you could create a function and reuse it on all different places where it's needed to avoid duplicating code.
What do you think?

bakayattila · 2022-03-18T16:41:15Z

Hey, @bakayattila.

Once again, thanks for reminding me about the Web Content stage condition in LPS-88009. What do you think of checking if the portlet is staged, then deciding which groupId to use? I mean, if portlet (Web Content, DDL etc) is staged, then get the scope groupId. Else, get always the live groupId. Does that make sense now?

To check if a portlet is staged or not, I believe you could introduce to frontend's Liferay.ThemeDisplay at top_js.jsps a function called isStagedPortlet(plid), for example, which could be something like this:
isStagedPortlet: function(plid) {
    UnicodeProperties groupTypeSettings = group.getTypeSettingsProperties();
    
    return '<%= GetterUtil.getBoolean(groupTypeSettings.getProperty(StagingConstants.STAGED_PORTLET + plid)) %>';
}
And for the logic inside ddm_form, you could create a function and reuse it on all different places where it's needed to avoid duplicating code. What do you think?

I also thought that the problem with this idea is that you can edit the dynamic data list from the content > dynamic data list and from the dynamic data list display widget and the latter one will always show it's staged even if you don't stage the dynamic data lists.

rodrigopaulino · 2022-03-18T17:14:55Z

@bakayattila, could you please explain why would it "always show it's staged even if you don't stage the dynamic data lists"? I'm sorry I didn't quite get the rationale.
Btw, the code I shared above won't work like that, but I hope you get the idea. :)

bakayattila · 2022-03-21T09:28:27Z

@rodrigopaulino, You can edit the dynamic data list from two locations. the dynamic data list portlet and from the dynamic data list display portlet. If I remember right even if we don't stage the dynamic data lists the dynamic data list display portlet will show that it is staged probably because it is on a layout that is staged.

rodrigopaulino · 2022-03-21T12:42:41Z

Hey, @bakayattila. The UnicodeProperties (TypeSettingsProperties) of a group contains the site's staging configuration. If you create a staged environment and disable staging for a certain content, then the TypeSettingsProperties will contain that information independently from the page you're visiting.

liferay-continuous-integration · 2022-04-01T10:07:14Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b2fde097c2a23b9dc3e508874f2b32a04bab25c7

Sender Branch:

Branch Name: LPS-148820
Branch GIT ID: ed9eb590904b608c140333e49ea7b2471e36c668

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-forms · 2022-04-01T10:07:15Z

ci:test:relevant

liferay-continuous-integration · 2022-04-01T10:09:51Z

Jenkins Build:test-portal-source-format#6257

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-forms#1534

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - bakayattila > liferay-forms - PR#1534 - 2022-04-01[03:01:03]

Testray Importer:publish-testray-report#2405

liferay-continuous-integration · 2022-04-01T11:58:16Z

❌ ci:test:stable - 30 out of 33 jobs passed

❌ ci:test:relevant - 30 out of 34 jobs passed in 1 hour 50 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b2fde097c2a23b9dc3e508874f2b32a04bab25c7

Upstream Comparison:

Branch GIT ID: b2fde097c2a23b9dc3e508874f2b32a04bab25c7
Jenkins Build URL: Acceptance Upstream DXP (master) #3085

ci:test:stable - 30 out of 33 jobs PASSED

3 Failed Jobs:

30 Successful Jobs:

ci:test:relevant - 30 out of 34 jobs PASSED

4 Failed Jobs:

30 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/4

Job Results:

24 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=6 #19774

     [echo] ##
     [echo] 
[beanshell] 2022-04-01 04:25:36
[beanshell] Full thread dump Java HotSpot(TM) 64-Bit Server VM (25.121-b13 mixed mode):
[beanshell] 
[beanshell] "Attach Listener" #37 daemon prio=9 os_prio=0 tid=0x00007fbda4001000 nid=0x2eb671 waiting on condition [0x0000000000000000]
[beanshell]    java.lang.Thread.State: RUNNABLE
[beanshell] 
[beanshell]    Locked ownable synchronizers:
[beanshell]   - None
[beanshell] 
[beanshell] "http-nio-8080-exec-10" #36 daemon prio=5 os_prio=0 tid=0x00007fbd64011000 nid=0x2eb4fd waiting on condition [0x00007fbd4befd000]
[beanshell] 
   [delete] Deleting: /tmp/Bootstrap__3060918.log
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/jps_output
[stopwatch] [run.batch.test.action: 33:37.705 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1656: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1660: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:39: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:51: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:13919: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:14284: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4737: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4820: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:5833: No server is available at http://localhost:8080/web/guest
      [get] Getting: ${dependencies.url}/archive/test-1-36/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=6/19774consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20220401042538057.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20220401042538057.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null110823964.properties

Failures in common with acceptance upstream results at b2fde09:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-wildfly180-mariadb104-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #42833

    [junit]   at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
    [junit]   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
    [junit]   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
    [junit]   at sun.nio.fs.UnixFileSystemProvider.newDirectoryStream(UnixFileSystemProvider.java:427)
    [junit]   at java.nio.file.Files.newDirectoryStream(Files.java:525)
    [junit]   at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog(PortalLogAssertorTest.java:62)
    [junit] 
    [junit] 
    [junit] Test com.liferay.portal.log.assertor.PortalLogAssertorTest FAILED
[stopwatch] [test.cmd: 0.523 sec]
[stopwatch] [run.batch.test.action: 31:18.029 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1656: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1660: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-wildfly.xml:26: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-wildfly.xml:36: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:13919: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:14284: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4737: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4820: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:5833: No server is available at http://localhost:8080/web/guest
      [get] Getting: http://test-1-28/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0/42833//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20220401042245682.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20220401042245682.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null313986708.properties

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

3219 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=6 #17115

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
JSON storage adapter is deprecated, using default storage adapter
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

AXIS_VARIABLE=7 #17115

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
The data provider was not able to connect to the web service. Unable to transmit request to localhost
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

liferay-forms · 2022-04-01T11:58:18Z

Hey @bakayattila, can you please check if these failures are related to your changes? Thanks

liferay-continuous-integration · 2022-04-01T12:02:39Z

✔️ ci:test:stable - 31 out of 33 jobs passed

✔️ ci:test:relevant - 32 out of 34 jobs passed in 2 hours 1 minute

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b2fde097c2a23b9dc3e508874f2b32a04bab25c7

Upstream Comparison:

Branch GIT ID: b2fde097c2a23b9dc3e508874f2b32a04bab25c7
Jenkins Build URL: Acceptance Upstream DXP (master) #3085

ci:test:stable - 31 out of 33 jobs PASSED

2 Failed Jobs:

31 Successful Jobs:

ci:test:relevant - 31 out of 34 jobs PASSED

3 Failed Jobs:

31 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at b2fde09:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-wildfly180-mariadb104-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #430918

    [junit]   at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
    [junit]   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
    [junit]   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
    [junit]   at sun.nio.fs.UnixFileSystemProvider.newDirectoryStream(UnixFileSystemProvider.java:427)
    [junit]   at java.nio.file.Files.newDirectoryStream(Files.java:525)
    [junit]   at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog(PortalLogAssertorTest.java:62)
    [junit] 
    [junit] 
    [junit] Test com.liferay.portal.log.assertor.PortalLogAssertorTest FAILED
[stopwatch] [test.cmd: 0.696 sec]
[stopwatch] [run.batch.test.action: 31:16.065 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1656: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1660: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-wildfly.xml:26: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-wildfly.xml:36: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:13919: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:14284: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4737: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4820: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:5833: No server is available at http://localhost:8080/web/guest
      [get] Getting: ${dependencies.url}/archive/test-1-21/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0/430918consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20220401042546694.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20220401042546694.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null856042367.properties

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

3219 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=6 #39762

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
JSON storage adapter is deprecated, using default storage adapter
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

AXIS_VARIABLE=7 #39762

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
The data provider was not able to connect to the web service. Unable to transmit request to localhost
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

liferay-continuous-integration · 2022-04-01T12:09:24Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#857

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-forms#1534

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - bakayattila > liferay-forms - PR#1534 - 2022-04-01[03:00:56]

Testray Importer:publish-testray-report#2013

rodrigopaulino

LGTM 🎉

rodrigopaulino · 2022-04-01T13:11:44Z

ci:forward

liferay-continuous-integration · 2022-04-01T13:11:52Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2022-04-01T13:11:53Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2022-04-01T13:13:07Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2022-04-01T13:13:22Z

Pull request has been successfully forwarded to brianchandotcom#115591
Console

liferay-forms added the Technical Support label Mar 16, 2022

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Mar 16, 2022

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending labels Mar 16, 2022

rodrigopaulino self-requested a review March 16, 2022 18:51

rodrigopaulino self-assigned this Mar 16, 2022

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Mar 16, 2022

rodrigopaulino reviewed Mar 16, 2022

View reviewed changes

rodrigopaulino added the Author Action Required Changes/Questions were requested by the reviewer label Mar 16, 2022

rodrigopaulino suggested changes Mar 17, 2022

View reviewed changes

liferay-continuous-integration added the ci:test:sf - success label Apr 1, 2022

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending and removed ci:test:relevant - pending ci:test:stable - pending labels Apr 1, 2022

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Apr 1, 2022

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - failure labels Apr 1, 2022

rodrigopaulino approved these changes Apr 1, 2022

View reviewed changes

rodrigopaulino added Good to Go and removed Author Action Required Changes/Questions were requested by the reviewer labels Apr 1, 2022

liferay-continuous-integration mentioned this pull request Apr 1, 2022

[TS] LPS-148820 | Can't select a page from the staging environment in link to page selector DDMForms brianchandotcom/liferay-portal#115591

Closed

liferay-continuous-integration closed this Apr 1, 2022

[TS] LPS-148820 | Can't select a page from the staging environment in link to page selector DDMForms #1534

[TS] LPS-148820 | Can't select a page from the staging environment in link to page selector DDMForms #1534

Conversation

bakayattila commented Mar 16, 2022 • edited by liferay-forms Loading

liferay-forms commented Mar 16, 2022

liferay-forms commented Mar 16, 2022

liferay-continuous-integration commented Mar 16, 2022

liferay-continuous-integration commented Mar 16, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Mar 16, 2022

liferay-forms commented Mar 16, 2022

liferay-continuous-integration commented Mar 16, 2022

✔️ ci:test:stable - 30 out of 32 jobs passed

✔️ ci:test:relevant - 31 out of 33 jobs passed in 2 hours 38 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

3 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Mar 16, 2022

rodrigopaulino left a comment

Choose a reason for hiding this comment

bakayattila commented Mar 17, 2022

rodrigopaulino left a comment • edited Loading

Choose a reason for hiding this comment

bakayattila commented Mar 17, 2022 • edited Loading

rodrigopaulino commented Mar 18, 2022 • edited Loading

bakayattila commented Mar 18, 2022

rodrigopaulino commented Mar 18, 2022 • edited Loading

bakayattila commented Mar 21, 2022

rodrigopaulino commented Mar 21, 2022

liferay-continuous-integration commented Apr 1, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-forms commented Apr 1, 2022

liferay-continuous-integration commented Apr 1, 2022

liferay-continuous-integration commented Apr 1, 2022

❌ ci:test:stable - 30 out of 33 jobs passed

❌ ci:test:relevant - 30 out of 34 jobs passed in 1 hour 50 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/4

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-wildfly180-mariadb104-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-forms commented Apr 1, 2022

liferay-continuous-integration commented Apr 1, 2022

✔️ ci:test:stable - 31 out of 33 jobs passed

✔️ ci:test:relevant - 32 out of 34 jobs passed in 2 hours 1 minute

Base Branch:

Upstream Comparison:

2 Failed Jobs:

3 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-wildfly180-mariadb104-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Apr 1, 2022

rodrigopaulino left a comment

Choose a reason for hiding this comment

rodrigopaulino commented Apr 1, 2022

liferay-continuous-integration commented Apr 1, 2022

bakayattila commented Mar 16, 2022 •

edited by liferay-forms

Loading

rodrigopaulino left a comment •

edited

Loading

bakayattila commented Mar 17, 2022 •

edited

Loading

rodrigopaulino commented Mar 18, 2022 •

edited

Loading

rodrigopaulino commented Mar 18, 2022 •

edited

Loading