LPS-131271 It's not possible to edit a field with options in the fieldset modal #196

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1137401_5877

Base Branch:

Branch Name: master
Branch GIT ID: 648105cf63932af9173a603bb43e553b7d7793df

Upstream Comparison:

Branch GIT ID: 318146d8babd408ff5f16b93b0e04428cbf3241f
Jenkins Build URL: Acceptance Upstream DXP (master) #1818

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 24 out of 26 jobs PASSED

2 Failed Jobs:

24 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #473733

     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:portal-remote:portal-remote-jaxrs-whiteboard:deployDependencies'.
     [exec] > Could not resolve all files for configuration ':apps:portal-remote:portal-remote-jaxrs-whiteboard:compileOnly'.
     [exec]    > Could not resolve org.apache.cxf:cxf-tools-validator:3.2.14.
     [exec]      Required by:
     [exec]          project :apps:portal-remote:portal-remote-jaxrs-whiteboard
     [exec]       > Could not resolve org.apache.cxf:cxf-tools-validator:3.2.14.
     [exec]          > Could not get resource 'https://repository-cdn.liferay.com/nexus/content/groups/public/org/apache/cxf/cxf-tools-validator/3.2.14/cxf-tools-validator-3.2.14.pom'.
     [exec]             > Could not HEAD 'https://repository-cdn.liferay.com/nexus/content/groups/public/org/apache/cxf/cxf-tools-validator/3.2.14/cxf-tools-validator-3.2.14.pom'.
     [exec]                > Connect to repository-cdn.liferay.com:443 [repository-cdn.liferay.com/10.0.0.99] failed: connect timed out
     [exec] 
     [exec] * Try:
     [exec] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Get more help at https://help.gradle.org
     [exec] 
     [exec] BUILD FAILED in 2m 15s
     [exec] Result: 1
[stopwatch] [run.batch.test.action: 5:06.046 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1878: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/modules/build-app.xml:219: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/modules/build-app.xml:258: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/modules/build-app.xml:445: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/modules/build-app-module.xml:483: /opt/dev/projects/github/liferay-portal/modules/apps/portal-remote/portal-remote-jaxrs-whiteboard/tmp/deployDependencies358678127 does not exist.

For upstream results, click here.

liferay-continuous-integration · 2021-04-30T23:01:36Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#5877

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-forms#196

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - miltonmc > liferay-forms - PR#196 - 2021-04-30[13:43:52]

Testray Importer:publish-testray-report#611

liferay-continuous-integration · 2021-04-30T23:04:47Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 25 out of 26 jobs passed in 2 hours 13 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 648105cf63932af9173a603bb43e553b7d7793df

Upstream Comparison:

Branch GIT ID: 318146d8babd408ff5f16b93b0e04428cbf3241f
Jenkins Build URL: Acceptance Upstream DXP (master) #1818

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 24 out of 26 jobs PASSED

2 Failed Jobs:

24 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 318146d:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

2 Tests Passed.
3 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #473756

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: 
Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1619821413266.log:
!SESSION 2021-04-30 22:23:55.261 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_121
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
!ENTRY com.liferay.portal.vulcan.impl 4 0 2021-04-30 22:23:55.261

!MESSAGE FrameworkEvent ERROR

!STACK 0

org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.vulcan.impl [1114]

Unresolved requirement: Import-Package: com.liferay.object.graphql; version="[1.0.0,2.0.0)"
at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)


at com.liferay.portal.lo...</code></pre></div></li><li><div><a href="https://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/473756//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanXMLLog">com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog</a><pre><code>junit.framework.AssertionFailedError: 

FrameworkEvent ERROR

org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.vulcan.impl [1114]

Unresolved requirement: Import-Package: com.liferay.object.graphql; version="[1.0.0,2.0.0)"
at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
at java.nio.file.Files.walkFileTree(Files.java:2670)
at java.nio.file.Files.walkFileTree(Files.java:2742)
at com.liferay.portal.log.assertor.P...</code></pre></div></li><li><div><a href="https://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/473756//testReport/com.liferay.poshi.runner/PoshiRunner/test_LocalFile_PortalSmoke_Smoke_">LocalFile.PortalSmoke#Smoke</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-04/test-1-19/test-portal-acceptance-pullrequest(master)/8242/lpkg-base-jdk8/0/0/LocalFile.PortalSmoke_Smoke/index.html.gz">Poshi Report</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-04/test-1-19/test-portal-acceptance-pullrequest(master)/8242/lpkg-base-jdk8/0/0/LocalFile.PortalSmoke_Smoke/summary.html.gz">Poshi Summary</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-04/test-1-19/test-portal-acceptance-pullrequest(master)/8242/lpkg-base-jdk8/0/0/jenkins-console.txt.gz">Console Output</a></div></li></ol></div></li></ol></div></li></ol></details></details></html>

liferay-continuous-integration · 2021-04-30T23:09:46Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#8242

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-forms#196

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - miltonmc > liferay-forms - PR#196 - 2021-04-30[13:50:37]

Testray Importer:publish-testray-report#669

interaminense · 2021-05-03T14:50:12Z

...resources/data_layout_builder/js/components/field-sets/actions/getFieldsWithoutOptions.es.js

+			case FIELD_TYPES.radio:
+			case FIELD_TYPES.checkboxMultiple:


Could we remove these case, since we are not using?

Actually these cases are behaving the same as the case FIELD_TYPES.select

more info

interaminense

@miltonmc, Just one question about it

miltonmc · 2021-05-03T19:33:28Z

ci:forward

liferay-continuous-integration · 2021-05-03T19:33:32Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-05-03T19:33:33Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2021-05-03T19:34:32Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2021-05-03T19:34:47Z

Pull request has been successfully forwarded to brianchandotcom#101359
Console

liferay-continuous-integration added the ci:test:sf - pending label Apr 30, 2021

miltonmc force-pushed the LPS-131271 branch from da56b02 to ec82989 Compare April 30, 2021 20:45

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - pending labels Apr 30, 2021

LPS-131271 It's not possible to edit a field with options in the fiel…

8a7119f

…dset modal - https://issues.liferay.com/browse/LPS-131271 Co-authored-by: Aline D'Oleron <aline.cantarelli@liferay.com>

miltonmc force-pushed the LPS-131271 branch from ec82989 to 8a7119f Compare April 30, 2021 20:49

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Apr 30, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending and removed ci:test:relevant - pending ci:test:stable - pending labels Apr 30, 2021

miltonmc mentioned this pull request Apr 30, 2021

LPS-130483 Remove the Feature Flag #197

Closed

6 tasks

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Apr 30, 2021

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - success labels Apr 30, 2021

miltonmc requested a review from interaminense May 3, 2021 12:19

interaminense reviewed May 3, 2021

View reviewed changes

liferay-continuous-integration mentioned this pull request May 3, 2021

LPS-131271 It's not possible to edit a field with options in the fieldset modal brianchandotcom/liferay-portal#101359

Closed

liferay-continuous-integration closed this May 3, 2021

miltonmc deleted the LPS-131271 branch May 4, 2021 13:15

interaminense mentioned this pull request May 5, 2021

LPS-130483 Remove the Feature Flag #205

Closed

6 tasks

LPS-131271 It's not possible to edit a field with options in the fieldset modal #196

LPS-131271 It's not possible to edit a field with options in the fieldset modal #196

Conversation

miltonmc commented Apr 30, 2021

liferay-continuous-integration commented Apr 30, 2021

miltonmc commented Apr 30, 2021

liferay-continuous-integration commented Apr 30, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Apr 30, 2021

miltonmc commented Apr 30, 2021

miltonmc commented Apr 30, 2021

liferay-continuous-integration commented Apr 30, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Apr 30, 2021

liferay-continuous-integration commented Apr 30, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 24 out of 26 jobs passed in 2 hours

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

For upstream results, click here.

liferay-continuous-integration commented Apr 30, 2021

liferay-continuous-integration commented Apr 30, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 25 out of 26 jobs passed in 2 hours 13 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

liferay-continuous-integration commented Apr 30, 2021

interaminense May 3, 2021 • edited Loading

Choose a reason for hiding this comment

miltonmc May 3, 2021

Choose a reason for hiding this comment

interaminense left a comment

Choose a reason for hiding this comment

miltonmc commented May 3, 2021

liferay-continuous-integration commented May 3, 2021

liferay-continuous-integration commented May 3, 2021

liferay-continuous-integration commented May 3, 2021

liferay-continuous-integration commented May 3, 2021

interaminense May 3, 2021 •

edited

Loading