LPS-131654 Intermediate pages in page-iterator do not update when SPA is enabled #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-134423 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#2055 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#1205 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#6109 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#2242 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#1205 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - holatuwol > liferay-frontend - PR#1205 - 2021-06-29[23:35:41] Testray Importer:publish-testray-report#6114 |
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites: |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#103815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
Expected behavior is that now that it's 60 results per page, we should see 17 pages. Actual behavior is that we still see 50 pages.
Solution notes
Originally I fixed it only for documents and media's search, rather than the normal search portlet, and I (incorrectly) assumed that the same fix would work in both places. However, since the search results portlet is instanceable, the solution for the documents and media portlet didn't work for the search results portlet.