LPS-117468 Uses moono-lisa skin #175

jbalsas · 2020-07-28T08:26:59Z

By default, liferay-ckeditor now uses the moono-lexicon skin that better matches DXP's look and feel. That skin, however, is not meant to be used with AlloyEditor and introduces some conflicting styling.

This PR changes the skin used inside PageEditor AlloyEditor instances back to moono-lisa.

To test:

Launch a clean installation of DXP
Click the pencil icon to edit the home page (with the Hello World widget in it)
Double click on the "Hello World" text to activate AlloyEditor
Verify that the editor does not have a background

@p2kmgcl, can you verify this addresses your issue?

PS: This is a followup of #157

…lexicon since PageEditor uses AlloyEditor

liferay-continuous-integration · 2020-07-28T08:27:05Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

jbalsas · 2020-07-28T08:29:12Z

ci:test:sf

jbalsas · 2020-07-28T08:29:18Z

ci:test:relevant

liferay-continuous-integration · 2020-07-28T08:32:10Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0d329acd58e7487eba8f40d6350fa1d737c0ad02

Sender Branch:

Branch Name: LPS-117468
Branch GIT ID: 80930d1955ef52eaa83f8e21aece26b63331551a

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

markocikos

It's curious to me that we need to specify skin in usage, I would expect this to be inherited from BaseAlloyEditorConfigContributor. Why do we allow editors like fragment editor to extend BaseEditorConfigContributor? I would expect we allow extension of either BaseAlloyEditorConfigContributor or BaseCKEditorConfigContributor. There are 32 results for extends BaseEditorConfigContributor, all of them will have no default configuration, including no skin.

The change is a good workaround for now, it fixes the issue, but we should consider restricting our allowed configuration inheritance. Devs should start with an alloyeditor and modify it, instead of starting from zero and modify it to something close enough to alloyeditor to use its resources and skin.

liferay-continuous-integration · 2020-07-28T10:24:06Z

✔️ ci:test:stable - 21 out of 21 jobs passed

❌ ci:test:relevant - 76 out of 78 jobs passed in 1 hour 53 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0d329acd58e7487eba8f40d6350fa1d737c0ad02

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 2aa558d7587a046d654b60e91d9b21cb5e106df3

ci:test:stable - 21 out of 21 jobs PASSED

21 Successful Jobs:

ci:test:relevant - 76 out of 78 jobs PASSED

2 Failed Jobs:

76 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/8
Job Results:
22 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #174798
  1. LocalFile.ToggleControls#HideAndShowHeaderOfExistingVisiblePortlet - Poshi Report - Poshi Summary - Console Output

For upstream results, click here.

carloslancha · 2020-07-28T11:16:00Z

Would it be an option to set the skin in alloyeditor.jsp (instead in the ConfigContributor) if no value is passed? In this way we would be creating the default right before calling the editor and there won't be needed to add it on every Contributor.

jbalsas · 2020-07-28T11:22:20Z

Hey @markocikos, @carloslancha, thanks for the feedback!

Would it be an option to set the skin in alloyeditor.jsp (instead in the ConfigContributor) if no value is passed? In this way we would be creating the default right before calling the editor and there won't be needed to add it on every Contributor.

It wouldn't, since PageEditor renders AlloyEditor directly without the JSP tag, so it'll never go through alloyeditor.jsp. In this case, configuration is the common place for all editors, not the JSP.

The change is a good workaround for now, it fixes the issue, but we should consider restricting our allowed configuration inheritance. Devs should start with an alloyeditor and modify it, instead of starting from zero and modify it to something close enough to alloyeditor to use its resources and skin.

Yeah, this makes total sense... as I said here, I don't think it actually makes sense to be able to use any skin whatsoever with AlloyEditor, but wanted to get this fixed for GA5.

I'll move the configuration to the BaseAlloyEditorConfigContributor, though. That makes total sense! 👍

jbalsas · 2020-07-28T11:30:27Z

I'll move the configuration to the BaseAlloyEditorConfigContributor, though. That makes total sense! 👍

Ok, scratch that 😂

Not every ConfigContributor targeting AlloyEditor actually extends BaseAlloyEditorConfigContributor, which is where @julien already set the skin value. We cannot set it in BaseEditorConfigContributor directly because it then will affect all editors including those where we want moono-lexicon.

So, I'd say this is the way to go:

Get this workaround merged
Set skin to to moono-lisa in AlloyEditor and cut a release from there (no rush)
Remove the workaround (no rush)

Please, @markocikos, @carloslancha, do you mind double-checking on this and let me know what you think?

Forward if satisfied with my empty promises :)

liferay-continuous-integration · 2020-07-28T11:33:11Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6890
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#175
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - jbalsas > liferay-frontend - PR#175 - 2020-07-28[01:29:57]
Spira Jenkins Build:publish-spira-report#1610

markocikos · 2020-07-28T11:48:27Z

Yeah, I agree we should merge this. ✔️

What I suggest as a no-rush task is to change:

public class FragmentEntryLinkEditorConfigContributor
	extends BaseEditorConfigContributor {

to

public class FragmentEntryLinkEditorConfigContributor
	extends BaseAlloyEditorConfigContributor {

... and to modify the configuration to override alloyeditor, instead of duplicating much of configuration, including the skin added in this PR. This is almost certain to break things, and would require some dependencies juggling, as base alloy class in not in portal kernel like base editor class.

carloslancha · 2020-07-28T11:58:10Z

It wouldn't, since PageEditor renders AlloyEditor directly without the JSP tag, so it'll never go through alloyeditor.jsp. In this case, configuration is the common place for all editors, not the JSP.

True, didn't think about that.

Set skin to to moono-lisa in AlloyEditor and cut a release from there (no rush)

We're setting mono-lexicon as the skin for CKEditor in liferay-ckeditor so makes total sense to do the same but with mono-lisa in AlloyEditor.

carloslancha · 2020-07-28T11:58:17Z

ci:test:relevant

liferay-continuous-integration · 2020-07-28T14:47:46Z

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 78 out of 78 jobs passed in 2 hours 26 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5114630ffc0b18c67c7ef03dfd938f18629fefd9

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 2aa558d7587a046d654b60e91d9b21cb5e106df3

ci:test:stable - 21 out of 21 jobs PASSED

21 Successful Jobs:

ci:test:relevant - 78 out of 78 jobs PASSED

78 Successful Jobs:

For more details click here.

carloslancha · 2020-07-28T14:49:33Z

ci:forward

liferay-continuous-integration · 2020-07-28T14:49:37Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2020-07-28T14:49:38Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2020-07-28T14:52:48Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6229
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#175
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - jbalsas > liferay-frontend - PR#175 - 2020-07-28[05:21:22]
Spira Jenkins Build:publish-spira-report#1614

liferay-continuous-integration · 2020-07-28T14:55:36Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2020-07-28T14:55:56Z

Pull request has been successfully forwarded to brianchandotcom#91914

liferay-continuous-integration · 2020-07-28T16:07:57Z

Jenkins Build:test-portal-source-format#4322
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#175
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - jbalsas > liferay-frontend - PR#175 - 2020-07-28[01:29:40]
Spira Jenkins Build:publish-spira-report#1637

**Changes in this version** [Full changelog](liferay/liferay-ckeditor@v4.16.0-liferay.1...v4.16.0-liferay.2) ### 🔧 Bug fixes - fix: remove unneeded styles ([\#176](liferay/liferay-ckeditor#176)) - fix: update @clayui/css to latest and add more icons ([\#175](liferay/liferay-ckeditor#175)) - fix: add null check ([\#168](liferay/liferay-ckeditor#168))

LPS-117468 Uses moono-lisa skin instead of the new default one moono-…

80930d1

…lexicon since PageEditor uses AlloyEditor

jbalsas mentioned this pull request Jul 28, 2020

LPS-117468 Fix unexpected background and border in Page Editor editables #157

Closed

jbalsas requested a review from markocikos July 28, 2020 08:29

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - pending labels Jul 28, 2020

markocikos approved these changes Jul 28, 2020

View reviewed changes

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Jul 28, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending labels Jul 28, 2020

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:stable - pending labels Jul 28, 2020

liferay-continuous-integration mentioned this pull request Jul 28, 2020

LPS-117468 Uses moono-lisa skin brianchandotcom/liferay-portal#91914

Closed

liferay-continuous-integration closed this Jul 28, 2020

jbalsas deleted the LPS-117468 branch October 30, 2020 17:28

LPS-117468 Uses moono-lisa skin #175

LPS-117468 Uses moono-lisa skin #175

Conversation

jbalsas commented Jul 28, 2020 • edited

liferay-continuous-integration commented Jul 28, 2020

jbalsas commented Jul 28, 2020

jbalsas commented Jul 28, 2020

liferay-continuous-integration commented Jul 28, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Base Branch:

Sender Branch:

For more details click here.

markocikos left a comment • edited

Choose a reason for hiding this comment

liferay-continuous-integration commented Jul 28, 2020

✔️ ci:test:stable - 21 out of 21 jobs passed

❌ ci:test:relevant - 76 out of 78 jobs passed in 1 hour 53 minutes

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/8

Job Results:

For upstream results, click here.

carloslancha commented Jul 28, 2020

jbalsas commented Jul 28, 2020

jbalsas commented Jul 28, 2020 • edited

liferay-continuous-integration commented Jul 28, 2020

markocikos commented Jul 28, 2020

carloslancha commented Jul 28, 2020 • edited

carloslancha commented Jul 28, 2020

liferay-continuous-integration commented Jul 28, 2020

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 78 out of 78 jobs passed in 2 hours 26 minutes

Base Branch:

Copied in Private Modules Branch:

For more details click here.

carloslancha commented Jul 28, 2020

liferay-continuous-integration commented Jul 28, 2020

liferay-continuous-integration commented Jul 28, 2020

liferay-continuous-integration commented Jul 28, 2020

liferay-continuous-integration commented Jul 28, 2020

liferay-continuous-integration commented Jul 28, 2020

liferay-continuous-integration commented Jul 28, 2020

jbalsas commented Jul 28, 2020 •

edited

markocikos left a comment •

edited

jbalsas commented Jul 28, 2020 •

edited

carloslancha commented Jul 28, 2020 •

edited