fix: update @clayui/css to latest and add more icons #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2021 14:15
In order to make sure have the latest icons avaible in `@clayui/css` because we're going to need them for [LPS-132048](https://issues.liferay.com/browse/LPS-132048) And because of this we'll also need to cut a release
As part of [LPS-127012](https://issues.liferay.com/browse/LPS-127012), we're adding more icons to our `moono-lexicon` skin that will be used in the Balloon Editor
|
The check, folder, and color-picker icons don't need to be mirrored because are common symbols where the direction is not relevant (e.g. message icon has to be mirrored because the direction is relevant in an RTL scenario). |
|
Thanks for the quick confirmation @drakonux |
|
In any case and just to keep the conversation going: using CSS transform, would probably be enough to get a missing rtl icon. Doesn't sound like a crazy idea. |
|
Yeah, in fact probably I created some RTL icons that I shouldn't... so little by little, we will adjust this because I'm a bit inexperienced in this topic and I think none of us. |
17 tasks
|
LGTM! |
markocikos
added a commit
to markocikos/liferay-portal
that referenced
this pull request
May 24, 2021
**Changes in this version** [Full changelog](liferay/liferay-ckeditor@v4.16.0-liferay.1...v4.16.0-liferay.2) ### 🔧 Bug fixes - fix: remove unneeded styles ([\#176](liferay/liferay-ckeditor#176)) - fix: update @clayui/css to latest and add more icons ([\#175](liferay/liferay-ckeditor#175)) - fix: add null check ([\#168](liferay/liferay-ckeditor#168))
brianchandotcom
pushed a commit
to brianchandotcom/liferay-portal
that referenced
this pull request
May 26, 2021
**Changes in this version** [Full changelog](liferay/liferay-ckeditor@v4.16.0-liferay.1...v4.16.0-liferay.2) ### 🔧 Bug fixes - fix: remove unneeded styles ([\#176](liferay/liferay-ckeditor#176)) - fix: update @clayui/css to latest and add more icons ([\#175](liferay/liferay-ckeditor#175)) - fix: add null check ([\#168](liferay/liferay-ckeditor#168))
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make sure have the latest icons avaible in
@clayui/cssbecause we're going to need them for LPS-132048
Additionally as part of LPS-127012,
we're adding more icons to our
moono-lexiconskin that will be used inthe Balloon Editor