Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-144572 Update @clayui/* packages to v3.45.0 #1879

Closed

Conversation

matuzalemsteles
Copy link

@matuzalemsteles matuzalemsteles commented Feb 1, 2022

3.45.1 (2022-02-02)

Bug Fixes

  • @clayui/core: avoid converting key type to string when using public method of selection.has() (7c9413a)
  • @clayui/core: fix error when converting key to string when it is of type number (201d72f)
  • @clayui/core: fix error when propagating event when clicking expander (56f56d6)
  • @clayui/core: fixes error when not showing expander with static content (e96ffb0)
  • @clayui/core: fixes error when the child of TreeView.ItemStack is of type number (7b3531f)

3.45.0 (2022-02-01)

Bug Fixes

  • @clayui/core: add a default value to nestedKey (075221d), closes #4584
  • @clayui/core: Change .treeview-item.disabled to .treeview-item-dragging (b87b6b8)
  • @clayui/core: hide expander icon on nodes that don't have chidren (d705fc6), closes #4581
  • @clayui/css: Cadmin Links removes unnecessary setter() from .component-icon (130e708)
  • @clayui/css: Cadmin reset nav-link pseudo elements (7038224)
  • @clayui/css: Cadmin reset Custom Checkbox and Radio pseudo elements (dbbbb02)
  • @clayui/css: Cadmin Treeview removes setter(), no longer necessary (1d4d4a9)
  • @clayui/css: Cadmin Treeview use box-shadow instead of border to indicate drop zone (58ca599)
  • @clayui/css: Forms label inside form-control should use min-height (108d442)
  • @clayui/css: Forms use mixin clay-label-variant instead of deprecated clay-label-size (a0c15fc)
  • @clayui/css: Treeview renames the key link to treeview-link (8378346)
  • @clayui/css: Treeview replaces .treeview-item.disabled with .treeview-item-dragging (a9f88d0)
  • @clayui/css: Treeview use box-shadow instead of border to indicate drop zone (fb93ca7)
  • @clayui/date-picker: fix time picker default value (770639f)
  • @clayui/date-picker: fixes error when not formatting time in 12hours when passing to time picker (2090eb4)
  • @clayui/shared: fix focus control collision when having FocusScope nested (58bd27f)

Features

  • @clayui/core: allow passing extra css classes to expander button (91d40a2), closes #4589
  • @clayui/css: Adds treeview component (776f4bb)
  • @clayui/css: Links adds component-text and component-icon (5188985)
  • @clayui/popover: close the popover when the ESC key is pressed (c49cf89), closes #4567
  • add plain/common API for button links (7148450)

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@matuzalemsteles
Copy link
Author

ci:test:frontend-clay

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b9b0dee253287fb23e10736f989d56872ef29f14

Sender Branch:

Branch Name: LPS-144572
Branch GIT ID: b78baff7b67b4a64fb0d79522de6d13535db02c5

0 out of 1jobs PASSED
For more details click here.
     [exec] 
     [exec] ***************
     [exec] *** WARNING ***
     [exec] ***************
     [exec] 
     [exec] Out-of-date TypeScript build artifacts at:
     [exec] 
     [exec]     apps/object/object-web/types
     [exec] 
     [exec] Please commit them.
     [exec] 
     [exec] M modules/apps/object/object-web/types/src/main/resources/META-INF/resources/js/components/layout/layout-screen/AddNewTabButton.d.ts
     [exec] 
     [exec] Generating types (14 of 14): remote-app-client-js
     [exec] Preflight check failed:
     [exec] checkTypeScriptTypeArtifacts() failed: Error: Type generation was successful but 1 project was out of date. Please commit updated versions of the artifacts in the projects listed above.
     [exec] 
     [exec] 1 of 3 jobs failed
     [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
     [exec] error Command failed with exit code 1.
     [exec] 
     [exec] > Task :packageRunCheckFormat FAILED
     [exec] Gradle build finished at 2022-02-01 22:03:28.643.
     [exec] 3 actionable tasks: 2 executed, 1 up-to-date
     [exec] 
     [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2022-02-01-14-02-07.html
     [exec] A fine-grained performance profile is available: use the --scan option.
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':packageRunCheckFormat'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:208)
     [exec]   at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:263)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:frontend-clay - 2 out of 2 jobs passed in 1 hour 9 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b9b0dee253287fb23e10736f989d56872ef29f14

Upstream Comparison:

Branch GIT ID: c64a422ea9b0edf4907992caa009980a34ca298f
Jenkins Build URL: Acceptance Upstream DXP (master) #2876

ci:test:frontend-clay - 2 out of 2 jobs PASSED
2 Successful Jobs:
For more details click here.
Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

@matuzalemsteles
Copy link
Author

The SF fail seems to be unrelated to that PR, it's happening in object-web which probably didn't update the TypeScript types.

@matuzalemsteles matuzalemsteles added the s-clay Pull requests to be reviewed by Clay Squad label Feb 1, 2022
@john-co
Copy link

john-co commented Feb 2, 2022

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 34 out of 46 jobs passed

❌ ci:test:relevant - 34 out of 47 jobs passed in 3 hours 24 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b9b0dee253287fb23e10736f989d56872ef29f14

Upstream Comparison:

Branch GIT ID: b9b0dee253287fb23e10736f989d56872ef29f14
Jenkins Build URL: Acceptance Upstream DXP (master) #2877

ci:test:stable - 34 out of 46 jobs PASSED

12 Failed Jobs:

34 Successful Jobs:
ci:test:relevant - 34 out of 47 jobs PASSED

13 Failed Jobs:

34 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
    Job Results:

    13 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=10 #26313

      Please fix semantic versioning on matuzalemsteles/LPS-144572

           [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
           [exec] = ================================================== ========== ========== ========== ========== ==========
           [exec] * com.liferay.portal.util                            MAJOR      17.0.0     17.0.0     18.0.0     VERSION INCREASE REQUIRED
           [exec]   >   class      com.liferay.portal.util.PropsValues
           [exec]     -   field      PORTLET_URL_GENERATE_BY_PATH_ENABLED
           [exec]       -   access     final
           [exec]       -   access     static
           [exec]       -   return     boolean
           [exec] [Baseline Warning] Bundle Version Change Recommended: 22.0.0
           [exec] [Baseline Report] Mode: diff (persisted)
           [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-impl/portal-impl.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.impl/21.0.1/738b94219ff9ecbdac36ec1a817066bfb7086e42/com.liferay.portal.impl-21.0.1.jar

  2. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0
    Job Results:

    3170 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=1 #31318
      1. com.liferay.portal.search.elasticsearch7.internal.pagination.ElasticsearchPaginationTest.testMiddleOne
        java.lang.AssertionError: {docs={}, length=0, query=null] expected:<20> but was:<0>
          at org.junit.Assert.fail(Assert.java:88)
          at org.junit.Assert.failNotEquals(Assert.java:834)
          at org.junit.Assert.assertEquals(Assert.java:645)
          at com.liferay.portal.search.test.util.pagination.BasePaginationTestCase.lambda$_assertPagination$0(BasePaginationTestCase.java:151)
          at com.liferay.portal.search.test.util.IdempotentRetryAssert.retryAssert(IdempotentRetryAssert.java:43)
          at com.liferay.portal.search.test.util.IdempotentRetryAssert.retryAssert(IdempotentRetryAssert.java:29)
          at com.liferay.portal.search.test.util.pagination.BasePaginationTestCase._assertPagination(BasePaginationTestCase.java:141)
          at com.liferay.portal.search.test.util.pagination.BasePaginationTestCase.testMiddleOne(BasePaginationTestCase.java:94)
          at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
          at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          at java.lang.reflect.Method.invoke(Method.java:498)
          at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
          at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
          at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
          at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
          at org.junit.internal.runners.statement...

Failures in common with acceptance upstream results at b9b0dee:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8/0
    Job Results:

    15 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=14 #26310
           [exec] > Task :third-party:org-springframework-orm:compileJava FAILED
           [exec] 
           [exec] > Task :third-party:org-springframework-orm:copyLibs SKIPPED
           [exec] /opt/dev/projects/github/liferay-portal/modules/third-party/org-springframework-orm/src/main/java/org/springframework/orm/hibernate3/HibernateInterceptor.java:19: error: package org.aopalliance.intercept does not exist
           [exec] import org.aopalliance.intercept.MethodInterceptor;
           [exec]                                 ^
           [exec] /opt/dev/projects/github/liferay-portal/modules/third-party/org-springframework-orm/src/main/java/org/springframework/orm/hibernate3/HibernateInterceptor.java:20: error: package org.aopalliance.intercept does not exist
           [exec] import org.aopalliance.intercept.MethodInvocation;
           [exec]                                 ^
           [exec] /opt/dev/projects/github/liferay-portal/modules/third-party/org-springframework-orm/src/main/java/org/springframework/orm/hibernate3/HibernateInterceptor.java:79: error: cannot find symbol
           [exec] public class HibernateInterceptor extends HibernateAccessor implements MethodInterceptor {
           [exec]                                                                        ^
           [exec]   symbol: class MethodInterceptor
           [exec] /opt/dev/projects/github/liferay-portal/modules/third-party/org-springframework-orm/src/main/java/org/springframework/orm/hibernate3/HibernateInterceptor.java:97: error: cannot find symbol
           [exec]   public Object invoke(MethodInvocation methodInvocation) throws Throwable {
           [exec]                        ^
           [exec]   symbol:   class MethodInvocation
           [exec]   location: class HibernateInterceptor
           [exec] /opt/dev/projects/github/liferay-portal/modules/third-party/org-springframework-orm/src/main/java/org/springframework/orm/hibernate3/annotation/AnnotationSessionFactoryBean.java:30: error: package org.springframework.context does not exist
           [exec] import org.springframework.context.ResourceLoaderAware;
           [exec]                                   ^
           [exec] /opt/dev/projects/github/liferay-portal/modules/third-party/org-springframework-orm/src/main/java/org/springframework/orm/hibernate3/annotation/AnnotationSessionFactoryBean.java:80: error: cannot find symbol
           [exec]     implements ResourceLoaderAware {
           [exec]                ^
           [exec]   symbol: class ResourceLoaderAware
  2. ...
Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2c339841b97ddba498430a24f0e2a7772edd8c82

Sender Branch:

Branch Name: LPS-144572
Branch GIT ID: 67fe11882d47c7649eb004f12e22e8d5c79d7a62

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:frontend-clay - 2 out of 2 jobs passed in 53 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2c339841b97ddba498430a24f0e2a7772edd8c82

Upstream Comparison:

Branch GIT ID: b9b0dee253287fb23e10736f989d56872ef29f14
Jenkins Build URL: Acceptance Upstream DXP (master) #2877

ci:test:frontend-clay - 2 out of 2 jobs PASSED
2 Successful Jobs:
For more details click here.
Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:acceptance-functional - 13 out of 32 jobs passed in 2 hours 53 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1317401_1999

Base Branch:

Branch Name: master
Branch GIT ID: 2c339841b97ddba498430a24f0e2a7772edd8c82

Upstream Comparison:

Branch GIT ID: b9b0dee253287fb23e10736f989d56872ef29f14
Jenkins Build URL: Acceptance Upstream DXP (master) #2877

ci:test:acceptance-functional - 13 out of 32 jobs PASSED

19 Failed Jobs:

13 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. ...
Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 38 out of 46 jobs passed

❌ ci:test:relevant - 38 out of 47 jobs passed in 3 hours 6 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1347401_791

Base Branch:

Branch Name: master
Branch GIT ID: 2c339841b97ddba498430a24f0e2a7772edd8c82

Upstream Comparison:

Branch GIT ID: b9b0dee253287fb23e10736f989d56872ef29f14
Jenkins Build URL: Acceptance Upstream DXP (master) #2877

ci:test:stable - 38 out of 46 jobs PASSED
38 Successful Jobs:
ci:test:relevant - 38 out of 47 jobs PASSED
38 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/14
    Job Results:

    24 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=9 #30810
      start-docker-containers:
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/docker_stop.sh
           [exec] 9fe731adac49b10088b326c3d73c80f0d6dd481f6b6e102c1aa9e5cb384dcb09
           [exec] Started container [ID: '9fe731adac49', name: 'test-1-31-57.lax.liferay.com_mysql'] from image 'mysql:5.7.25'
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/docker_start.sh
           [exec] Waiting for MySQL 5.7 to be ready
      [stopwatch] [run.batch.test.action: 2.498 sec]
           [echo] The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:374: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:14053: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:5007: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:6020: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:325: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:521: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:640: exec returned: 137
            [get] Getting: http://test-1-31/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=9/30810//consoleText
            [get] To: /opt/dev/projects/github/liferay-portal/20220202173119268.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/20220202173119268.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/null17588476.properties

Failures in common with acceptance upstream results at b9b0dee:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0 #17452
           [exec] * What went wrong:
           [exec] Execution failed for task ':apps:content-dashboard:content-dashboard-web:compileTestJava'.
           [exec] > Compilation failed; see the compiler error output for details.
           [exec] 
           [exec] * Try:
           [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:content-dashboard:content-dashboard-web:compileTestJava'.
           [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)
           [exec]   at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)
           [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
           [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)
           [exec]   at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
           [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
           [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
           [exec]   at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
           [exec]   at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
           [exec]   at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
           [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
           [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
           [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
           [exec]   at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:409)
           [exec]   at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:399)
  2. ...
Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

@john-co
Copy link

john-co commented Feb 3, 2022

Just started reviewing :)

@john-co
Copy link

john-co commented Feb 3, 2022

Reviewed. Test failures are unrelated. ✔️

  • acceptance-functional: mostly aborted prior to test ran or network issues
  • ci:test:relevant: looks like jenkins ran out of memory issue

I'll manually forward this up

@john-co john-co added the ready-for-qa Ready for QA review label Feb 3, 2022
@john-co
Copy link

john-co commented Feb 3, 2022

Manually forward to brianchandotcom#113029

@john-co john-co closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment