New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TreeView: review "nestedKey" prop #4584
Comments
I don't see a problem with adding since we have the |
@matuzalemsteles take out the "nestedKey" prop in the stories (before this change) and look at what happens: nested node aren't rendered |
@julien yeah, this is the expected behavior as I commented in all the messages in the TreeView PRs, the idea is to be data agnostic so we are not opinionated about this property, it is a required property for the dynamic TreeView state. Don't get me wrong, I'm just saying that I don't see a problem with adding a default value once we have a way to configure it. |
This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-144571 |
In order to render a nested tree, I'm seeing that it's required to pass
the
nestedKey
prop. Maybe we should add a default value here.@matuzalemsteles tell me what you think when you get a chance.
The text was updated successfully, but these errors were encountered: