Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeView: review "nestedKey" prop #4584

Closed
julien opened this issue Jan 17, 2022 · 4 comments · Fixed by #4585
Closed

TreeView: review "nestedKey" prop #4584

julien opened this issue Jan 17, 2022 · 4 comments · Fixed by #4585
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: bug Issues reporting that Component is not doing what should be done

Comments

@julien
Copy link
Contributor

julien commented Jan 17, 2022

In order to render a nested tree, I'm seeing that it's required to pass
the nestedKey prop. Maybe we should add a default value here.

@matuzalemsteles tell me what you think when you get a chance.

@julien julien added the type: bug Issues reporting that Component is not doing what should be done label Jan 17, 2022
julien pushed a commit to julien/clay that referenced this issue Jan 17, 2022
@matuzalemsteles
Copy link
Member

I don't see a problem with adding since we have the nestedKey prop that can change, that's because in some places in DXP the property names are different depending on the application, children is just a more common term for us.

@matuzalemsteles matuzalemsteles added the comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) label Jan 24, 2022
@julien
Copy link
Contributor Author

julien commented Jan 25, 2022

@matuzalemsteles take out the "nestedKey" prop in the stories (before this change) and look at what happens: nested node aren't rendered

@matuzalemsteles
Copy link
Member

@julien yeah, this is the expected behavior as I commented in all the messages in the TreeView PRs, the idea is to be data agnostic so we are not opinionated about this property, it is a required property for the dynamic TreeView state.

Don't get me wrong, I'm just saying that I don't see a problem with adding a default value once we have a way to configure it.

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-144571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
3 participants