LPS-152226 Deprecate disableToggleBoxes and replace its usages
#2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: disableToggleBoxes 1 Successful Jobs:For more details click here. |
kresimir-coko
changed the title
disableToggleBoxes and replace its usagesdisableToggleBoxes and replace its usages
|
Jenkins Build:test-portal-source-format#1271 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#2215 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - kresimir-coko > liferay-frontend - PR#2215 - 2022-05-10[03:45:35] Testray Importer:publish-testray-report#5072 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#3080 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#2215 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - kresimir-coko > liferay-frontend - PR#2215 - 2022-05-10[03:45:30] Testray Importer:publish-testray-report#8191 |
bryceosterhaus
requested changes
May 11, 2022
modules/apps/journal/journal-web/src/main/resources/META-INF/resources/article/basic_info.jsp
Outdated
Show resolved
Hide resolved
modules/apps/journal/journal-web/src/main/resources/META-INF/resources/edit_feed.jsp
Outdated
Show resolved
Hide resolved
...et-configuration-web/src/main/resources/META-INF/resources/edit_public_render_parameters.jsp
Outdated
Show resolved
Hide resolved
...et-configuration-web/src/main/resources/META-INF/resources/edit_public_render_parameters.jsp
Outdated
Show resolved
Hide resolved
kresimir-coko
force-pushed
the
disableToggleBoxes
branch
from
9853b09
to
93a2b6d
Compare
|
@bryceosterhaus I've rebased and fixed your concerns, pushing the new commit |
|
ci:test:sf |
|
ci:test:relevant |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: disableToggleBoxes 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#1237 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#2215 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - kresimir-coko > liferay-frontend - PR#2215 - 2022-05-11[04:54:31] Testray Importer:publish-testray-report#4709 |
liferay-continuous-integration
added
ci:test:relevant - pending
and removed
ci:test:relevant - success
labels
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#3283 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#2215 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - kresimir-coko > liferay-frontend - PR#2215 - 2022-05-11[05:47:56] Testray Importer:publish-testray-report#9206 |
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites: |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#117321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After careful investigation I've come to the conclusion that this utility was a more specific variant of our toggleDisabled util. I've changed usages of this util to reflect that conclusion.
🧪 Testing
I've tested only one of three usages, I couldn't find the other 2 usages. I've tested the one inside
edit_feed.jspthat can be tested by enabling Feeds first: System settings -> Web Content -> Administration -> Show feeds. Then go to Web Content > Feeds and create a new Feed.😕 Confusion
The given example above has the elements in question set as hidden, so the functionality should be able to be removed in that example, but I wanted to play it safe and keep everything as it was. Due to this, in order to test it, you will need to replace the
type="hidden"withtype="text"andtype="checkbox", respectively (in this part).