LPS-125728 Fix render of empty accordions in Forms #709

edalgrin · 2021-01-19T11:22:33Z

This PR fixes the accordion bug in Forms https://issues.liferay.com/browse/LPS-125728

The bug was caused by the empty tab, probably because the responsible script is trying to get an height size.

Since keeping the empty tab it's actually an UX error, I preferred to remove it instead of adjusting the script for this corner case.

marcoscv-work · 2021-01-19T15:11:07Z

I agree with: Since keeping the empty tab it's actually an UX error, I preferred to remove it instead of adjusting the script for this corner case.

:-D

...pping-form-builder/src/main/resources/META-INF/resources/js/components/Sidebar/Sidebar.es.js

matuzalemsteles · 2021-01-19T20:15:54Z

Hey @edalgrin and @jbalsas I do not see any problems in proceeding with this change since we are going to remove this Sidebar in the ticket we are working on 🤪 to use the Data Engine MultiPanelSidebar 😁.

jbalsas · 2021-01-19T20:56:45Z

ci:forward

liferay-continuous-integration · 2021-01-19T20:56:48Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-01-19T21:02:09Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a4b3d0cdbc5bdfd9adff1ab24a594c02820dd567

Sender Branch:

Branch Name: LPS-125728
Branch GIT ID: 214d803364fef9f68778016e7ebb64b22523bf45

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-01-19T21:04:09Z

Jenkins Build:test-portal-source-format#2395
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#709
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - edalgrin > liferay-frontend - PR#709 - 2021-01-19[12:57:09]
Spira Jenkins Build:publish-spira-report#11318

liferay-continuous-integration · 2021-01-19T22:29:38Z

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 23 out of 25 jobs passed in 1 hour 32 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1450345f4b675c215f214c8a680ad2082e80ac39

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 2b89e6be0ae0f6e12dec390930d3e9525006e687

ci:test:stable - 8 out of 9 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8/0~~

8 Successful Jobs:

ci:test:relevant - 23 out of 25 jobs PASSED

2 Failed Jobs:

23 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #456649

     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:dynamic-data-mapping:dynamic-data-mapping-form-builder:packageRunTest'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:dynamic-data-mapping:dynamic-data-mapping-form-builder:packageRunTest'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)
     [exec] 	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)
     [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
     [exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
     [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
     [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:409)

For upstream results, click here.

liferay-continuous-integration · 2021-01-19T22:36:35Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7127
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#709
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - edalgrin > liferay-frontend - PR#709 - 2021-01-19[12:56:57]
Spira Jenkins Build:publish-spira-report#12148

edalgrin · 2021-01-20T10:49:56Z

ci:test:relevant

liferay-continuous-integration · 2021-01-28T17:20:20Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 25 jobs passed in 1 hour 48 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d87f3c5df11698d064d67445ab4f79097ebf3d80

Upstream Comparison:

Branch GIT ID: 0dddcd3bd491ba7902755f0c4138befa610c3947
Jenkins Build URL: Acceptance Upstream DXP (master) #1496

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 21 out of 25 jobs PASSED

4 Failed Jobs:

21 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 0dddcd3:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #412985

Please fix semantic versioning on edalgrin/LPS-125728

     [exec] 			-   return     void
     [exec] 		-   method     getFieldType()
     [exec] 			-   return     java.lang.String
     [exec] 		-   method     hashCode()
     [exec] 			-   return     int
     [exec] 		-   method     toJSON(com.liferay.portal.kernel.repository.model.FileEntry)
     [exec] 			-   access     protected
     [exec] 			-   return     java.lang.String
     [exec] 		-   method     toString()
     [exec] 			-   return     java.lang.String
     [exec] 		-   method     transform(com.liferay.dynamic.data.mapping.storage.DDMFormFieldValue)
     [exec] 			-   return     void
     [exec] 	+   class      com.liferay.dynamic.data.mapping.util.SettingsDDMFormFieldsUtil
     [exec] 		+   method     <init>()
     [exec] 			+   return     void
     [exec] 		+   method     clone()
     [exec] 			+   access     protected
     [exec] 			+   return     java.lang.Object
     [exec] 		+   method     equals(java.lang.Object)
     [exec] 			+   return     boolean
     [exec] 		+   method     finalize()
     [exec] 			+   access     protected
     [exec] 			+   return     void
     [exec] 		+   method     getSettingsDDMFormFields(com.liferay.dynamic.data.mapping.form.field.type.DDMFormFieldTypeServicesTracker,java.lang.String)
     [exec] 			+   access     static
     [exec] 			+   return     java.util.Map
     [exec] 		+   method     hashCode()
     [exec] 			+   return     int
     [exec] 		+   method     toString()
     [exec] 			+   return     java.lang.String
     [exec] 	+   interface  com.liferay.dynamic.data.mapping.util.DDMDataDefinitionConverter
     [exec] 		+   access     abstract
     [exec] 		+   method     convert(com.liferay.dynamic.data.mapping.model.DDMForm,java.util.Locale)
     [exec] 			+   access     abstract
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     convert(java.lang.String,java.util.Locale)
     [exec] 			+   access     abstract
     [exec] 			+   return     java.lang.String
     [exec] 	-   version    2.7.0
     [exec] 	+   version    2.8.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.dynamic.data.mapping.api-9.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.dynamic.data.mapping.api/8.11.2/61bc64754fb215cadedf88e952ddfcbcd78c7188/com.liferay.dynamic.data.mapping.api-8.11.2.jar

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2
Job Results:
40 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=2,label_exp=!master #423638
  1. LocalFile.Forms#SubmitFormWithAllFieldTypesAndThreePages - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0

Job Results:

805 Tests Passed.
7 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #457449

DDMFormUploadValidatorTest.testInvalidFileException

java.lang.ExceptionInInitializerError
	at com.liferay.portal.configuration.metatype.bnd.util.ConfigurableUtil._overrideDictionary(ConfigurableUtil.java:217)
	at com.liferay.portal.configuration.metatype.bnd.util.ConfigurableUtil.createConfigurable(ConfigurableUtil.java:51)
	at com.liferay.dynamic.data.mapping.form.web.internal.upload.DDMFormUploadValidatorTest.setUpDDMFormWebConfigurationActivator(DDMFormUploadValidatorTest.java:96)
	at com.liferay.dynamic.data.mapping.form.web.internal.upload.DDMFormUploadValidatorTest.setUp(DDMFormUploadValidatorTest.java:44)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.ja...

DDMFormUploadValidatorTest.testValidFileSize

java.lang.NoClassDefFoundError: Could not initialize class com.liferay.portal.configuration.persistence.ConfigurationOverridePropertiesUtil
	at com.liferay.portal.configuration.metatype.bnd.util.ConfigurableUtil._overrideDictionary(ConfigurableUtil.java:217)
	at com.liferay.portal.configuration.metatype.bnd.util.ConfigurableUtil.createConfigurable(ConfigurableUtil.java:51)
	at com.liferay.dynamic.data.mapping.form.web.internal.upload.DDMFormUploadValidatorTest.setUpDDMFormWebConfigurationActivator(DDMFormUploadValidatorTest.java:96)
	at com.liferay.dynamic.data.mapping.form.web.internal.upload.DDMFormUploadValidatorTest.setUp(DDMFormUploadValidatorTest.java:44)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRu...

DDMFormWebConfigurationModelListenerTest.testNegativeAutosaveIntervalShouldThrowException

java.lang.Exception: Unexpected exception, expected<com.liferay.portal.configuration.persistence.listener.ConfigurationModelListenerException> but was<java.lang.ExceptionInInitializerError>
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.handleException(PowerMockJUnit44RunnerDelegateImpl.java:364)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.handleException(PowerMockJUnit47RunnerDelegateImpl.java:122)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.handleInvocationTargetException(PowerMockJUnit44RunnerDelegateImpl.java:337)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:315)
	at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:89)
	at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:97)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:294)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:127)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUni...

...

liferay-continuous-integration · 2021-01-28T17:28:14Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4277
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#709
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - edalgrin > liferay-frontend - PR#709 - 2021-01-28[07:24:35]
Spira Jenkins Build:publish-spira-report#11916

zhangyan0701 · 2021-01-29T10:52:58Z

ci:test:bundle

liferay-continuous-integration · 2021-01-29T11:41:39Z

✔️ ci:test:bundle - 1 out of 1 jobs passed in 48 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8c437d084cef9ec3e4e1a3382be525bf6875254a

ci:test:bundle - 1 out of 1 jobs PASSED

For more details click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

edalgrin · 2021-01-29T12:57:11Z

ci:forward

liferay-continuous-integration · 2021-01-29T12:57:15Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-01-29T12:57:18Z

Skipping previously passed test suites:
ci:test:relevant

liferay-continuous-integration · 2021-01-29T13:11:03Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d87f3c5df11698d064d67445ab4f79097ebf3d80

Sender Branch:

Branch Name: LPS-125728
Branch GIT ID: cf0ef2c192f31ab31e37ef383918b56dacfe765f

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-01-29T13:11:09Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2021-01-29T13:11:33Z

Pull request has been successfully forwarded to brianchandotcom#98232

liferay-continuous-integration · 2021-01-29T13:25:40Z

Jenkins Build:test-portal-source-format#2462
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#709
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - edalgrin > liferay-frontend - PR#709 - 2021-01-29[05:05:42]
Spira Jenkins Build:publish-spira-report#10626

liferay-continuous-integration · 2021-01-29T14:02:05Z

Jenkins Build:test-portal-source-format#2462
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#709
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - edalgrin > liferay-frontend - PR#709 - 2021-01-29[05:05:42]
Spira Jenkins Build:publish-spira-report#11984

edalgrin requested review from wincent and carloslancha January 19, 2021 11:23

jbalsas reviewed Jan 19, 2021

View reviewed changes

...pping-form-builder/src/main/resources/META-INF/resources/js/components/Sidebar/Sidebar.es.js Outdated Show resolved Hide resolved

edalgrin force-pushed the LPS-125728 branch from 15675fa to 214d803 Compare January 19, 2021 17:19

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Jan 19, 2021

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Jan 19, 2021

wincent mentioned this pull request Jan 20, 2021

Add guidelines for expressions in conditionals and JSX liferay/liferay-frontend-projects#384

Closed

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure and removed ci:test:relevant - failure ci:test:stable - failure ci:test:relevant - pending ci:test:stable - pending labels Jan 20, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - failure ci:test:relevant - pending ci:test:stable - pending labels Jan 28, 2021

liferay-continuous-integration added ci:test:bundle - pending ci:test:bundle - success and removed ci:test:bundle - pending labels Jan 29, 2021

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Jan 29, 2021

liferay-continuous-integration mentioned this pull request Jan 29, 2021

LPS-125728 Fix render of empty accordions in Forms brianchandotcom/liferay-portal#98232

Closed

liferay-continuous-integration closed this Jan 29, 2021

edalgrin deleted the LPS-125728 branch February 10, 2021 10:37

LPS-125728 Fix render of empty accordions in Forms #709

LPS-125728 Fix render of empty accordions in Forms #709

Conversation

edalgrin commented Jan 19, 2021

marcoscv-work commented Jan 19, 2021

matuzalemsteles commented Jan 19, 2021

jbalsas commented Jan 19, 2021

liferay-continuous-integration commented Jan 19, 2021

liferay-continuous-integration commented Jan 19, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jan 19, 2021

liferay-continuous-integration commented Jan 19, 2021

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 23 out of 25 jobs passed in 1 hour 32 minutes

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8/0

Job Results:

For upstream results, click here.

liferay-continuous-integration commented Jan 19, 2021

edalgrin commented Jan 20, 2021

liferay-continuous-integration commented Jan 28, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 25 jobs passed in 1 hour 48 minutes

Base Branch:

Upstream Comparison:

4 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0

Job Results:

liferay-continuous-integration commented Jan 28, 2021

zhangyan0701 commented Jan 29, 2021

liferay-continuous-integration commented Jan 29, 2021

✔️ ci:test:bundle - 1 out of 1 jobs passed in 48 minutes

Base Branch:

For more details click here.

Test bundle downloads:

edalgrin commented Jan 29, 2021

liferay-continuous-integration commented Jan 29, 2021

liferay-continuous-integration commented Jan 29, 2021

liferay-continuous-integration commented Jan 29, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jan 29, 2021

liferay-continuous-integration commented Jan 29, 2021

liferay-continuous-integration commented Jan 29, 2021

liferay-continuous-integration commented Jan 29, 2021