LPS-127308 [TS] [Bug: 7.3.x, master] LPS-127308 Category Filters are removed when doing a text search in Content Dashboard #773

cgoncas · 2021-02-09T09:41:28Z

Motivation

TS has found the next bug:

Steps to Reproduce

Create a Vocabulary and a category in it
Create 2 web contents: one with the category titled "test 1", one without a category titled "test 2"
Go to the App Menu > Content Dashboard
Select the category in the category filter
Search for the keyword "test"
Search result is shown without category filter

The original cause was that the Content Dashboard was not filling the assetCategoryId to the Search URL (done in this commit ), but even with this change, @balazssk has found that only one value per assetCategoryId was set.

That is the reason he has needed to make this commit in the ManagementToolbarTag, so we can handle multiple values for the same parameter name.

If you have any doubt, please, let me know.

Thanks!!

/cc @balazssk

liferay-continuous-integration · 2021-02-09T09:41:32Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2021-02-09T09:44:39Z

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4318e2f9eb91ca3c0c74c377855994dac9dc8d80

Sender Branch:

Branch Name: pr-855
Branch GIT ID: e6887c6952f11de8d798ac76798d6cf8422cad03

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: ./modules/apps/content-dashboard/content-dashboard-web/src/main/java/com/liferay/content/dashboard/web/internal/display/context/ContentDashboardAdminManagementToolbarDisplayContext.java expected:<...letURL.setParameter([
     [java] 				"authorIds",
     [java] 				stream.map(
     [java] 					String::valueOf
     [java] 				).toArray(
     [java] 					String[]::new
     [java] 				]));
     [java] 		\}
     [java] 
     [java] 		List<? ex...> but was:<...letURL.setParameter(["authorIds", stream.map(
     [java] 				String::valueOf
     [java] 			).toArray(String[]::new]));
     [java] 		\}
     [java] 
     [java] 		List<? ex...>
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:445)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:290)
[stopwatch] [run.batch.test.action: 1:35.888 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:572: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:706: Java returned: 1
      [get] Getting: http://test-1-22/job/test-portal-source-format/6168//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20210209014426331.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20210209014426331.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null485030581.properties
merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null981189423

[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 251ms

[junitreport] Deleting: /tmp/null981189423

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

cgoncas · 2021-02-09T09:50:54Z

ci:test:sf

cgoncas · 2021-02-09T09:51:02Z

ci:test:stop

liferay-continuous-integration · 2021-02-09T10:00:10Z

❌ ci:test:stop - 0 out of 1 jobs passed in 9 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:123null_7343

Base Branch:

Branch Name: master
Branch GIT ID: 4318e2f9eb91ca3c0c74c377855994dac9dc8d80

Upstream Comparison:

Branch GIT ID: 7f8557eaa8e197a8cf8620cbc740d13b6600a438
Jenkins Build URL: Acceptance Upstream DXP (master) #1529

ci:test:stop - 0 out of 1 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)
Job Results:
0 Jobs Passed.
1 Job Failed.
The CI test suite 'stop' is not a valid test suite.
List of available CI test suites:
- acceptance
- acceptance-upstream
- accounts
- analytics-cloud
- app-builder
- auto-tagging
- backend
- backend-hypersonic
- blade
- blogs
- bulk-editing
- bundle
- calendar
- clustering
- commerce
- content-page-review
- data-engine
- depot
- dl-store
- documents
- drools
- dummy
- echo
- echo-acceptance
- environments
- environments-alpine38
- environments-alpine310
- environments-centos6
- environments-centos8
- environments-debian7
- environments-debian8
- environments-debian9
- environments-oracle19
- environments-orcllinux6
- environments-orcllinux7
- environments-postgresql11
- environments-release-ce
- environments-release-dxp
- environments-suse15
- environments-ubuntu14
- environments-ubuntu16
- environments-ubuntu18
- export-import
- forms
- frontend
- gauntlet
- gradle-plugins
- headless
- headless-acceptance
- jdk11
- jsf
- knowledge-base
- ldap
- license
- lima
- lpkg
- message-boards
- oauth2
- onedrive
- online-editing
- poshi
- poshi-gauntlet
- project-templates
- publications
- redirect
- relevant
- reports
- roles
- saml
- search
- search-jdk11
- security
- seo
- sf
- sharepoint
- sharing
- site-template
- stable
- staging
- sybase
- system
- tango
- tango-acceptance
- tango-analytics-cloud
- tck
- translations
- upgrade
- upgrade-client
- users
- wiki
- workflow
Comment 'ci:help' for details.

For upstream results, click here.

liferay-continuous-integration · 2021-02-09T10:03:51Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4318e2f9eb91ca3c0c74c377855994dac9dc8d80

Sender Branch:

Branch Name: pr-855
Branch GIT ID: 6ff005578d69ded7eb5d4d83ab3de1d74b279e00

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

cgoncas · 2021-02-09T10:08:00Z

ci:test:relevant

liferay-continuous-integration · 2021-02-09T11:18:35Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 2 days 23 hours 35 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4318e2f9eb91ca3c0c74c377855994dac9dc8d80

Upstream Comparison:

Branch GIT ID: 4318e2f9eb91ca3c0c74c377855994dac9dc8d80
Jenkins Build URL: Acceptance Upstream DXP (master) #1530

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 20 out of 23 jobs PASSED

3 Failed Jobs:

20 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
Job Results:
4 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #413981
  1. LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at 4318e2f:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #464072

Please fix semantic versioning on cgoncas/pr-855

     [exec] 			+   return     void
     [exec] 		+   method     setPageContext(javax.servlet.jsp.PageContext)
     [exec] 			+   return     void
     [exec] 		+   method     setShowButtons(boolean)
     [exec] 			+   return     void
     [exec] 		+   method     toString()
     [exec] 			+   return     java.lang.String
     [exec] 	<   class      com.liferay.frontend.taglib.servlet.taglib.InfoBarSidenavTogglerButtonTag
     [exec] 		+   method     getSidenavId()
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     setSidenavId(java.lang.String)
     [exec] 			+   return     void
     [exec] 	<   class      com.liferay.frontend.taglib.servlet.taglib.ManagementBarSidenavTogglerButtonTag
     [exec] 		+   method     getSidenavId()
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     setSidenavId(java.lang.String)
     [exec] 			+   return     void
     [exec] 	<   class      com.liferay.frontend.taglib.servlet.taglib.SidebarPanelTag
     [exec] 		+   method     getCloseButton()
     [exec] 			+   return     boolean
     [exec] 		+   method     setCloseButton(boolean)
     [exec] 			+   return     void
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] 
     [exec] > Task :apps:frontend-taglib:frontend-taglib:syncVersions
     [exec] > Task :apps:content-dashboard:content-dashboard-web:jar
     [exec] > Task :apps:content-dashboard:content-dashboard-web:autoUpdateXml SKIPPED
     [exec] > Task :apps:content-dashboard:content-dashboard-web:baseline SKIPPED
     [exec] > Task :apps:content-dashboard:content-dashboard-web:syncVersions
     [exec] Gradle build finished at 2021-02-09 10:48:25.809.
     [exec] 
     [exec] 
     [exec] FAILURE: Build completed with 2 failures.
     [exec] 
     [exec] 1: Task failed with an exception.
     [exec] -----------
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:frontend-taglib:frontend-taglib-react:baseline'.
     [exec] > A failure occurred while executing com.liferay.gradle.plugins.baseline.internal.work.BaselineWorkAction
     [exec]    > org.gradle.api.GradleException: Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.frontend.taglib.react-5.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.frontend.taglib.react/4.1.2/ec050fd1c3aa0f51ab209177255ba6f126eabeef/com.liferay.frontend.taglib.react-4.1.2.jar

…nt-dashboard-web The clay management toolbar component has been migrated to the new version using React components. All features previously handled by the management toolbar should still work as expected

julien · 2021-02-22T10:17:41Z

ci:test:sf

liferay-continuous-integration · 2021-02-22T10:21:03Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 25 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: aa80a9ec2a3bc90349b41faec6f2fa93e99fc0c4

Sender Branch:

Branch Name: pr-855
Branch GIT ID: e0119903156745bdd3c6994234c1d5c73606f0b4

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

julien · 2021-02-22T10:22:23Z

ci:test:relevant

liferay-continuous-integration · 2021-02-22T11:02:47Z

Jenkins Build:test-portal-source-format#2766
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#773
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - cgoncas > liferay-frontend - PR#773 - 2021-02-22[02:17:52]
Spira Jenkins Build:publish-spira-report#14277

liferay-continuous-integration · 2021-02-22T11:47:45Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 1 hour 36 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: aa80a9ec2a3bc90349b41faec6f2fa93e99fc0c4

Upstream Comparison:

Branch GIT ID: aa80a9ec2a3bc90349b41faec6f2fa93e99fc0c4
Jenkins Build URL: Acceptance Upstream DXP (master) #1567

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 21 out of 23 jobs PASSED

2 Failed Jobs:

21 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at aa80a9e:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #322964

Please fix semantic versioning on cgoncas/pr-855

     [exec] 		+   method     setHtmlTop(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     setId(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     setPageContext(javax.servlet.jsp.PageContext)
     [exec] 			+   return     void
     [exec] 		+   method     setShowButtons(boolean)
     [exec] 			+   return     void
     [exec] 		+   method     toString()
     [exec] 			+   return     java.lang.String
     [exec] 	<   class      com.liferay.frontend.taglib.servlet.taglib.SidebarPanelTag
     [exec] 		+   method     getCloseButton()
     [exec] 			+   return     boolean
     [exec] 		+   method     setCloseButton(boolean)
     [exec] 			+   return     void
     [exec] 	+   version    2.5.0
     [exec] 	-   version    2.6.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] 
     [exec] > Task :apps:frontend-taglib:frontend-taglib:syncVersions
     [exec] 
     [exec] > Task :apps:content-dashboard:content-dashboard-web:generateJSPJava
     [exec] Compiling JSP files of project ':apps:content-dashboard:content-dashboard-web' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.40/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'
     [exec] Note: Some input files use or override a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] 
     [exec] > Task :apps:content-dashboard:content-dashboard-web:compileJSP
     [exec] 
     [exec] 
     [exec] FAILURE: Build completed with 3 failures.
     [exec] 
     [exec] 1: Task failed with an exception.
     [exec] -----------
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:frontend-taglib:frontend-taglib-react:baseline'.
     [exec] > A failure occurred while executing com.liferay.gradle.plugins.baseline.internal.work.BaselineWorkAction
     [exec]    > org.gradle.api.GradleException: Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.frontend.taglib.react-5.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.frontend.taglib.react/4.1.2/ec050fd1c3aa0f51ab209177255ba6f126eabeef/com.liferay.frontend.taglib.react-4.1.2.jar

julien · 2021-02-22T12:04:26Z

ci:forward

liferay-continuous-integration · 2021-02-22T12:04:30Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-02-22T12:04:31Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2021-02-22T12:05:32Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2021-02-22T12:05:49Z

Pull request has been successfully forwarded to brianchandotcom#99019

liferay-continuous-integration · 2021-02-22T12:18:48Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7581
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#773
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - cgoncas > liferay-frontend - PR#773 - 2021-02-22[02:23:42]
Spira Jenkins Build:publish-spira-report#16114

balazssk · 2021-02-22T15:12:10Z

Hi folks,
Big thanks for helping with this issue, especially for providing broader use-cases by @cgoncas and the help with porting and fixing the react component @julien

julien · 2021-02-22T16:24:13Z

@balazssk , no problem we're always happy to help

cgoncas changed the title ~~LPS-127308 Add same logic for assetTagId and authorIds.~~ LPS-127308 [TS] [Bug: 7.3.x, master] LPS-127308 Category Filters are removed when doing a text search in Content Dashboard Feb 9, 2021

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - failure and removed ci:test:sf - pending labels Feb 9, 2021

cgoncas force-pushed the pr-855 branch from e6887c6 to 6ff0055 Compare February 9, 2021 09:50

liferay-continuous-integration added ci:test:stop - pending ci:test:stop - failure and removed ci:test:stop - pending labels Feb 9, 2021

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - failure ci:test:sf - pending labels Feb 9, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 9, 2021

Julien Castelain added 2 commits February 22, 2021 11:17

LPS-127308 Migrate usages of <clay:management-toolbar-v2/> in conte…

34b57fc

…nt-dashboard-web The clay management toolbar component has been migrated to the new version using React components. All features previously handled by the management toolbar should still work as expected

LPS-127308 Add missing selectAuthor function

e011990

julien force-pushed the pr-855 branch from 92951e5 to e011990 Compare February 22, 2021 10:17

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Feb 22, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending and removed ci:test:relevant - success ci:test:stable - success labels Feb 22, 2021

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 22, 2021

liferay-continuous-integration mentioned this pull request Feb 22, 2021

LPS-127308 [TS] [Bug: 7.3.x, master] LPS-127308 Category Filters are removed when doing a text search in Content Dashboard brianchandotcom/liferay-portal#99019

Closed

liferay-continuous-integration closed this Feb 22, 2021

LPS-127308 [TS] [Bug: 7.3.x, master] LPS-127308 Category Filters are removed when doing a text search in Content Dashboard #773

LPS-127308 [TS] [Bug: 7.3.x, master] LPS-127308 Category Filters are removed when doing a text search in Content Dashboard #773

Conversation

cgoncas commented Feb 9, 2021 • edited

liferay-continuous-integration commented Feb 9, 2021

liferay-continuous-integration commented Feb 9, 2021

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

cgoncas commented Feb 9, 2021

cgoncas commented Feb 9, 2021

liferay-continuous-integration commented Feb 9, 2021

❌ ci:test:stop - 0 out of 1 jobs passed in 9 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.

liferay-continuous-integration commented Feb 9, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Base Branch:

Sender Branch:

For more details click here.

cgoncas commented Feb 9, 2021

liferay-continuous-integration commented Feb 9, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 2 days 23 hours 35 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

julien commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 25 minutes

Base Branch:

Sender Branch:

For more details click here.

julien commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 1 hour 36 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

julien commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

balazssk commented Feb 22, 2021

julien commented Feb 22, 2021

cgoncas commented Feb 9, 2021 •

edited