Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] LPS-114817 #137

Conversation

jonathanmccann
Copy link
Collaborator

@jonathanmccann jonathanmccann commented Jun 2, 2020

It seems that the trigger of updating FileEntry is still necessary but feel free to remove it if that was errant to begin with.

Also, I believe this is the solution but not entirely positive based on the AM framework. If you'd like it implemented in a different way or location please let me know.

Thanks.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@jonathanmccann
Copy link
Collaborator Author

ci:test:sf

@jonathanmccann
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b05cdaba944307f1150b2476879c9114a2db9949

Sender Branch:

Branch Name: LPS-114817
Branch GIT ID: 54c9034b80f69a26afc819b925cd32302c276ffa

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 19 out of 19 jobs passed

✔️ ci:test:relevant - 49 out of 49 jobs passed in 1 hour 30 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6019458ffab0951e19b83b6449fc41b0ffd1feb0

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6781f47bc448a9efe3c4df1eac5c1b8c4fc86c4e

ci:test:stable - 19 out of 19 jobs PASSED
19 Successful Jobs:
ci:test:relevant - 49 out of 49 jobs PASSED
49 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@adolfopa
Copy link
Collaborator

adolfopa commented Jun 3, 2020

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#89557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants