Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-138401 The asset title with script in the sharing pop-up window can not be displayed correctly #2263

Closed
wants to merge 1 commit into from
Closed

LPS-138401 The asset title with script in the sharing pop-up window can not be displayed correctly #2263

wants to merge 1 commit into from

Conversation

AliciaGarciaGarcia
Copy link
Collaborator

@AliciaGarciaGarcia AliciaGarciaGarcia commented Sep 8, 2021 •
edited by boton
Loading

@liferay-continuous-integration
Copy link
Collaborator

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@AliciaGarciaGarcia
Copy link
Collaborator Author

ci:test:relevant

@AliciaGarciaGarcia
Copy link
Collaborator Author

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 46d03043c8db8ab6e3b77f1769215bd41cb158b1

Sender Branch:

Branch Name: LPS-138401
Branch GIT ID: e295833e2d31e961e109d62af80a129308181193

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@boton boton changed the title LPS-138401 No longer needed because modals now escape characters (Liferay.Util.openModal is now on react) LPS-138401 The asset title with script in the sharing pop-up window can not be displayed correctly Sep 9, 2021
boton
boton approved these changes Sep 9, 2021
View reviewed changes
Copy link
Collaborator

@boton boton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fix this bug with @AliciaGarciaGarcia, and now the HTML tags are properly escaped by React.

Before PR
image

After PR
image

In neither case is an alert prompted.

@boton
Copy link
Collaborator

boton commented Sep 9, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 23 out of 24 jobs passed in 2 hours 31 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 46d03043c8db8ab6e3b77f1769215bd41cb158b1

Upstream Comparison:

Branch GIT ID: 37aa65e39060ba9970219977c3c117655f054989
Jenkins Build URL: Acceptance Upstream DXP (master) #2300

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 22 out of 24 jobs PASSED
22 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 37aa65e:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    571 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=1 #442639
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration liferay-continuous-integration mentioned this pull request Sep 9, 2021
Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#106881
Console

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boton boton boton approved these changes

Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success 🔍 frontend review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AliciaGarciaGarcia @liferay-continuous-integration @boton