Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-139710 Remove support for Web Content field in Document Types #2345

Closed
wants to merge 2 commits into from
Closed

LPS-139710 Remove support for Web Content field in Document Types #2345

wants to merge 2 commits into from

Conversation

adolfopa
Copy link
Collaborator

No description provided.

@adolfopa
LPS-139710 Remove Journal field from DM
f5b3009 
This was an accidental feature that is causing circularity problems
with Staging. Removing it, as we don't want to explicitly support this
use case.
@adolfopa
LPS-139710 Add breaking change note
adc09bc
@liferay-continuous-integration
Copy link
Collaborator

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@adolfopa
Copy link
Collaborator Author

/cc @ealonso

@adolfopa
Copy link
Collaborator Author

ci:test:sf

@adolfopa
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 9 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fda430587b0211e362c69c5b387d9db14490ca89

Sender Branch:

Branch Name: LPS-139710
Branch GIT ID: adc09bc9d6a50fa75d54f9553780c94ea3222ea6

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@AliciaGarciaGarcia
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 25 out of 25 jobs passed in 4 hours 58 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fda430587b0211e362c69c5b387d9db14490ca89

Upstream Comparison:

Branch GIT ID: 6fa77fbbc8f10e3fb7418bb2b75a7a62de2143de
Jenkins Build URL: Acceptance Upstream DXP (master) #2369

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 25 out of 25 jobs PASSED
25 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 22 out of 25 jobs passed in 2 hours 50 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1307401_678

Base Branch:

Branch Name: master
Branch GIT ID: fda430587b0211e362c69c5b387d9db14490ca89

Upstream Comparison:

Branch GIT ID: 6fa77fbbc8f10e3fb7418bb2b75a7a62de2143de
Jenkins Build URL: Acceptance Upstream DXP (master) #2369

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 22 out of 25 jobs PASSED
22 Successful Jobs:
For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at 6fa77fb:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1976 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=2 #6962
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
com.liferay.portal.verify.VerifyException: com.liferay.commerce.currency.exception.NoSuchCurrencyException: No CommerceCurrency exists with the key {companyId=20100, code=USD}
com.liferay.portal.verify.VerifyException: com.liferay.commerce.currency.exception.NoSuchCurrencyException: No CommerceCurrency exists with the key {companyId=20100, code=USD}
	at com.liferay.portal.verify.VerifyProcess.verify(VerifyProcess.java:84)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands.executeVerifyProcesses(VerifyProcessTrackerOSGiCommands.java:293)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands$1.run(VerifyProcessTrackerOSGiCommands.java:345)
	at com.liferay.portal.output.stream.container.internal.OutputStreamContainerFactoryTrackerImpl.runWithSwappedLog(OutputStreamContainerFactoryTrackerImpl.java:134)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands.executeVerifyProcesses(VerifyProcessTrackerOSGiCommands.java:340)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands._execute(VerifyProcessTrackerOSGiCommands.java:394)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands.access$200(VerifyProcessTrackerOSGiCommands.java:79)
	at com.liferay.portal.verify.extender.internal.osgi.commands.VerifyProcessTrackerOSGiCommands$VerifyServic...

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#108057
Console

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliciaGarciaGarcia AliciaGarciaGarcia AliciaGarciaGarcia approved these changes

Assignees
No one assigned
Labels
🔍 backend review needed ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adolfopa @liferay-continuous-integration @AliciaGarciaGarcia