-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS] LPS-141218 Remove unnecessary heading element and keep headings in sequentially-descending order #2416
Conversation
…quentially-descending order
Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery. |
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
ci:test:sf |
ci:test:relevant |
Hi @liferay-lima , |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-141218-master 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#361 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-lima#2416 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#1234 |
✔️ ci:test:stable - 10 out of 10 jobs passed❌ ci:test:relevant - 22 out of 26 jobs passed in 1 hour 35 minutesClick here for more details.This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result: ci:reevaluate:1337401_426 Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 6231ae48877fa66223a6c766b1825cfc6d94f30f ci:test:stable - 10 out of 10 jobs PASSED10 Successful Jobs:
ci:test:relevant - 22 out of 26 jobs PASSED4 Failed Jobs:22 Successful Jobs:
For more details click here.Failures unique to this pull:
Failures in common with acceptance upstream results at 6231ae4:
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#426 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-lima#2416 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - orsolyaDekany > liferay-lima - PR#2416 - 2021-10-25[09:11:02] Testray Importer:publish-testray-report#1238 |
ci:test:relevant |
❌ ci:test:stable - 9 out of 10 jobs passed❌ ci:test:relevant - 19 out of 26 jobs passed in 1 hour 45 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 0afdb973c976ee893c688a7500b22b58c777fca0 ci:test:stable - 9 out of 10 jobs PASSED9 Successful Jobs:
ci:test:relevant - 19 out of 26 jobs PASSED7 Failed Jobs:
19 Successful Jobs:
For more details click here.Failures unique to this pull:
For upstream results, click here. |
Jenkins Build:test-portal-acceptance-pullrequest(master)#870 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-lima#2416 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - orsolyaDekany > liferay-lima - PR#2416 - 2021-10-25[18:32:24] Testray Importer:publish-testray-report#2722 |
ci:test:relevant |
✔️ ci:test:stable - 10 out of 10 jobs passed✔️ ci:test:relevant - 25 out of 26 jobs passed in 1 hour 57 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 6dc7d3bbdc0d8c034ccab8c808b5218ce2705e5b ci:test:stable - 10 out of 10 jobs PASSED10 Successful Jobs:
ci:test:relevant - 24 out of 26 jobs PASSED2 Failed Jobs:24 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at 6dc7d3b:
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#751 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-lima#2416 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - orsolyaDekany > liferay-lima - PR#2416 - 2021-10-25[23:39:26] Testray Importer:publish-testray-report#2162 |
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Skipping previously passed test suites: |
All required test suite(s) passed. |
Pull request has been successfully forwarded to brianchandotcom#109066 |
Hello,
We have incorrect heading hierarchy in Message Board, h4 tag is followed by h5.
Small fix for removing an unnecessary heading element h5. Similarly to LPS-139932
LPS ticket: LPS-141218
Can you please review it?
Thank you!