LPS-152935 Use always trash icon and "delete" label for removal action regardless of having recycle bin or not #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n regardless of having recycle bin or not
|
ci:test:sf |
|
ci:test:relevant |
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-152935_trash 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#171 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-lima#3011 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#623 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#1059 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-lima#3011 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - victorg1991 > liferay-lima - PR#3011 - 2022-05-05[04:09:14] Testray Importer:publish-testray-report#2475 |
|
ci:test:relevant |
✔️ ci:test:stable - 27 out of 27 jobs passed✔️ ci:test:relevant - 235 out of 239 jobs passed in 1 hour 48 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 7008b458c98cefda48c3d8c99528183e322d8491 ci:test:stable - 27 out of 27 jobs PASSED27 Successful Jobs:
ci:test:relevant - 234 out of 239 jobs PASSED5 Failed Jobs:234 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at 7008b45:
|
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#3342 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-lima#3011 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - victorg1991 > liferay-lima - PR#3011 - 2022-05-08[18:52:23] Testray Importer:publish-testray-report#9382 |
| @@ -701,7 +701,7 @@ public void addMoveToTheRecycleBinToolbarItem( | |||
| _addJavaScriptUIItem( | |||
| new JavaScriptToolbarItem(), toolbarItems, | |||
| DLUIItemKeys.MOVE_TO_THE_RECYCLE_BIN, | |||
| LanguageUtil.get(_resourceBundle, "move-to-recycle-bin"), | |||
| LanguageUtil.get(_resourceBundle, "delete"), | |||
There was a problem hiding this comment.
Here we may also want to rename the method ( addMoveToTheRecycleBinToolbarItem to addDeleteToolbarItem).
There was a problem hiding this comment.
I believe the meaning is the same, we are only changing the label. This is still the Move to the recycle bin action, isn't it?
There was a problem hiding this comment.
Ok, I see your point. Then we can leave the method name as it is... thanks!
ambrinchaudhary
approved these changes
May 9, 2022
boton
approved these changes
May 9, 2022
adolfopa
approved these changes
May 9, 2022
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites: |
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-152935_trash 1 Successful Jobs:For more details click here. |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#117114 |
|
Jenkins Build:test-portal-source-format#1990 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-lima#3011 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#7248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello good people of Lima 👋 😄
There is an initiative from design to normalize the use of "delete" action regardless of the presence of recycle bin or not :)
This PR changes all the labels to "delete" and all the icons to "trash"
Any questions/comments are welcome : D