LPS-115816 change InfoFormValues to InfoItemFieldValues on names used #306
Conversation
Why? 1) In reality this is not tied to a form, that's just one use case. So just referring to it as "Field Values" is more accurate 2) Since it provides a way to keep a reference to the InfoItem where the values come from, it should not just be InfoFieldValues but InfoItemFieldValues
…to the InfoItem the values are from It was already assumed in some client code that the reference would exist, but the API was not enforcing it, which could have led to NullPointerException errors at one point. Not anymore :)
…a given item object This provider will allow simplifying InfoItemFormProvider by removing the methods related to retrieving values
…es with usages of the new InfoItemFieldValuesProvider
…r since they are no longer used
…o an implementation of InfoItemFieldValuesProvider Extract field definitions into the new JournalArticleInfoItemFields interface to avoid duplication
… implementation of InfoItemFieldValuesProvider Extract field definitions into the new BlogsEntryInfoItemFields interface to avoid duplication
… implementation of InfoItemFieldValuesProvider Extract field definitions into the new AssetEntryInfoItemFields interface to avoid duplication
…o register the instances as InfoItemFieldValuesProvider services
…ount into a supplier to avoid a db query if it's not used later Note: this has nothing to do with this ticket, but it's a super small fix so I decided to just do it now
…ave been accidentally reordered while source formatting)
…r for JournalArticle
AliciaGarciaGarcia
force-pushed
the
LPS-115816.5
branch
from
cb2975b
to
4c0fda3
Compare
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-115816.5 1 Successful Jobs:For more details click here. |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#90609 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6450 |
No description provided.