LPS-157505 Refactor KB portlet to use MVC action commands #3236

junit.framework.AssertionFailedError: Incorrect configuration of dependency {compileOnly group: "com.liferay.portal", name: "com.liferay.portal.kernel", version: "default"} in modules/apps/cookies/cookies-test/build.gradle, use one of these instead: "testCompile", "testIntegrationCompile", "testIntegrationRuntime", "testRuntime"
  at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1506)
  at com.liferay.portal.modules.ModulesStructureTest.access$800(ModulesStructureTest.java:68)
  at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:402)
  at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:376)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:374)

modules-semantic-versioning-jdk8/0/4

com.liferay.semantic.versioning.SemanticVersioningTest.testSemanticVersioning[/apps/notification/notification-rest-api]

java.lang.AssertionError:   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
= ================================================== ========== ========== ========== ========== ==========
* com.liferay.notification.rest.dto.v1_0             MINOR      1.1.0      1.1.0      1.2.0      VERSION INCREASE REQUIRED
  +   class      com.liferay.notification.rest.dto.v1_0.NotificationQueueEntry
    +   implements java.io.Serializable
    +   field      actions
      +   access     protected
      +   annotated  com.fasterxml.jackson.annotation.JsonProperty
        +   property   access='READ_ONLY'
      +   annotated  com.liferay.portal.vulcan.graphql.annotation.GraphQLField
      +   annotated  com.liferay.portal.vulcan.graphql.annotation.GraphQLField
      +   return     java.util.Map
    +   field      bcc
      +   access     protected
      +   annotated  com.fasterxml.jackson.annotation.JsonProperty
        +   property   access='READ_WRITE'
      +   annotated  com.liferay.portal.vulcan.graphql.annotation.GraphQLField
      +   annotated  com.liferay.portal.vulcan.graphql.annotation.GraphQLField
      +   return     java.lang.String
    +   field      body
      +   access     protected
      +   annotated  com.fasterxml.jackson.annotation.JsonProperty
        +   property   access='READ_WRITE'
      +   annotated  com.liferay.portal.vulcan.graphql.annotation.GraphQLField
      +   annotated  com.liferay.portal.vulcan.graphql.annotation.GraphQLField
      +   return     java.lang.Strin...

...

liferay-continuous-integration · 2022-07-11T17:15:52Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#3606

Jenkins Report:jenkins-report.html

Jenkins Suite:knowledge-base

Pull Request:liferay-lima#3236

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:knowledge-base - adolfopa > liferay-lima - PR#3236 - 2022-07-11[08:34:24]

Testray Importer:publish-testray-report#9401

… the only usage had been removed by LPS-61900(0991053)

liferay-continuous-integration · 2022-07-12T09:50:46Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fc48ef9852786b74b8c9d4a6c55faf831429fb34

Sender Branch:

Branch Name: LPS-157505
Branch GIT ID: 4b7cdb307c832516677ff610b2303edce65d66df

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2022-07-12T09:53:42Z

Jenkins Build:test-portal-source-format#6435

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-lima#3236

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - adolfopa > liferay-lima - PR#3236 - 2022-07-12[02:45:29]

Testray Importer:publish-testray-report#2693

liferay-continuous-integration · 2022-07-12T12:22:08Z

✔️ ci:test:stable - 26 out of 26 jobs passed

✔️ ci:test:relevant - 48 out of 49 jobs passed in 2 hours 25 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fc48ef9852786b74b8c9d4a6c55faf831429fb34

Upstream Comparison:

Branch GIT ID: fc48ef9852786b74b8c9d4a6c55faf831429fb34
Jenkins Build URL: Acceptance Upstream DXP (master) #3538

ci:test:stable - 26 out of 26 jobs PASSED

26 Successful Jobs:

functional-smoke-tomcat90-mysql57-jdk8_stable
- functional-smoke-tomcat90-mysql57-jdk8_stable/0/0
functional-upgrade-tomcat90-mysql57-jdk8_stable
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/0
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/1
modules-compile-jdk8
modules-integration-mysql57-jdk8_stable
modules-unit-jdk8_stable
- modules-unit-jdk8_stable/0/0
pmd-jdk8
- pmd-jdk8/0/0
portal-license-smoke-jdk8
- portal-license-smoke-jdk8/0/0
rest-builder-jdk8
- rest-builder-jdk8/0/0
service-builder-jdk8
- service-builder-jdk8/0/0
unit-jdk8_stable
- unit-jdk8_stable/0/0

ci:test:relevant - 47 out of 49 jobs PASSED

2 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
central-requirements-jdk8
- ~~central-requirements-jdk8/0/0~~

47 Successful Jobs:

empty-osgi-core-dir-jdk8
- empty-osgi-core-dir-jdk8/0/0
empty-temp-dir-jdk8
- empty-temp-dir-jdk8/0/0
functional-smoke-tomcat90-mysql57-jdk11_open
- functional-smoke-tomcat90-mysql57-jdk11_open/0/0
functional-smoke-tomcat90-mysql57-jdk8_stable
- functional-smoke-tomcat90-mysql57-jdk8_stable/0/0
functional-smoke-wildfly180-mariadb104-jdk8
- functional-smoke-wildfly180-mariadb104-jdk8/0/0
functional-tomcat90-mysql57-jdk8
- functional-tomcat90-mysql57-jdk8/0/0
- functional-tomcat90-mysql57-jdk8/0/1
functional-upgrade-tomcat90-mysql57-jdk8
- functional-upgrade-tomcat90-mysql57-jdk8/0/0
- functional-upgrade-tomcat90-mysql57-jdk8/0/1
- functional-upgrade-tomcat90-mysql57-jdk8/0/2
- functional-upgrade-tomcat90-mysql57-jdk8/0/3
functional-upgrade-tomcat90-mysql57-jdk8_stable
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/0
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/1
lpkg-controller-jdk8
- lpkg-controller-jdk8/0/0
modules-compile-jdk8
- modules-compile-jdk8/0/0
- modules-compile-jdk8/0/1
- modules-compile-jdk8/0/2
- modules-compile-jdk8/0/3
- modules-compile-jdk8/0/4
- modules-compile-jdk8/0/5
- modules-compile-jdk8/0/6
- modules-compile-jdk8/0/7
- modules-compile-jdk8/0/8
- modules-compile-jdk8/0/9
- modules-compile-jdk8/0/10
- modules-compile-jdk8/0/11
- modules-compile-jdk8/0/12
- modules-compile-jdk8/0/13
modules-integration-mysql57-jdk8
- modules-integration-mysql57-jdk8/0/0
- modules-integration-mysql57-jdk8/0/1
- modules-integration-mysql57-jdk8/0/2
modules-integration-mysql57-jdk8_stable
- modules-integration-mysql57-jdk8_stable/0/0
- modules-integration-mysql57-jdk8_stable/0/1
- modules-integration-mysql57-jdk8_stable/0/2
modules-semantic-versioning-jdk8
- modules-semantic-versioning-jdk8/0/0
modules-unit-jdk8
- modules-unit-jdk8/0/0
modules-unit-jdk8_stable
- modules-unit-jdk8_stable/0/0
modules-unit-project-templates-jdk8
- modules-unit-project-templates-jdk8/0/0
- modules-unit-project-templates-jdk8/0/1
patching-tool-jdk8
- patching-tool-jdk8/0/0
pmd-jdk8
- pmd-jdk8/0/0
portal-license-smoke-jdk8
- portal-license-smoke-jdk8/0/0
rest-builder-jdk8
- rest-builder-jdk8/0/0
semantic-versioning-jdk8
- semantic-versioning-jdk8/0/0
service-builder-jdk8
- service-builder-jdk8/0/0
unit-jdk8
- unit-jdk8/0/0
unit-jdk8_stable
- unit-jdk8_stable/0/0

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at fc48ef9:

central-requirements-jdk8/0/0

com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles

junit.framework.AssertionFailedError: Incorrect configuration of dependency {compileOnly group: "com.liferay.portal", name: "com.liferay.portal.kernel", version: "default"} in modules/apps/cookies/cookies-test/build.gradle, use one of these instead: "testCompile", "testIntegrationCompile", "testIntegrationRuntime", "testRuntime"
  at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1506)
  at com.liferay.portal.modules.ModulesStructureTest.access$800(ModulesStructureTest.java:68)
  at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:402)
  at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:376)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:374)

liferay-continuous-integration · 2022-07-12T12:25:50Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4125

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-lima#3236

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - adolfopa > liferay-lima - PR#3236 - 2022-07-12[02:56:27]

Testray Importer:publish-testray-report#11279

liferay-continuous-integration · 2022-07-12T12:47:43Z

❌ ci:test:knowledge-base - 38 out of 42 jobs passed in 2 hours 53 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fc48ef9852786b74b8c9d4a6c55faf831429fb34

Upstream Comparison:

Branch GIT ID: fc48ef9852786b74b8c9d4a6c55faf831429fb34
Jenkins Build URL: Acceptance Upstream DXP (master) #3538

ci:test:knowledge-base - 38 out of 42 jobs PASSED

4 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
central-requirements-jdk8
- ~~central-requirements-jdk8/0/0~~
modules-semantic-versioning-jdk8
- ~~modules-semantic-versioning-jdk8/0/4~~
- ~~modules-semantic-versioning-jdk8/0/5~~

38 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at fc48ef9:

central-requirements-jdk8/0/0

com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles

junit.framework.AssertionFailedError: Incorrect configuration of dependency {compileOnly group: "com.liferay.portal", name: "com.liferay.portal.kernel", version: "default"} in modules/apps/cookies/cookies-test/build.gradle, use one of these instead: "testCompile", "testIntegrationCompile", "testIntegrationRuntime", "testRuntime"
  at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1506)
  at com.liferay.portal.modules.ModulesStructureTest.access$800(ModulesStructureTest.java:68)
  at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:402)
  at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:376)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:374)

modules-semantic-versioning-jdk8/0/4

com.liferay.semantic.versioning.SemanticVersioningTest.testSemanticVersioning[/apps/notification/notification-rest-api]

java.lang.AssertionError:   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
= ================================================== ========== ========== ========== ========== ==========
* com.liferay.notification.rest.dto.v1_0             MINOR      1.1.0      1.1.0      1.2.0      VERSION INCREASE REQUIRED
  +   class      com.liferay.notification.rest.dto.v1_0.NotificationQueueEntry
    +   implements java.io.Serializable
    +   field      actions
      +   access     protected
      +   annotated  com.fasterxml.jackson.annotation.JsonProperty
        +   property   access='READ_ONLY'
      +   annotated  com.liferay.portal.vulcan.graphql.annotation.GraphQLField
      +   annotated  com.liferay.portal.vulcan.graphql.annotation.GraphQLField
      +   return     java.util.Map
    +   field      bcc
      +   access     protected
      +   annotated  com.fasterxml.jackson.annotation.JsonProperty
        +   property   access='READ_WRITE'
      +   annotated  com.liferay.portal.vulcan.graphql.annotation.GraphQLField
      +   annotated  com.liferay.portal.vulcan.graphql.annotation.GraphQLField
      +   return     java.lang.String
    +   field      body
      +   access     protected
      +   annotated  com.fasterxml.jackson.annotation.JsonProperty
        +   property   access='READ_WRITE'
      +   annotated  com.liferay.portal.vulcan.graphql.annotation.GraphQLField
      +   annotated  com.liferay.portal.vulcan.graphql.annotation.GraphQLField
      +   return     java.lang.Strin...

modules-semantic-versioning-jdk8/0/5

com.liferay.semantic.versioning.SemanticVersioningTest.testSemanticVersioning[/apps/object/object-api]

java.lang.AssertionError:   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
= ================================================== ========== ========== ========== ========== ==========
* com.liferay.object.field.business.type             MAJOR      2.1.0      2.1.0      3.0.0      VERSION INCREASE REQUIRED
  -   interface  com.liferay.object.field.business.type.ObjectFieldBusinessTypeServicesTracker
    -   access     abstract
    -   method     getObjectFieldBusinessType(java.lang.String)
      -   access     abstract
      -   return     com.liferay.object.field.business.type.ObjectFieldBusinessType
    -   method     getObjectFieldBusinessTypes()
      -   access     abstract
      -   return     java.util.List
    -   method     getObjectFieldDBTypes()
      -   access     abstract
      -   return     java.util.Set
  +   interface  com.liferay.object.field.business.type.ObjectFieldBusinessTypeTracker
    +   access     abstract
    +   method     getObjectFieldBusinessType(java.lang.String)
      +   access     abstract
      +   return     com.liferay.object.field.business.type.ObjectFieldBusinessType
    +   method     getObjectFieldBusinessTypes()
      +   access     abstract
      +   return     java.util.List
    +   method     getObjectFieldDBTypes()
      +   access     abstract
      +   return     java.util.Set
* com.liferay.object.field.filter.parser             MAJOR      1.0.0      1.0.0      2.0.0      VERSION INCREASE REQUIRED
  -   interface  com.lif...

liferay-continuous-integration · 2022-07-12T12:50:22Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4002

Jenkins Report:jenkins-report.html

Jenkins Suite:knowledge-base

Pull Request:liferay-lima#3236

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:knowledge-base - adolfopa > liferay-lima - PR#3236 - 2022-07-12[02:54:42]

Testray Importer:publish-testray-report#10186

AliciaGarciaGarcia · 2022-07-12T13:38:24Z

ci:forward

liferay-continuous-integration · 2022-07-12T13:38:30Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2022-07-12T13:38:31Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2022-07-12T13:40:10Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2022-07-12T13:40:25Z

Pull request has been successfully forwarded to brianchandotcom#120241
Console

liferay-content-management added 🔍 backend review needed 🔍 frontend review needed labels Jul 11, 2022

adolfopa requested a review from AliciaGarciaGarcia July 11, 2022 15:20

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - pending labels Jul 11, 2022

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels Jul 11, 2022

adolfopa force-pushed the LPS-157505 branch from 9b031f8 to 22aeff1 Compare July 11, 2022 15:33

liferay-continuous-integration added the ci:test:knowledge-base - pending label Jul 11, 2022

liferay-continuous-integration added ci:test:knowledge-base - failure and removed ci:test:knowledge-base - pending labels Jul 11, 2022

zhangyan0701 and others added 5 commits July 11, 2022 20:38

LRQA-73324 Import org.apache.xerces.parsers in s3 test module

a11c22a

LPS-157454 Remove parameter "contextObjects", no one is using it now,…

37ef8ae

… the only usage had been removed by LPS-61900(0991053)

LPS-157454 Cache NavItem list to theme display for reuse later

1553594

LPS-157454 Apply usages

5ac349a

LPS-157454 Remove unused method

66925ff

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Jul 12, 2022

liferay-continuous-integration added ci:test:knowledge-base - failure and removed ci:test:knowledge-base - pending labels Jul 12, 2022

AliciaGarciaGarcia approved these changes Jul 12, 2022

View reviewed changes

liferay-continuous-integration mentioned this pull request Jul 12, 2022

LPS-157505 Refactor KB portlet to use MVC action commands brianchandotcom/liferay-portal#120241

Closed

liferay-continuous-integration closed this Jul 12, 2022

LPS-157505 Refactor KB portlet to use MVC action commands #3236

LPS-157505 Refactor KB portlet to use MVC action commands #3236

Conversation

adolfopa commented Jul 11, 2022

liferay-content-management commented Jul 11, 2022

liferay-content-management commented Jul 11, 2022

liferay-continuous-integration commented Jul 11, 2022

liferay-continuous-integration commented Jul 11, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jul 11, 2022

adolfopa commented Jul 11, 2022

liferay-continuous-integration commented Jul 11, 2022

❌ ci:test:relevant - 0 out of 1 jobs passed in 14 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.

adolfopa commented Jul 11, 2022

liferay-continuous-integration commented Jul 11, 2022

liferay-continuous-integration commented Jul 11, 2022

❌ ci:test:knowledge-base - 35 out of 42 jobs passed in 1 hour 37 minutes

Base Branch:

Upstream Comparison:

7 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Jul 11, 2022

liferay-continuous-integration commented Jul 12, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jul 12, 2022

liferay-continuous-integration commented Jul 12, 2022

✔️ ci:test:stable - 26 out of 26 jobs passed

✔️ ci:test:relevant - 48 out of 49 jobs passed in 2 hours 25 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

liferay-continuous-integration commented Jul 12, 2022

liferay-continuous-integration commented Jul 12, 2022

❌ ci:test:knowledge-base - 38 out of 42 jobs passed in 2 hours 53 minutes

Base Branch:

Upstream Comparison:

4 Failed Jobs:

For more details click here.

This pull contains no unique failures.

liferay-continuous-integration commented Jul 12, 2022

AliciaGarciaGarcia commented Jul 12, 2022

liferay-continuous-integration commented Jul 12, 2022

liferay-continuous-integration commented Jul 12, 2022

liferay-continuous-integration commented Jul 12, 2022

liferay-continuous-integration commented Jul 12, 2022