LPS-149618 Add condition when ddmFormFieldType is fieldset #504

@@ -315,7 +315,9 @@ private long _getObjectDefinitionId(
 			DDMFormField ddmFormField = ddmFormFieldsMap.get(
 				ddmFormFieldValue.getName());

-			if (ddmFormField.isTransient()) {
+			if (ddmFormField.isTransient() &&
+				!StringUtil.equals(ddmFormField.getType(), "fieldset")) {


@danvb112 can you use DDMFormFieldTypeConstants.FIELDSET here?

danvb112 · 2022-03-18T20:48:52Z

ci:test:sf

liferay-continuous-integration · 2022-03-18T20:51:45Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 55f13bee30428986f588a75e14319d3697d7fa87

Sender Branch:

Branch Name: LPS-149618
Branch GIT ID: a032a2e136b397a54d540524eddcdbbc14ec15eb

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2022-03-18T21:45:45Z

❌ ci:test:relevant - 0 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 55f13bee30428986f588a75e14319d3697d7fa87

Upstream Comparison:

Branch GIT ID: 3b7d86f190ce40d1b041500ab66ece2273f291f0
Jenkins Build URL: Acceptance Upstream DXP (master) #3044

ci:test:relevant - 0 out of 1 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)
Job Results:
0 Jobs Passed.
1 Job Failed.
The sender branch SHA could not be found on danvb112/LPS-149618. The sender branch may have been force pushed or deleted after the pull request test was initiated.
```
fatal: Not a valid branch point: 'aaef2031dc0c006786fc9ff470db3278ab484dd9'.
```

For upstream results, click here.

liferay-forms · 2022-03-18T21:45:48Z

Hey @danvb112, can you please check if these failures are related to your changes? Thanks

liferay-continuous-integration · 2022-03-19T04:18:31Z

❌ ci:test:stable - 24 out of 29 jobs passed

❌ ci:test:relevant - 24 out of 30 jobs passed in 6 hours 25 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 55f13bee30428986f588a75e14319d3697d7fa87

Upstream Comparison:

Branch GIT ID: 55f13bee30428986f588a75e14319d3697d7fa87
Jenkins Build URL: Acceptance Upstream DXP (master) #3045

ci:test:stable - 24 out of 29 jobs PASSED

5 Failed Jobs:

24 Successful Jobs:

ci:test:relevant - 24 out of 30 jobs PASSED

6 Failed Jobs:

24 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2

Job Results:

20 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=4 #478447

     [exec] * What went wrong:
     [exec] Execution failed for task ':runPoshi'.
     [exec] > A build operation failed.
     [exec]       Could not write XML test results for com.liferay.poshi.runner.PoshiRunner to file /opt/dev/projects/github/liferay-portal/portal-web/test-results/TEST-com.liferay.poshi.runner.PoshiRunner.xml.
     [exec]    > Could not write XML test results for com.liferay.poshi.runner.PoshiRunner to file /opt/dev/projects/github/liferay-portal/portal-web/test-results/TEST-com.liferay.poshi.runner.PoshiRunner.xml.
     [exec] 
     [exec] * Try:
     [exec] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Get more help at https://help.gradle.org
     [exec] 
     [exec] BUILD FAILED in 1m 56s
     [exec] 
     [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/portal-web/build/reports/profile/profile-2022-03-18-21-37-13.html
     [exec] A fine-grained performance profile is available: use the --scan option.
     [exec] Result: 1
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1892657262.properties
clean-up-selenium-driver:

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null1892657262.properties
clean-up-logs:

[parallel] 2022-03-19 04:39:14.658 INFO  [main][ThemeHotDeployListener:171] 1 theme for minium-theme was unregistered

[parallel] 2022-03-19 04:39:14.920 INFO  [main][ThemeHotDeployListener:171] 1 theme for speedwell-theme was unregistered

[parallel] 2022-03-19 04:39:15.763 INFO  [main][ThemeHotDeployListener:171] 1 theme for classic-theme was unregistered

[parallel] 2022-03-19 04:39:16.210 INFO  [main][ThemeHotDeployListener:171] 1 theme for dialect-theme was unregistered

[parallel] 2022-03-19 04:39:18.464 INFO  [main][ThemeHotDeployListener:171] 1 theme for admin-theme was unregistered

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null1892657262.properties
run-poshi-evaluate-console:

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null21935278.properties
prepare-poshi-runner-properties:

[propertyfile] Updating property file: /opt/dev/projects/github/liferay-portal/.gradle/gradle.properties

[sync-dir] Synchronizing /opt/dev/projects/github/liferay-binaries-cache-2020/.gradle/caches/modules-2/files-2.1 into /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
193 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=5 #456534
  1. LocalFile.CreateObject#CanPublishObjectWithPublishPermission - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at 55f13be:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2
Job Results:
20 Tests Passed.
1 Test Failed.

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #491837

Startup error: Unresolved Requirement(s)

 [parallel]     {name: WikiNodeLocalService, target: null}

[parallel]     {name: WikiPageLocalService, target: null}

[parallel]   }

[parallel]   Declarative Service {id: 5111, name: com.liferay.portal.search.similar.results.web.internal.portlet.SimilarResultsPortlet, unsatisfied references:

[parallel]     {name: _portletSharedSearchRequest, target: null}

[parallel]   }

[parallel]   Declarative Service {id: 5099, name: com.liferay.portal.search.similar.results.web.internal.contributor.asset.publisher.AssetPublisherSimilarResultsContributor, unsatisfied references:

[parallel]     {name: BlogsEntryLocalService, target: null}

[parallel]     {name: WikiPageLocalService, target: null}

[parallel]   }

[parallel] Bundle {id: 1385, name: com.liferay.redirect.web, version: 2.0.24}

[parallel]   Declarative Service {id: 5118, name: com.liferay.redirect.web.internal.portlet.RedirectPortlet, unsatisfied references:

[parallel]     {name: _stagingGroupHelper, target: null}

[parallel]   }

[parallel]   Declarative Service {id: 5117, name: com.liferay.redirect.web.internal.application.list.RedirectPanelApp, unsatisfied references:

[parallel]     {name: Portlet, target: (javax.portlet.name=com_liferay_redirect_web_internal_portlet_RedirectPortlet)}

[parallel]   }

[parallel] 2022-03-19 02:33:54.730 INFO  [main][ServiceProxyFactory:68] Running "Spring Extender Unavailable Component Checker" check result: No issues were found.

[parallel] 2022-03-19 02:38:54.731 ERROR [main][ServiceProxyFactory:278] Service "com.liferay.portal.kernel.util.MimeTypes" is unavailable in 300000 milliseconds while setting field "_mimeTypes" for class "com.liferay.portal.kernel.util.MimeTypesUtil", will retry...

[parallel] 2022-03-19 02:43:54.732 ERROR [main][ServiceProxyFactory:278] Service "com.liferay.portal.kernel.util.MimeTypes" is unavailable in 300000 milliseconds while setting field "_mimeTypes" for class "com.liferay.portal.kernel.util.MimeTypesUtil", will retry...

[parallel] 2022-03-19 02:48:54.732 ERROR [main][ServiceProxyFactory:278] Service "com.liferay.portal.kernel.util.MimeTypes" is unavailable in 300000 milliseconds while setting field "_mimeTypes" for class "com.liferay.portal.kernel.util.MimeTypesUtil", will retry...

[parallel] 2022-03-19 02:53:54.733 ERROR [main][ServiceProxyFactory:278] Service "com.liferay.portal.kernel.util.MimeTypes" is unavailable in 300000 milliseconds while setting field "_mimeTypes" for class "com.liferay.portal.kernel.util.MimeTypesUtil", will retry...

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
193 Tests Passed.
2 Tests Failed.
1. AXIS_VARIABLE=11 #456534
  1. LocalFile.CreateObject#CanViewObjectEntryTitleLongOnRelationshipField - Poshi Report - Poshi Summary - Console Output
2. AXIS_VARIABLE=7 #456534
  1. LocalFile.CreateObject#CanUpdateFieldTypeBeforePublished - Poshi Report - Poshi Summary - Console Output
...

liferay-forms · 2022-03-19T04:18:32Z

Hey @danvb112, can you please check if these failures are related to your changes? Thanks

liferay-continuous-integration · 2022-03-19T04:26:18Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#1048

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-objects#504

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - danvb112 > liferay-objects - PR#504 - 2022-03-18[14:52:27]

Testray Importer:publish-testray-report#2635

danvb112 · 2022-03-21T13:15:56Z

ci:test:relevant

liferay-continuous-integration · 2022-03-21T15:33:25Z

✔️ ci:test:stable - 27 out of 29 jobs passed

✔️ ci:test:relevant - 28 out of 30 jobs passed in 2 hours 15 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0cbc02a8181eb9aaae1a8f0cf824c7d8f51b6247

Upstream Comparison:

Branch GIT ID: 0cbc02a8181eb9aaae1a8f0cf824c7d8f51b6247
Jenkins Build URL: Acceptance Upstream DXP (master) #3047

ci:test:stable - 27 out of 29 jobs PASSED

2 Failed Jobs:

27 Successful Jobs:

ci:test:relevant - 27 out of 30 jobs PASSED

3 Failed Jobs:

27 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 0cbc02a:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #29252

Startup error: Unresolved Requirement(s)

 [parallel]   }
 [parallel]   Declarative Service {id: 3322, name: com.liferay.dynamic.data.mapping.internal.search.spi.model.index.contributor.DDMFormInstanceRecordModelDocumentContributor, unsatisfied references: 
 [parallel]     {name: ddmIndexer, target: null}
 [parallel]   }
 [parallel] Bundle {id: 1390, name: com.liferay.dynamic.data.mapping.taglib, version: 6.0.17}
 [parallel]   Declarative Service {id: 5098, name: com.liferay.dynamic.data.mapping.taglib.internal.security.permission.resource.DDMTemplatePermission, unsatisfied references: 
 [parallel]     {name: ModelResourcePermission, target: (model.class.name=com.liferay.dynamic.data.mapping.model.DDMTemplate)}
 [parallel]   }
 [parallel] Bundle {id: 1395, name: com.liferay.roles.admin.web, version: 5.0.35}
 [parallel]   Declarative Service {id: 5115, name: com.liferay.roles.admin.web.internal.portlet.RolesAdminPortlet, unsatisfied references: 
 [parallel]     {name: _depotConfiguration, target: null}
 [parallel]   }
 [parallel]   Declarative Service {id: 5104, name: com.liferay.roles.admin.web.internal.application.list.RolesPanelApp, unsatisfied references: 
 [parallel]     {name: Portlet, target: (javax.portlet.name=com_liferay_roles_admin_web_portlet_RolesAdminPortlet)}
 [parallel]   }
 [parallel] 2022-03-21 15:06:28.684 INFO  [main][ServiceProxyFactory:68] Running "Spring Extender Unavailable Component Checker" check result: No issues were found.
 [parallel] 2022-03-21 15:11:35.031 ERROR [main][ServiceProxyFactory:278] Service "com.liferay.portal.kernel.util.MimeTypes" is unavailable in 300000 milliseconds while setting field "_mimeTypes" for class "com.liferay.portal.kernel.util.MimeTypesUtil", will retry...
 [parallel] 2022-03-21 15:16:45.323 ERROR [main][ServiceProxyFactory:278] Service "com.liferay.portal.kernel.util.MimeTypes" is unavailable in 300000 milliseconds while setting field "_mimeTypes" for class "com.liferay.portal.kernel.util.MimeTypesUtil", will retry...
 [parallel] 2022-03-21 15:21:56.216 ERROR [main][ServiceProxyFactory:278] Service "com.liferay.portal.kernel.util.MimeTypes" is unavailable in 300000 milliseconds while setting field "_mimeTypes" for class "com.liferay.portal.kernel.util.MimeTypesUtil", will retry...
 [parallel] 2022-03-21 15:26:59.947 ERROR [main][ServiceProxyFactory:278] Service "com.liferay.portal.kernel.util.MimeTypes" is unavailable in 300000 milliseconds while setting field "_mimeTypes" for class "com.liferay.portal.kernel.util.MimeTypesUtil", will retry...

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

924 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=1 #41593

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Unable to find corresponding model impl class for table O_20100_AxsIl97cw
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

liferay-continuous-integration · 2022-03-21T15:49:40Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#722

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-objects#504

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - danvb112 > liferay-objects - PR#504 - 2022-03-21[06:17:24]

Testray Importer:publish-testray-report#1768

danvb112 · 2022-03-21T16:38:17Z

ci:forward

liferay-continuous-integration · 2022-03-21T16:38:22Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2022-03-21T16:38:23Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2022-03-21T16:39:09Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2022-03-21T16:39:23Z

Pull request has been successfully forwarded to brianchandotcom#114956
Console

liferay-forms added the External Team Pull Request sent by any external team or person. label Mar 18, 2022

danvb112 added High Priority This PR should be prioritized. and removed External Team Pull Request sent by any external team or person. labels Mar 18, 2022

liferay-continuous-integration added the ci:test:sf - pending label Mar 18, 2022

danvb112 changed the title ~~LPS-149618~~ LPS-149618 Add condition when ddmFormFieldType is fieldset Mar 18, 2022

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - pending labels Mar 18, 2022

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - success labels Mar 18, 2022

gabrielwas requested changes Mar 18, 2022

View reviewed changes

gabrielwas added the Author Action Required Changes/Questions were requested by the reviewer label Mar 18, 2022

gabrielwas self-assigned this Mar 18, 2022

LPS-149618 Add condition when ddmFormFieldType is fieldset

a032a2e

danvb112 force-pushed the LPS-149618 branch from aaef203 to a032a2e Compare March 18, 2022 20:47

danvb112 removed the Author Action Required Changes/Questions were requested by the reviewer label Mar 18, 2022

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Mar 18, 2022

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - failure ci:test:relevant - pending ci:test:stable - pending labels Mar 18, 2022

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Mar 21, 2022

liferay-continuous-integration mentioned this pull request Mar 21, 2022

LPS-149618 Add condition when ddmFormFieldType is fieldset brianchandotcom/liferay-portal#114956

Closed

liferay-continuous-integration closed this Mar 21, 2022

LPS-149618 Add condition when ddmFormFieldType is fieldset #504

LPS-149618 Add condition when ddmFormFieldType is fieldset #504

Conversation

danvb112 commented Mar 18, 2022 • edited by liferay-forms Loading

liferay-forms commented Mar 18, 2022

liferay-forms commented Mar 18, 2022

liferay-continuous-integration commented Mar 18, 2022

liferay-continuous-integration commented Mar 18, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-forms commented Mar 18, 2022

liferay-continuous-integration commented Mar 18, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-forms commented Mar 18, 2022

liferay-continuous-integration commented Mar 18, 2022

liferay-continuous-integration commented Mar 18, 2022

Choose a reason for hiding this comment

danvb112 commented Mar 18, 2022

liferay-continuous-integration commented Mar 18, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Mar 18, 2022

❌ ci:test:relevant - 0 out of 1 jobs passed in 4 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

For upstream results, click here.

liferay-forms commented Mar 18, 2022

liferay-continuous-integration commented Mar 19, 2022

❌ ci:test:stable - 24 out of 29 jobs passed

❌ ci:test:relevant - 24 out of 30 jobs passed in 6 hours 25 minutes

Base Branch:

Upstream Comparison:

5 Failed Jobs:

6 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

liferay-forms commented Mar 19, 2022

liferay-continuous-integration commented Mar 19, 2022

danvb112 commented Mar 21, 2022

liferay-continuous-integration commented Mar 21, 2022

✔️ ci:test:stable - 27 out of 29 jobs passed

✔️ ci:test:relevant - 28 out of 30 jobs passed in 2 hours 15 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

3 Failed Jobs:

For more details click here.

This pull contains no unique failures.

Job Results:

Job Results:

liferay-continuous-integration commented Mar 21, 2022

danvb112 commented Mar 21, 2022

liferay-continuous-integration commented Mar 21, 2022

liferay-continuous-integration commented Mar 21, 2022

liferay-continuous-integration commented Mar 21, 2022

liferay-continuous-integration commented Mar 21, 2022

danvb112 commented Mar 18, 2022 •

edited by liferay-forms

Loading