-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-140482 Filtering out Google Drive Shortcuts #1729
Conversation
Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery. |
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
booleanFilter.addTerm( | ||
"classTypeId", | ||
String.valueOf(googleDocsDLFileEntryType.getFileEntryTypeId()), | ||
BooleanClauseOccur.MUST_NOT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YurenaC this is how I've negated it.
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-140482 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#402 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-tango#1729 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#1348 |
✔️ ci:test:stable - 11 out of 11 jobs passed❌ ci:test:relevant - 23 out of 26 jobs passed in 2 hours 4 minutesClick here for more details.This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result: ci:reevaluate:1337401_458 Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 214ee2e68be9acbc25df7a28c19de82a919f021c ci:test:stable - 11 out of 11 jobs PASSED11 Successful Jobs:
ci:test:relevant - 23 out of 26 jobs PASSED3 Failed Jobs:23 Successful Jobs:
For more details click here.Failures unique to this pull:
Failures in common with acceptance upstream results at 214ee2e:
|
ci:reevaluate:1337401_458 |
CI is reevaluating the build with build ID: |
Previous ✔️ ci:test:stable - 11 out of 11 jobs passed❌ ci:test:relevant - 23 out of 26 jobs passed in 2 hours 7 minutesClick here for more details.This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result: ci:reevaluate:1337401_458 Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 214ee2e68be9acbc25df7a28c19de82a919f021c ci:test:stable - 11 out of 11 jobs PASSED11 Successful Jobs:
ci:test:relevant - 23 out of 26 jobs PASSED3 Failed Jobs:23 Successful Jobs:
For more details click here.Failures unique to this pull:
Failures in common with acceptance upstream results at 214ee2e:
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#458 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-tango#1729 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - 4lejandrito > liferay-tango - PR#1729 - 2021-11-03[05:50:48] Testray Importer:publish-testray-report#1352 |
ci:reevaluate:1337401_458 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#769 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-tango#1729 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - 4lejandrito > liferay-tango - PR#1729 - 2021-11-03[09:31:39] Testray Importer:publish-testray-report#2220 |
- Content dashboard table - Contentdashboard subtype filter
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-140482 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#757 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-tango#1729 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#2553 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
All required test suite(s) passed. |
Pull request has been successfully forwarded to brianchandotcom#109472 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#1076 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-tango#1729 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - 4lejandrito > liferay-tango - PR#1729 - 2021-11-04[01:17:55] Testray Importer:publish-testray-report#3243 |
This filters out Google Drive Shortcuts in the Content Dashboard.
Pending things
@YurenaC @beltranrengifo I'll leave you those to you guys for now.