LPS-101448 Collections Variations to be reordered for prioritization purposes while accessing the details #1992

YurenaC · 2021-12-21T10:09:27Z

Motivation

Variations have to be reorderable for prioritization, in case a user belongs to multiple segments.

Proposed Solution

We are saving in db a priority value, that equals the index in the variations list.
The reordenation can be done via DnD, or vía click event.
The priority is saved every time the user alters the order of the list.
All the JSP has been migrated to React.

Steps to Verify:

Enable FF: echo "enabled=B\"true\"" > ../bundles/osgi/configs/com.liferay.asset.list.web.internal.configuration.FFCollectionsVariationsPrioritizationConfiguration.config
Navigate to Site Builder > Collections
Create new collection, manual or dynamic
An initial state with only the default variation should be visible
Finish the variation configuration
Navigate to Add new segment view
Create one or more segments
Navigate back to Collections
Add the created segments to your Collection
Change the order in the list and check everything get saved

…mentsEntryRelId to frontend JSON object

…v list

- Priority is set by the array order

- When variations are reorder, should call that URL automatically

…sses

liferay-continuous-integration · 2021-12-22T08:45:50Z

❌ ci:test:relevant - 0 out of 1 jobs passed in 38 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ad36b8c4f2c0a9f5be5f304ba88eb629ba12a85a

Upstream Comparison:

Branch GIT ID: 411a2a7cb1af6aec1f98cc55c22ae4fa11822fa2
Jenkins Build URL: Acceptance Upstream DXP (master) #2727

ci:test:relevant - 0 out of 1 jobs PASSED

For more details click here.

liferay-continuous-integration · 2021-12-22T08:50:53Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#184

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-tango#1992

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - YurenaC > liferay-tango - PR#1992 - 2021-12-21[23:27:39]

Testray Importer:publish-testray-report#396

YurenaC · 2021-12-22T12:27:31Z

ci:test:relevant

liferay-continuous-integration · 2021-12-22T14:39:37Z

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 26 out of 29 jobs passed in 2 hours 11 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ad36b8c4f2c0a9f5be5f304ba88eb629ba12a85a

Upstream Comparison:

Branch GIT ID: ad36b8c4f2c0a9f5be5f304ba88eb629ba12a85a
Jenkins Build URL: Acceptance Upstream DXP (master) #2729

ci:test:stable - 11 out of 11 jobs PASSED

11 Successful Jobs:

ci:test:relevant - 25 out of 29 jobs PASSED

4 Failed Jobs:

25 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at ad36b8c:

test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8/0

Job Results:

6 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0 #20849

com.liferay.portal.modules.ModulesStructureTest.testScanBuildScripts

junit.framework.AssertionFailedError: Forbidden modules/test/poshi/poshi-standalone/gradle.properties
	at com.liferay.portal.modules.ModulesStructureTest$2.preVisitDirectory(ModulesStructureTest.java:229)
	at com.liferay.portal.modules.ModulesStructureTest$2.preVisitDirectory(ModulesStructureTest.java:168)
	at java.nio.file.Files.walkFileTree(Files.java:2677)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.modules.ModulesStructureTest.testScanBuildScripts(ModulesStructureTest.java:166)

com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles

junit.framework.AssertionFailedError: Artifact dependency {classpath group: "com.liferay", name: "com.liferay.gradle.plugins.source.formatter", version: "latest.release"} in modules/test/poshi/poshi-standalone/build.gradle not permitted on master branch. Use a project dependency instead.
	at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1448)
	at com.liferay.portal.modules.ModulesStructureTest.access$800(ModulesStructureTest.java:68)
	at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:398)
	at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:372)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:370)

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

3 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0 #14689

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: 
Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1640182085486.log:
!SESSION 2021-12-22 14:08:25.261 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_121
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
!ENTRY com.liferay.site.initializer.extender 4 0 2021-12-22 14:08:25.262

!MESSAGE FrameworkEvent ERROR

!STACK 0

org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [571]

Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"
at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)


at com.lifer...</code></pre></div></li><li><div><a href="https://test-1-33.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0/14689//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanXMLLog">com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog</a><pre><code>junit.framework.AssertionFailedError: 

FrameworkEvent ERROR

org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [571]

Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"
at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
at java.nio.file.Files.walkFileTree(Files.java:2670)
at java.nio.file.Files.walkFileTree(Files.java:2742)
at com.liferay.portal.log.asser...</code></pre></div></li></ol></div></li></ol></div></li><li><div><h5><a href="https://test-1-23.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/335899/">test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0</a></h5><div><h6>Job Results:</h6><p>2713 Tests Passed.<br/>2 Tests Failed.</p></div><ol><li><div><a href="https://test-1-23.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=6/335899//consoleText">AXIS_VARIABLE=6 #335899</a><ol><li><div><a href="https://test-1-23.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=6/335899//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanXMLLog">com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog</a><pre><code>junit.framework.AssertionFailedError: 

JSON storage adapter is deprecated, using default storage adapter

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)

at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)

at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)

at java.nio.file.Files.walkFileTree(Files.java:2670)

at java.nio.file.Files.walkFileTree(Files.java:2742)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

AXIS_VARIABLE=7 #335899

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError:

Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)

at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)

at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)

at java.nio.file.Files.walkFileTree(Files.java:2670)

at java.nio.file.Files.walkFileTree(Files.java:2742)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

liferay-continuous-integration · 2021-12-22T14:46:13Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#1705

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-tango#1992

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - YurenaC > liferay-tango - PR#1992 - 2021-12-22[04:27:43]

Testray Importer:publish-testray-report#5271

beltranrengifo · 2021-12-22T14:46:44Z

ci:forward

liferay-continuous-integration · 2021-12-22T14:46:50Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-12-22T14:46:53Z

Skipping previously passed test suites:
ci:test:relevant

liferay-continuous-integration · 2021-12-22T14:50:48Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ad36b8c4f2c0a9f5be5f304ba88eb629ba12a85a

Sender Branch:

Branch Name: LPS-101448-Clean
Branch GIT ID: 4c4245b3312cdb1c5def30ab2297f09fdea63dae

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-12-22T14:50:54Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2021-12-22T14:51:37Z

Pull request has been successfully forwarded to brianchandotcom#111495
Console

liferay-continuous-integration · 2021-12-22T14:52:53Z

Jenkins Build:test-portal-source-format#1299

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-tango#1992

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - YurenaC > liferay-tango - PR#1992 - 2021-12-22[06:47:39]

Testray Importer:publish-testray-report#4302

Beltran Rengifo and others added 30 commits December 21, 2021 09:07

LPS-101448 Add getData method for building frontend component props

be4d559

LPS-101448 Add frontend main components

9c00cdd

LPS-101448 Drag and drop is functional for variations nav

1751897

LPS-101448 Add actions item menu for AA. Minor refactor

986cb92

LPS-101448 Moving DropDownItem to its own file. Main component renaming

3f74284

LPS-101448 Add deleteAssetListEntryVariationURL and assetListEntrySeg…

87f482a

…mentsEntryRelId to frontend JSON object

LPS-101448 Non default variations are deleteable from the VariationNa…

0f7707b

…v list

LPS-101448 Add priority column in database

a3f9f70

LPS-101448 Autogenerated

da4fcbb

LPS-101448 Generated buildUpgradeTable

3dc0398

LPS-101448 Added ActionCommand to update variations priority

ea2f836

- Priority is set by the array order

LPS-101448 Added updateVariationsPriorityURL field

fa64703

- When variations are reorder, should call that URL automatically

LPS-101448 Auto sf

061ea8e

LPS-101448 Extracted MockPortletURL class, used in different test cla…

51cd0ed

…sses

LPS-101448 Added test for update variations priority

9d3d21f

LPS-101448 Fixing service class in component

15755a0

LPS-101448 Auto sf

e6fe420

LPS-101448 Fix assetListPortletURL

95f8f8b

LPS-101448 Frontend integration for saving variations priority

4d1c0ee

LPS-101448 Frontend unit testing for VariationsNav and child components

e8d7688

LPS-101448 Sorting variations by priority

1fa847b

LPS-101448 Rename variable to kebabcase

2528e7c

LPS-101448 UI refinement

d79a9a6

LPS-101448 Minor refactor for sortable items

b3439ad

LPS-101448 Add texts using Liferay.Language

3f4d68d

LPS-101448 Frontend unit testing after UI refinement

a81b9d3

LPS-101448 formatSource

109f4bb

LPS-101448 Feature Flag creation

aa9d033

LPS-101448 Feature Flag passed to the front in the context

ef84650

LPS-101448 Added missing dependencies

71181c7

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels Dec 22, 2021

Yurena Cabrera added 2 commits December 22, 2021 11:39

LPS-101448 FF fix

230aa43

LPS-101448 Auto sf

4c4245b

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - pending ci:test:relevant - pending labels Dec 22, 2021

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Dec 22, 2021

liferay-continuous-integration mentioned this pull request Dec 22, 2021

LPS-101448 Collections Variations to be reordered for prioritization purposes while accessing the details brianchandotcom/liferay-portal#111495

Closed

liferay-continuous-integration closed this Dec 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-101448 Collections Variations to be reordered for prioritization purposes while accessing the details #1992

LPS-101448 Collections Variations to be reordered for prioritization purposes while accessing the details #1992

YurenaC commented Dec 21, 2021 •

edited

Loading

liferay-continuous-integration commented Dec 22, 2021

Base Branch:

Upstream Comparison:

For more details click here.

liferay-continuous-integration commented Dec 22, 2021

YurenaC commented Dec 22, 2021

liferay-continuous-integration commented Dec 22, 2021

Base Branch:

Upstream Comparison:

4 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

liferay-continuous-integration commented Dec 22, 2021

beltranrengifo commented Dec 22, 2021

liferay-continuous-integration commented Dec 22, 2021

liferay-continuous-integration commented Dec 22, 2021

liferay-continuous-integration commented Dec 22, 2021

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Dec 22, 2021

liferay-continuous-integration commented Dec 22, 2021

liferay-continuous-integration commented Dec 22, 2021

LPS-101448 Collections Variations to be reordered for prioritization purposes while accessing the details #1992

LPS-101448 Collections Variations to be reordered for prioritization purposes while accessing the details #1992

Conversation

YurenaC commented Dec 21, 2021 • edited Loading

Motivation

Proposed Solution

Steps to Verify:

liferay-continuous-integration commented Dec 22, 2021

❌ ci:test:relevant - 0 out of 1 jobs passed in 38 minutes

Base Branch:

Upstream Comparison:

For more details click here.

liferay-continuous-integration commented Dec 22, 2021

YurenaC commented Dec 22, 2021

liferay-continuous-integration commented Dec 22, 2021

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 26 out of 29 jobs passed in 2 hours 11 minutes

Base Branch:

Upstream Comparison:

4 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

liferay-continuous-integration commented Dec 22, 2021

beltranrengifo commented Dec 22, 2021

liferay-continuous-integration commented Dec 22, 2021

liferay-continuous-integration commented Dec 22, 2021

liferay-continuous-integration commented Dec 22, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Dec 22, 2021

liferay-continuous-integration commented Dec 22, 2021

liferay-continuous-integration commented Dec 22, 2021

YurenaC commented Dec 21, 2021 •

edited

Loading