LPS 131395 Fix line chart and pie chart popover styles #2144

claraizquierdo · 2022-01-31T10:42:18Z

Motivation

Pie chart and line chart popover styles in Content Performance panel are not in sync with Lexicon popover styles
Link to ticket

Proposed Solution

We have added .popover classes to charts popovers so that they inherit the styles from Clay Popovers. We have also removed unnecessary styles.

Steps to Verify:

Open Content Perfomance Panel
Hover over the donut chart
Hover over the line chart
If you want to verify this behaviour with more data cherry-pick this commit: claraizquierdo@e3275f1

Change summary (optional):

LPS-131395 Change pie chart popover styles to be the same as ClayPopover
LPS-131395 Change line chart popover styles to be the same as ClayPopover

Screenshots (optional):

Before:

After:

liferay-continuous-integration · 2022-01-31T10:42:28Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

claraizquierdo · 2022-01-31T11:02:09Z

ci:test:sf

liferay-continuous-integration · 2022-01-31T11:06:02Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8e3c0cafbe1bd373d7d44150f855efd5c343412f

Sender Branch:

Branch Name: LPS-131395
Branch GIT ID: b6aa55373f14dddf9e4dcabbdc41d30b68bb7bc7

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2022-01-31T11:07:42Z

Jenkins Build:test-portal-source-format#1246

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-tango#2144

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - liferay-tango > liferay-tango - PR#2144 - 2022-01-31[03:02:24]

Testray Importer:publish-testray-report#4258

…over

beltranrengifo

LGTM

...s/analytics-reports-web/src/main/resources/META-INF/resources/css/analytics-reports-app.scss

claraizquierdo · 2022-02-01T08:47:12Z

ci:test:relevant

liferay-continuous-integration · 2022-02-01T10:36:13Z

✔️ ci:test:stable - 21 out of 25 jobs passed

✔️ ci:test:relevant - 24 out of 28 jobs passed in 1 hour 47 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0fe5a379dbda167300085e2b96614224c617d89e

Upstream Comparison:

Branch GIT ID: 0fe5a379dbda167300085e2b96614224c617d89e
Jenkins Build URL: Acceptance Upstream DXP (master) #2873

ci:test:stable - 21 out of 25 jobs PASSED

4 Failed Jobs:

21 Successful Jobs:

ci:test:relevant - 23 out of 28 jobs PASSED

5 Failed Jobs:

23 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 0fe5a37:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #31122

Please fix semantic versioning on liferay-tango/LPS-131395

     [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
     [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.portal.kernel.util                     MAJOR      23.0.0     23.0.0     24.0.0     VERSION INCREASE REQUIRED
     [exec]   >   interface  com.liferay.portal.kernel.util.PropsKeys
     [exec]     -   field      PORTLET_URL_GENERATE_BY_PATH_ENABLED
     [exec]       -   access     final
     [exec]       -   access     static
     [exec]       -   constant   portlet.url.generate.by.path.enabled
     [exec]       -   return     java.lang.String
     [exec] [Baseline Warning] Bundle Version Change Recommended: 34.0.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/33.0.0/a67dd6264c43c6276987fcefdfc7290fe126de7a/com.liferay.portal.kernel-33.0.0.jar

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
Job Results:
103 Tests Passed.
4 Tests Failed.
1. AXIS_VARIABLE=0 #29335

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

2 Tests Passed.
3 Tests Failed.

AXIS_VARIABLE=0 #448032

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: 
Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1643709393164.log:
!SESSION 2022-02-01 09:56:49.571 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_121
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
!ENTRY com.liferay.portal.odata.impl 4 0 2022-02-01 09:56:49.572

!MESSAGE FrameworkEvent ERROR

!STACK 0

org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.odata.impl [89]

Unresolved requirement: Import-Package: io.netty.buffer
at org.eclipse.osgi.container.Module.start(Module.java:444)

at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)

at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)

at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)

at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)

at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)

at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)

at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
!ENTRY com.liferay.site.initializer.extender 4 0 2022-02-01 09:56:...

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: FrameworkEvent ERROR org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.odata.impl [89] Unresolved requirement: Import-Package: io.netty.buffer at org.eclipse.osgi.container.Module.start(Module.java:444) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1) at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230) at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171) at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98) at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88) at java.nio.file.Files.walkFileTree(Files.java:2670) at java.nio.file.Files.walkFileTree(Files.java:2742) at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(Por...

LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

1116 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=1 #484895

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError:

com.liferay.portal.kernel.exception.PortalException: Unable to search with filter ((customField/_52127_9fjnIWS7 eq 'Y4bEsc0C')) and (classPK eq '20128')

com.liferay.portal.kernel.exception.PortalException: Unable to search with filter ((customField/_52127_9fjnIWS7 eq 'Y4bEsc0C')) and (classPK eq '20128')

at com.liferay.segments.internal.odata.search.ODataSearchAdapterImpl.searchCount(ODataSearchAdapterImpl.java:110)

at com.liferay.segments.internal.odata.retriever.UserODataRetriever.getResultsCount(UserODataRetriever.java:69)

at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.isMember(BaseSegmentsEntryProvider.java:286)

at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.lambda$getSegmentsEntryIds$1(BaseSegmentsEntryProvider.java:153)

at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174)

at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)

at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)

at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)

at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:545)

at java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)

at java.util.stream.LongPipeline.toArray(LongPipeline.java:484)

at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.getSegmentsEntryIds(BaseSegmentsEntryProvider.java:157)

at com.lif...

AXIS_VARIABLE=2 #484895

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError:

com.liferay.portal.kernel.exception.PortalException: Unable to search with filter ((customField/_59370_w3s70Oai eq 'GmigHOnu')) and (classPK eq '20128')

com.liferay.portal.kernel.exception.PortalException: Unable to search with filter ((customField/_59370_w3s70Oai eq 'GmigHOnu')) and (classPK eq '20128')

at com.liferay.segments.internal.odata.search.ODataSearchAdapterImpl.searchCount(ODataSearchAdapterImpl.java:110)

at com.liferay.segments.internal.odata.retriever.UserODataRetriever.getResultsCount(UserODataRetriever.java:69)

at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.isMember(BaseSegmentsEntryProvider.java:286)

at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.lambda$getSegmentsEntryIds$1(BaseSegmentsEntryProvider.java:153)

at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174)

at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)

at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)

at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)

at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:545)

at java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)

at java.util.stream.LongPipeline.toArray(LongPipeline.java:484)

at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.getSegmentsEntryIds(BaseSegmentsEntryProvider.java:157)

at com.lif...

liferay-continuous-integration · 2022-02-01T11:11:38Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#1961

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-tango#2144

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - liferay-tango > liferay-tango - PR#2144 - 2022-02-01[00:47:46]

Testray Importer:publish-testray-report#5849

claraizquierdo · 2022-02-01T11:16:29Z

ci:forward

liferay-continuous-integration · 2022-02-01T11:16:34Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2022-02-01T11:16:42Z

Skipping previously passed test suites:
ci:test:relevant

liferay-continuous-integration · 2022-02-01T11:20:42Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0fe5a379dbda167300085e2b96614224c617d89e

Sender Branch:

Branch Name: LPS-131395
Branch GIT ID: af06b6b095ea4f1ef7689c9faa36e28ecda0454e

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2022-02-01T11:20:52Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2022-02-01T11:21:17Z

Pull request has been successfully forwarded to brianchandotcom#112907
Console

liferay-continuous-integration · 2022-02-01T11:23:24Z

Jenkins Build:test-portal-source-format#4914

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-tango#2144

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - liferay-tango > liferay-tango - PR#2144 - 2022-02-01[03:16:54]

Testray Importer:publish-testray-report#2501

Stephy6

Review finished!

claraizquierdo force-pushed the LPS-131395 branch from 3833b62 to b6aa553 Compare January 31, 2022 10:44

claraizquierdo changed the title ~~LPS 131395~~ LPS 131395 Fix line chart and pie chart popover styles Jan 31, 2022

claraizquierdo requested review from beltranrengifo and Stephy6 January 31, 2022 11:01

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Jan 31, 2022

claraizquierdo added 2 commits January 31, 2022 12:13

LPS-131395 Change pie chart popover styles to be the same as ClayPopover

0564c56

LPS-131395 Change line chart popover styles to be the same as ClayPop…

af06b6b

…over

claraizquierdo force-pushed the LPS-131395 branch from b6aa553 to af06b6b Compare January 31, 2022 11:14

beltranrengifo approved these changes Jan 31, 2022

View reviewed changes

...s/analytics-reports-web/src/main/resources/META-INF/resources/css/analytics-reports-app.scss Show resolved Hide resolved

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 1, 2022

liferay-continuous-integration added ci:test:sf - pending and removed ci:test:sf - success ci:test:sf - pending labels Feb 1, 2022

liferay-continuous-integration added the ci:test:sf - success label Feb 1, 2022

liferay-continuous-integration mentioned this pull request Feb 1, 2022

LPS 131395 Fix line chart and pie chart popover styles brianchandotcom/liferay-portal#112907

Closed

liferay-continuous-integration closed this Feb 1, 2022

Stephy6 reviewed Feb 1, 2022

View reviewed changes

LPS 131395 Fix line chart and pie chart popover styles #2144

LPS 131395 Fix line chart and pie chart popover styles #2144

Conversation

claraizquierdo commented Jan 31, 2022 • edited Loading

Motivation

Proposed Solution

Steps to Verify:

Change summary (optional):

Screenshots (optional):

liferay-continuous-integration commented Jan 31, 2022

claraizquierdo commented Jan 31, 2022

liferay-continuous-integration commented Jan 31, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jan 31, 2022

beltranrengifo left a comment

Choose a reason for hiding this comment

claraizquierdo commented Feb 1, 2022

liferay-continuous-integration commented Feb 1, 2022

✔️ ci:test:stable - 21 out of 25 jobs passed

✔️ ci:test:relevant - 24 out of 28 jobs passed in 1 hour 47 minutes

Base Branch:

Upstream Comparison:

4 Failed Jobs:

5 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Feb 1, 2022

claraizquierdo commented Feb 1, 2022

liferay-continuous-integration commented Feb 1, 2022

liferay-continuous-integration commented Feb 1, 2022

liferay-continuous-integration commented Feb 1, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 1, 2022

liferay-continuous-integration commented Feb 1, 2022

liferay-continuous-integration commented Feb 1, 2022

Stephy6 left a comment

Choose a reason for hiding this comment

claraizquierdo commented Jan 31, 2022 •

edited

Loading